[v2,09/18] media: venus: Remove unused structs
Commit Message
This structures are not used, and have a single element array at the end
of them. Remove them.
This fix the following cocci warnings:
drivers/media/platform/qcom/venus/hfi_helper.h:764:5-15: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays)
drivers/media/platform/qcom/venus/hfi_helper.h:1041:5-15: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays)
drivers/media/platform/qcom/venus/hfi_helper.h:1088:39-51: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays)
drivers/media/platform/qcom/venus/hfi_helper.h:1093:5-22: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays)
drivers/media/platform/qcom/venus/hfi_helper.h:1144:4-8: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays)
drivers/media/platform/qcom/venus/hfi_helper.h:1239:4-8: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays)
drivers/media/platform/qcom/venus/hfi_helper.h:1272:4-13: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays)
drivers/media/platform/qcom/venus/hfi_cmds.h:85:5-16: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays)
drivers/media/platform/qcom/venus/hfi_cmds.h:180:5-9: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays)
drivers/media/platform/qcom/venus/hfi_cmds.h:189:5-9: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays)
Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
---
drivers/media/platform/qcom/venus/hfi_cmds.h | 26 -----------------
drivers/media/platform/qcom/venus/hfi_helper.h | 39 --------------------------
2 files changed, 65 deletions(-)
Comments
On 07/05/2024 17:27, Ricardo Ribalda wrote:
> This structures are not used, and have a single element array at the end
> of them. Remove them.
>
> This fix the following cocci warnings:
> drivers/media/platform/qcom/venus/hfi_helper.h:764:5-15: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays)
> drivers/media/platform/qcom/venus/hfi_helper.h:1041:5-15: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays)
> drivers/media/platform/qcom/venus/hfi_helper.h:1088:39-51: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays)
> drivers/media/platform/qcom/venus/hfi_helper.h:1093:5-22: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays)
> drivers/media/platform/qcom/venus/hfi_helper.h:1144:4-8: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays)
> drivers/media/platform/qcom/venus/hfi_helper.h:1239:4-8: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays)
> drivers/media/platform/qcom/venus/hfi_helper.h:1272:4-13: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays)
> drivers/media/platform/qcom/venus/hfi_cmds.h:85:5-16: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays)
> drivers/media/platform/qcom/venus/hfi_cmds.h:180:5-9: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays)
> drivers/media/platform/qcom/venus/hfi_cmds.h:189:5-9: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays)
>
> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
There's nothing inherently wrong with defining a protocol upfront in the
form of a structure for future expansion.
These structures are documentary of the host <-> firmware interface and
are of use when implementing new features.
I think these structures should just have the "[1] -> []" conversion
done and be retained instead.
---
bod
On 10/05/2024 00:35, Bryan O'Donoghue wrote:
> I think these structures should just have the "[1] -> []" conversion
> done and be retained instead.
They won't have the same sizeof() then so ignore that thought.
I still would suggest dropping the `something[1]` in favour of
`something` because these structures document the protocol between host
and firmware and therefore are useful even if unused in the code.
---
bod
Hi Bryan
Thanks for your review
On Fri, 10 May 2024 at 01:56, Bryan O'Donoghue
<bryan.odonoghue@linaro.org> wrote:
>
> On 10/05/2024 00:35, Bryan O'Donoghue wrote:
> > I think these structures should just have the "[1] -> []" conversion
> > done and be retained instead.
>
> They won't have the same sizeof() then so ignore that thought.
>
> I still would suggest dropping the `something[1]` in favour of
> `something` because these structures document the protocol between host
> and firmware and therefore are useful even if unused in the code.
The structures will be in the git log for the rest of the days. So if
someone has to use them, they can recover them from there.
Right now, they are not used and they are triggering a warning. I
would argue that untested code is broken code.
I'd rather remove the code.
>
> ---
> bod
@@ -77,14 +77,6 @@ struct hfi_sys_get_property_pkt {
u32 data[1];
};
-struct hfi_sys_set_buffers_pkt {
- struct hfi_pkt_hdr hdr;
- u32 buffer_type;
- u32 buffer_size;
- u32 num_buffers;
- u32 buffer_addr[1];
-};
-
struct hfi_sys_ping_pkt {
struct hfi_pkt_hdr hdr;
u32 client_data;
@@ -171,24 +163,6 @@ struct hfi_session_empty_buffer_uncompressed_plane0_pkt {
u32 data[1];
};
-struct hfi_session_empty_buffer_uncompressed_plane1_pkt {
- u32 flags;
- u32 alloc_len;
- u32 filled_len;
- u32 offset;
- u32 packet_buffer2;
- u32 data[1];
-};
-
-struct hfi_session_empty_buffer_uncompressed_plane2_pkt {
- u32 flags;
- u32 alloc_len;
- u32 filled_len;
- u32 offset;
- u32 packet_buffer3;
- u32 data[1];
-};
-
struct hfi_session_fill_buffer_pkt {
struct hfi_session_hdr_pkt shdr;
u32 stream_id;
@@ -759,11 +759,6 @@ struct hfi_multi_stream_3x {
u32 enable;
};
-struct hfi_multi_view_format {
- u32 views;
- u32 view_order[1];
-};
-
#define HFI_MULTI_SLICE_OFF 0x1
#define HFI_MULTI_SLICE_BY_MB_COUNT 0x2
#define HFI_MULTI_SLICE_BY_BYTE_COUNT 0x3
@@ -1036,11 +1031,6 @@ struct hfi_codec_supported {
u32 enc_codecs;
};
-struct hfi_properties_supported {
- u32 num_properties;
- u32 properties[1];
-};
-
struct hfi_max_sessions_supported {
u32 max_sessions;
};
@@ -1083,16 +1073,6 @@ struct hfi_resource_ocmem_requirement {
u32 size;
};
-struct hfi_resource_ocmem_requirement_info {
- u32 num_entries;
- struct hfi_resource_ocmem_requirement requirements[1];
-};
-
-struct hfi_property_sys_image_version_info_type {
- u32 string_size;
- u8 str_image_version[1];
-};
-
struct hfi_codec_mask_supported {
u32 codecs;
u32 video_domains;
@@ -1135,15 +1115,6 @@ struct hfi_index_extradata_config {
u32 index_extra_data_id;
};
-struct hfi_extradata_header {
- u32 size;
- u32 version;
- u32 port_index;
- u32 type;
- u32 data_size;
- u8 data[1];
-};
-
struct hfi_batch_info {
u32 input_batch_count;
u32 output_batch_count;
@@ -1234,11 +1205,6 @@ static inline void hfi_bufreq_set_count_min_host(struct hfi_buffer_requirements
req->count_min = val;
};
-struct hfi_data_payload {
- u32 size;
- u8 data[1];
-};
-
struct hfi_enable_picture {
u32 picture_type;
};
@@ -1267,11 +1233,6 @@ struct hfi_buffer_alloc_mode_supported {
u32 data[1];
};
-struct hfi_mb_error_map {
- u32 error_map_size;
- u8 error_map[1];
-};
-
struct hfi_metadata_pass_through {
int enable;
u32 size;