| Message ID | 20240507-cocci-flexarray-v2-17-7aea262cf065@chromium.org (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Stanimir Varbanov |
| Headers |
Received: from sv.mirrors.kernel.org ([139.178.88.99])
by linuxtv.org with esmtps (TLS1.3) tls
TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
(Exim 4.96)
(envelope-from
<linux-media+bounces-11081-patchwork=linuxtv.org@vger.kernel.org>)
id 1s4Njf-0000Bf-2c
for patchwork@linuxtv.org;
Tue, 07 May 2024 16:32:12 +0000
Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org
[52.25.139.140])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
by sv.mirrors.kernel.org (Postfix) with ESMTPS id 2A5C828C7F1
for <patchwork@linuxtv.org>; Tue, 7 May 2024 16:32:11 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
by smtp.subspace.kernel.org (Postfix) with ESMTP id 016D61779BB;
Tue, 7 May 2024 16:27:27 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org
header.b="gbeaYeYD"
X-Original-To: linux-media@vger.kernel.org
Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com
[209.85.160.169])
(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
(No client certificate requested)
by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA34B16F8E9
for <linux-media@vger.kernel.org>; Tue, 7 May 2024 16:27:24 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
arc=none smtp.client-ip=209.85.160.169
ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
t=1715099246; cv=none;
b=hLSrTIFgKBa5lC65kE0MDB2IXwm2ClamgmKG4f9+zxbDwdwshN8NQwuilk00CFF0ondmcpzMFm5KKKc3u4jImZwJCukDPZZlmL/IoTlNR1MyKNSix1277x8Q5d3RJf64zDkDy19b2Q0mUKvzD3BasANZ4lszYg0V8K/Y3hQwhKQ=
ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org;
s=arc-20240116; t=1715099246; c=relaxed/simple;
bh=elaKiW1ZWISf7j4z+HRijCG6vyiv0mxL1YyGQ0pIffU=;
h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References:
In-Reply-To:To:Cc;
b=gBMh3hwkpjl9U+6V+qxpwQQo9MsGs/4Od1tcp8DNjfIQ1nFPa08RmfJYDOwo38IuPVUKl6xUjy1XrzX5fTh2pWe04Oat8cFZknt+e0w+DbrqzmKWMBAW+DuxpywFO3G9qRIByqS2vhOJvI4tM4Da/HikcrWZU2ONzERVys6Z6wQ=
ARC-Authentication-Results: i=1; smtp.subspace.kernel.org;
dmarc=pass (p=none dis=none) header.from=chromium.org;
spf=pass smtp.mailfrom=chromium.org;
dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org
header.b=gbeaYeYD; arc=none smtp.client-ip=209.85.160.169
Authentication-Results: smtp.subspace.kernel.org;
dmarc=pass (p=none dis=none) header.from=chromium.org
Authentication-Results: smtp.subspace.kernel.org;
spf=pass smtp.mailfrom=chromium.org
Received: by mail-qt1-f169.google.com with SMTP id
d75a77b69052e-43a317135a5so23474471cf.0
for <linux-media@vger.kernel.org>;
Tue, 07 May 2024 09:27:24 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=chromium.org; s=google; t=1715099244; x=1715704044;
darn=vger.kernel.org;
h=cc:to:in-reply-to:references:message-id:content-transfer-encoding
:mime-version:subject:date:from:from:to:cc:subject:date:message-id
:reply-to;
bh=LytlgeivFEVadVFPCSFVFsEkz0aZMS5bY0SwfM06VYA=;
b=gbeaYeYD9SQGdJpgHvvKL0W9LWYoJZzA8/TW22Ucyy0QUvFRuNNcAZAc/w316vBWKJ
Hr7AbCmkz0Dl0NqwMX//cMS0amRkxd3D9GdxWBGOowoTMAeGCV/KKKHmo+DzghH880+i
A85ysOKgGpxD8vuaDcPq0NpDRmBSMX+x0GpqQ=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1715099244; x=1715704044;
h=cc:to:in-reply-to:references:message-id:content-transfer-encoding
:mime-version:subject:date:from:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=LytlgeivFEVadVFPCSFVFsEkz0aZMS5bY0SwfM06VYA=;
b=Z7CULzAKBvCxoriDjRBL7hSO7DEd8VgToiBZmsrvrLaZR/y+zVyyTK0S4cXIcc/E0W
d0TGDlmKoZfPnNo/tknZLghzAFc0qwTCeAEeTwkCxvsxHb/yleFL9Tqb1sXPTNK3l6jJ
msq3XdyW91bvk1SFMlJbLFwBjQlyygXINSf/orD78BNV47Heh4Ns0pttDKoNKLWvdtKA
sT0LARw6qU52dPdzrXixFJxwJuSu1cpeLpSxqzgmby/Vdy2yxBk1RAIiwEsxB2MYtxg8
kZkelr4bsLZTePmoJ7cQKDOfSREeQXKNFlGGYp1AtEQL0cQuwEoGknhPaTZNpplZSqco
r2VQ==
X-Gm-Message-State: AOJu0Yw3sQ5KZCbHBX/l/D0nILqIsPahoaXpB1w/eCmEW0BYa5fFWExk
3ArJ1Qo6kKEg1E0BHg3sXR2HpWiLnddYv8Lj8XlG81a8ybsz2+19m1/poJnZzg==
X-Google-Smtp-Source:
AGHT+IH3mMeaAQ3dPkDbtiyOlqK0t/M43w6OxFHdMVW2XCWSC0GBNoCeALnYs1IDQynVDH2ifLt8lg==
X-Received: by 2002:ac8:7d0a:0:b0:43b:173e:ce1b with SMTP id
d75a77b69052e-43d8f7cec66mr50519711cf.32.1715099243729;
Tue, 07 May 2024 09:27:23 -0700 (PDT)
Received: from denia.c.googlers.com (114.152.245.35.bc.googleusercontent.com.
[35.245.152.114])
by smtp.gmail.com with ESMTPSA id
hf23-20020a05622a609700b0043d1fc9b7d9sm4160597qtb.48.2024.05.07.09.27.22
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Tue, 07 May 2024 09:27:23 -0700 (PDT)
From: Ricardo Ribalda <ribalda@chromium.org>
Date: Tue, 07 May 2024 16:27:22 +0000
Subject: [PATCH v2 17/18] media: venus: Refactor
hfi_session_fill_buffer_pkt
Precedence: bulk
X-Mailing-List: linux-media@vger.kernel.org
List-Id: <linux-media.vger.kernel.org>
List-Subscribe: <mailto:linux-media+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-media+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <20240507-cocci-flexarray-v2-17-7aea262cf065@chromium.org>
References: <20240507-cocci-flexarray-v2-0-7aea262cf065@chromium.org>
In-Reply-To: <20240507-cocci-flexarray-v2-0-7aea262cf065@chromium.org>
To: Michael Tretter <m.tretter@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Michal Simek <michal.simek@amd.com>, Andy Walls <awalls@md.metrocast.net>,
Stanimir Varbanov <stanimir.k.varbanov@gmail.com>,
Vikash Garodia <quic_vgarodia@quicinc.com>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Ricardo Ribalda <ribalda@chromium.org>
X-Mailer: b4 0.12.4
X-LSpam-Score: -5.9 (-----)
X-LSpam-Report: No,
score=-5.9 required=5.0 tests=ARC_SIGNED=0.001,ARC_VALID=-0.1,BAYES_00=-1.9,DKIMWL_WL_HIGH=-1,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,DMARC_PASS=-0.001,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1,RCVD_IN_DNSWL_MED=-2.3,SPF_HELO_NONE=0.001,SPF_PASS=-0.001
autolearn=ham autolearn_force=no
|
| Series |
media: Fix the last set of coccinelle warnings
|
|
Commit Message
Ricardo Ribalda
May 7, 2024, 4:27 p.m. UTC
The single data array data[1] is only used to save the extradata_size.
Replace it with a single element field.
This fixes the following cocci warning:
drivers/media/platform/qcom/venus/hfi_cmds.h:175:5-9: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays)
Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
---
drivers/media/platform/qcom/venus/hfi_cmds.c | 2 +-
drivers/media/platform/qcom/venus/hfi_cmds.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
Comments
On 07/05/2024 17:27, Ricardo Ribalda wrote: > - u32 data[1]; > + u32 extradata_size; A correct functional change but again please keep the name to `data` not `extradata_size` Then add Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> --- bod
diff --git a/drivers/media/platform/qcom/venus/hfi_cmds.c b/drivers/media/platform/qcom/venus/hfi_cmds.c index c5123f2e76fe..35423e211ddd 100644 --- a/drivers/media/platform/qcom/venus/hfi_cmds.c +++ b/drivers/media/platform/qcom/venus/hfi_cmds.c @@ -331,7 +331,7 @@ int pkt_session_ftb(struct hfi_session_fill_buffer_pkt *pkt, void *cookie, pkt->alloc_len = out_frame->alloc_len; pkt->filled_len = out_frame->filled_len; pkt->offset = out_frame->offset; - pkt->data[0] = out_frame->extradata_size; + pkt->extradata_size = out_frame->extradata_size; return 0; } diff --git a/drivers/media/platform/qcom/venus/hfi_cmds.h b/drivers/media/platform/qcom/venus/hfi_cmds.h index cd7902743f62..0ccc4102ac3d 100644 --- a/drivers/media/platform/qcom/venus/hfi_cmds.h +++ b/drivers/media/platform/qcom/venus/hfi_cmds.h @@ -172,7 +172,7 @@ struct hfi_session_fill_buffer_pkt { u32 output_tag; u32 packet_buffer; u32 extradata_buffer; - u32 data[1]; + u32 extradata_size; }; struct hfi_session_flush_pkt {