diff mbox

[1/2] soc_camera: Add FLDPOL flags

Message ID utz7hm9r1.wl%morimoto.kuninori@renesas.com (mailing list archive)
State Rejected, archived
Headers

Commit Message

Kuninori Morimoto Jan. 30, 2009, 4:15 a.m. UTC 
  Signed-off-by: Kuninori Morimoto <morimoto.kuninori@renesas.com>
---
 include/media/soc_camera.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

Comments

Guennadi Liakhovetski Feb. 1, 2009, 7:07 p.m. UTC | #1 
On Fri, 30 Jan 2009, Kuninori Morimoto wrote:

> 
> Signed-off-by: Kuninori Morimoto <morimoto.kuninori@renesas.com>
> ---
>  include/media/soc_camera.h |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/include/media/soc_camera.h b/include/media/soc_camera.h
> index 7440d92..2c7ecdf 100644
> --- a/include/media/soc_camera.h
> +++ b/include/media/soc_camera.h
> @@ -231,6 +231,8 @@ static inline struct v4l2_queryctrl const *soc_camera_find_qctrl(
>  #define SOCAM_PCLK_SAMPLE_FALLING	(1 << 13)
>  #define SOCAM_DATA_ACTIVE_HIGH		(1 << 14)
>  #define SOCAM_DATA_ACTIVE_LOW		(1 << 15)
> +#define SOCAM_FLDPOL_ACTIVE_HIGH	(1 << 16)
> +#define SOCAM_FLDPOL_ACTIVE_LOW		(1 << 17)
>  
>  #define SOCAM_DATAWIDTH_MASK (SOCAM_DATAWIDTH_4 | SOCAM_DATAWIDTH_8 | \
>  			      SOCAM_DATAWIDTH_9 | SOCAM_DATAWIDTH_10 | \

"FLDPOL" is the name of a field in the register, and it means "field ID 
polarity," i.e., the polarity of the field ID signal. Hence the name 
you're proposing reads: "field ID polarity active {low,high}," which seems 
redundant to me. What about SOCAM_FIELD_ID_ACTIVE_{HIGH,LOW}? Following 
the scheme "SOCAM_<signal name>_ACTIVE_*."

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/include/media/soc_camera.h b/include/media/soc_camera.h
index 7440d92..2c7ecdf 100644
--- a/include/media/soc_camera.h
+++ b/include/media/soc_camera.h
@@ -231,6 +231,8 @@  static inline struct v4l2_queryctrl const *soc_camera_find_qctrl(
 #define SOCAM_PCLK_SAMPLE_FALLING	(1 << 13)
 #define SOCAM_DATA_ACTIVE_HIGH		(1 << 14)
 #define SOCAM_DATA_ACTIVE_LOW		(1 << 15)
+#define SOCAM_FLDPOL_ACTIVE_HIGH	(1 << 16)
+#define SOCAM_FLDPOL_ACTIVE_LOW		(1 << 17)
 
 #define SOCAM_DATAWIDTH_MASK (SOCAM_DATAWIDTH_4 | SOCAM_DATAWIDTH_8 | \
 			      SOCAM_DATAWIDTH_9 | SOCAM_DATAWIDTH_10 | \