diff mbox series

hv: put parentheses on macros with complex values in hyperv.h

Message ID e4b504ab6a1534cd26be777c9cb0bb6a@208suo.com (mailing list archive)
State Not Applicable
Headers
Series hv: put parentheses on macros with complex values in hyperv.h |

Commit Message

sunran001@208suo.com July 20, 2023, 3:01 a.m. UTC 
  Fix "Macros with complex values should be enclosed in parentheses"
checkpatch error.

Signed-off-by: Ran Sun <sunran001@208suo.com>
---
  include/linux/hyperv.h | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

Comments

kernel test robot July 20, 2023, 4:53 a.m. UTC | #1 
Hi,

kernel test robot noticed the following build errors:

[auto build test ERROR on linus/master]
[also build test ERROR on sailus-media-tree/streams v6.5-rc2 next-20230719]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/sunran001-208suo-com/hv-put-parentheses-on-macros-with-complex-values-in-hyperv-h/20230720-110337
base:   linus/master
patch link:    https://lore.kernel.org/r/e4b504ab6a1534cd26be777c9cb0bb6a%40208suo.com
patch subject: [PATCH] hv: put parentheses on macros with complex values in hyperv.h
config: x86_64-buildonly-randconfig-r003-20230720 (https://download.01.org/0day-ci/archive/20230720/202307201238.b9lOd1rf-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce: (https://download.01.org/0day-ci/archive/20230720/202307201238.b9lOd1rf-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202307201238.b9lOd1rf-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from arch/x86/include/asm/kvm_host.h:27,
                    from include/linux/kvm_host.h:45,
                    from arch/x86/kvm/svm/nested.c:18:
>> include/linux/hyperv.h:431:37: error: expected parameter name, found "("
     431 | #define VMPACKET_DATA_START_ADDRESS((__packet)  \
         |                                     ^


vim +431 include/linux/hyperv.h

   430	
 > 431	#define VMPACKET_DATA_START_ADDRESS((__packet)	\
   432		(void *)(((unsigned char *)__packet) +	\
   433		 ((struct vmpacket_descriptor)__packet)->offset8 * 8))
   434
kernel test robot July 20, 2023, 7:17 a.m. UTC | #2 
Hi,

kernel test robot noticed the following build errors:

[auto build test ERROR on linus/master]
[also build test ERROR on sailus-media-tree/streams v6.5-rc2 next-20230720]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/sunran001-208suo-com/hv-put-parentheses-on-macros-with-complex-values-in-hyperv-h/20230720-110337
base:   linus/master
patch link:    https://lore.kernel.org/r/e4b504ab6a1534cd26be777c9cb0bb6a%40208suo.com
patch subject: [PATCH] hv: put parentheses on macros with complex values in hyperv.h
config: i386-randconfig-i013-20230720 (https://download.01.org/0day-ci/archive/20230720/202307201511.TvSDQJLn-lkp@intel.com/config)
compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project.git 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a)
reproduce: (https://download.01.org/0day-ci/archive/20230720/202307201511.TvSDQJLn-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202307201511.TvSDQJLn-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from arch/x86/events/intel/core.c:17:
   In file included from include/linux/kvm_host.h:45:
   In file included from arch/x86/include/asm/kvm_host.h:27:
>> include/linux/hyperv.h:431:37: error: invalid token in macro parameter list
   #define VMPACKET_DATA_START_ADDRESS((__packet)  \
                                       ^
   1 error generated.


vim +431 include/linux/hyperv.h

   430	
 > 431	#define VMPACKET_DATA_START_ADDRESS((__packet)	\
   432		(void *)(((unsigned char *)__packet) +	\
   433		 ((struct vmpacket_descriptor)__packet)->offset8 * 8))
   434
diff mbox series

Patch

diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h
index bfbc37ce223b..6f6fdc7cf086 100644
--- a/include/linux/hyperv.h
+++ b/include/linux/hyperv.h
@@ -428,9 +428,9 @@  union vmpacket_largest_possible_header {
  	struct vmdata_gpa_direct data_gpa_direct_hdr;
  };

-#define VMPACKET_DATA_START_ADDRESS(__packet)	\
+#define VMPACKET_DATA_START_ADDRESS((__packet)	\
  	(void *)(((unsigned char *)__packet) +	\
-	 ((struct vmpacket_descriptor)__packet)->offset8 * 8)
+	 ((struct vmpacket_descriptor)__packet)->offset8 * 8))

  #define VMPACKET_DATA_LENGTH(__packet)		\
  	((((struct vmpacket_descriptor)__packet)->len8 -	\