| Message ID | d912d4c6-90ec-ed89-31fa-6a5243a7b0de@cisco.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Delegated to: | Hans Verkuil |
| Headers |
Received: from vger.kernel.org ([209.132.180.67]) by www.linuxtv.org with esmtp (Exim 4.84_2) (envelope-from <linux-media-owner@vger.kernel.org>) id 1fg8r5-0001bT-Nd; Thu, 19 Jul 2018 13:20:28 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731105AbeGSODd (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Thu, 19 Jul 2018 10:03:33 -0400 Received: from aer-iport-2.cisco.com ([173.38.203.52]:40676 "EHLO aer-iport-2.cisco.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727487AbeGSODd (ORCPT <rfc822;linux-media@vger.kernel.org>); Thu, 19 Jul 2018 10:03:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=1214; q=dns/txt; s=iport; t=1532006425; x=1533216025; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=bJQ/POJIXgJLJVHIDNdlyEQmC4pJpAvSe6FULAKQHsE=; b=WWkoRe/LxbM7K6M2EZccjLFQ5WgO71P+6QU7Gx3v1Ynshquoj48cZfVI flRIwfuMkmGY64aZQI5pmiNY+oik7/EANfvNCkoM/aOPkEzpF7/8RXTFS QOQBebopvDFijsunITcFmtfSNO2juwvgCIjk5oembgBzkpdWNwhn6AJ8Q c=; X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0DKAABjj1Bb/xbLJq1cGQEBAQEBAQE?= =?us-ascii?q?BAQEBAQcBAQEBAYUdEiiDfogEX40sLJU7gXoLgXeCdQKDJjQYAQIBAQIBAQJ?= =?us-ascii?q?tKIU2AQEBAQMjVhALFQMCAiYCAlcGAQwGAgEBgxyCAKlOgS6EXYVugQuJTj+?= =?us-ascii?q?BESeCaod8glUCjRmMTwmPJgaBRIQSgkmFTSuRSwIECwIUgUE4gVIzGggbFYM?= =?us-ascii?q?kkFU9MItuAQE?= X-IronPort-AV: E=Sophos;i="5.51,374,1526342400"; d="scan'208";a="5277316" Received: from aer-iport-nat.cisco.com (HELO aer-core-4.cisco.com) ([173.38.203.22]) by aer-iport-2.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Jul 2018 13:20:24 +0000 Received: from [10.47.79.81] ([10.47.79.81]) (authenticated bits=0) by aer-core-4.cisco.com (8.15.2/8.15.2) with ESMTPSA id w6JDKMQa014928 (version=TLSv1.2 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 19 Jul 2018 13:20:23 GMT Subject: Re: [PATCH 2/5] videodev.h: add PIX_FMT_FWHT for use with vicodec To: sakari.ailus@iki.fi, Hans Verkuil <hverkuil@xs4all.nl> Cc: linux-media@vger.kernel.org, Tom aan de Wiel <tom.aandewiel@gmail.com> References: <20180719121353.20021-1-hverkuil@xs4all.nl> <20180719121353.20021-3-hverkuil@xs4all.nl> <20180719131544.kxbwpzssskepwple@lanttu.localdomain> From: Hans Verkuil <hansverk@cisco.com> Message-ID: <d912d4c6-90ec-ed89-31fa-6a5243a7b0de@cisco.com> Date: Thu, 19 Jul 2018 15:20:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20180719131544.kxbwpzssskepwple@lanttu.localdomain> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-User: hansverk X-Outbound-SMTP-Client: 10.47.79.81, [10.47.79.81] X-Outbound-Node: aer-core-4.cisco.com Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org |
Commit Message
Hans Verkuil (hansverk)
July 19, 2018, 1:20 p.m. UTC
On 07/19/18 15:15, sakari.ailus@iki.fi wrote: > On Thu, Jul 19, 2018 at 02:13:50PM +0200, Hans Verkuil wrote: >> From: Hans Verkuil <hansverk@cisco.com> >> >> Add a new pixelformat for the vicodec software codec using the >> Fast Walsh Hadamard Transform. >> >> Signed-off-by: Hans Verkuil <hansverk@cisco.com> > > Could you add documentation for this format, please? > ??? It's part of the patch: Since the whole codec is implemented in the vicodec source I didn't think it necessary to say more about it. Regards, Hans
Comments
On Thu, Jul 19, 2018 at 03:20:22PM +0200, Hans Verkuil wrote: > On 07/19/18 15:15, sakari.ailus@iki.fi wrote: > > On Thu, Jul 19, 2018 at 02:13:50PM +0200, Hans Verkuil wrote: > >> From: Hans Verkuil <hansverk@cisco.com> > >> > >> Add a new pixelformat for the vicodec software codec using the > >> Fast Walsh Hadamard Transform. > >> > >> Signed-off-by: Hans Verkuil <hansverk@cisco.com> > > > > Could you add documentation for this format, please? > > > > ??? It's part of the patch: > > diff --git a/Documentation/media/uapi/v4l/pixfmt-compressed.rst b/Documentation/media/uapi/v4l/pixfmt-compressed.rst > index abec03937bb3..e5419f046b59 100644 > --- a/Documentation/media/uapi/v4l/pixfmt-compressed.rst > +++ b/Documentation/media/uapi/v4l/pixfmt-compressed.rst > @@ -95,3 +95,10 @@ Compressed Formats > - ``V4L2_PIX_FMT_HEVC`` > - 'HEVC' > - HEVC/H.265 video elementary stream. > + * .. _V4L2-PIX-FMT-FWHT: > + > + - ``V4L2_PIX_FMT_FWHT`` > + - 'FWHT' > + - Video elementary stream using a codec based on the Fast Walsh Hadamard > + Transform. This codec is implemented by the vicodec ('Virtual Codec') > + driver. > > Since the whole codec is implemented in the vicodec source I didn't think it > necessary to say more about it. Oh, well. The source is there but user space developers shouldn't need to read it. OTOH it might be that they're also not the primary audience for this driver either. If there's a Wikipedia article you could refer to or such that'd be fine IMO, too. Up to you.
On 07/19/2018 05:39 PM, Sakari Ailus wrote: > On Thu, Jul 19, 2018 at 03:20:22PM +0200, Hans Verkuil wrote: >> On 07/19/18 15:15, sakari.ailus@iki.fi wrote: >>> On Thu, Jul 19, 2018 at 02:13:50PM +0200, Hans Verkuil wrote: >>>> From: Hans Verkuil <hansverk@cisco.com> >>>> >>>> Add a new pixelformat for the vicodec software codec using the >>>> Fast Walsh Hadamard Transform. >>>> >>>> Signed-off-by: Hans Verkuil <hansverk@cisco.com> >>> >>> Could you add documentation for this format, please? >>> >> >> ??? It's part of the patch: >> >> diff --git a/Documentation/media/uapi/v4l/pixfmt-compressed.rst b/Documentation/media/uapi/v4l/pixfmt-compressed.rst >> index abec03937bb3..e5419f046b59 100644 >> --- a/Documentation/media/uapi/v4l/pixfmt-compressed.rst >> +++ b/Documentation/media/uapi/v4l/pixfmt-compressed.rst >> @@ -95,3 +95,10 @@ Compressed Formats >> - ``V4L2_PIX_FMT_HEVC`` >> - 'HEVC' >> - HEVC/H.265 video elementary stream. >> + * .. _V4L2-PIX-FMT-FWHT: >> + >> + - ``V4L2_PIX_FMT_FWHT`` >> + - 'FWHT' >> + - Video elementary stream using a codec based on the Fast Walsh Hadamard >> + Transform. This codec is implemented by the vicodec ('Virtual Codec') >> + driver. >> >> Since the whole codec is implemented in the vicodec source I didn't think it >> necessary to say more about it. > > Oh, well. The source is there but user space developers shouldn't need to > read it. OTOH it might be that they're also not the primary audience for > this driver either. If there's a Wikipedia article you could refer to or > such that'd be fine IMO, too. > > Up to you. > Tom, Do you have a newer version of your document? If not, can I refer to the version I have? If it can be put up at the linuxtv.org website, then that takes care of the documentation. Regards, Hans
On 21/07/18 19:51, Tom aan de Wiel wrote: > Hi! > > As of now, the version of the document I have locally is pretty much identical to the one you already linked to. > I haven't had the time to shape it into a more documentation kind of document instead of the report format it has now. > However, the report does contain all details and therefore could suffice as documentation for the time being? OK, then I'll ask Mauro to put up the document I have on linuxtv.org so I can refer to it. Thanks! Hans > > Tom > > tor. 19. jul. 2018 kl. 17:52 skrev Hans Verkuil <hverkuil@xs4all.nl <mailto:hverkuil@xs4all.nl>>: > > On 07/19/2018 05:39 PM, Sakari Ailus wrote: > > On Thu, Jul 19, 2018 at 03:20:22PM +0200, Hans Verkuil wrote: > >> On 07/19/18 15:15, sakari.ailus@iki.fi <mailto:sakari.ailus@iki.fi> wrote: > >>> On Thu, Jul 19, 2018 at 02:13:50PM +0200, Hans Verkuil wrote: > >>>> From: Hans Verkuil <hansverk@cisco.com <mailto:hansverk@cisco.com>> > >>>> > >>>> Add a new pixelformat for the vicodec software codec using the > >>>> Fast Walsh Hadamard Transform. > >>>> > >>>> Signed-off-by: Hans Verkuil <hansverk@cisco.com <mailto:hansverk@cisco.com>> > >>> > >>> Could you add documentation for this format, please? > >>> > >> > >> ??? It's part of the patch: > >> > >> diff --git a/Documentation/media/uapi/v4l/pixfmt-compressed.rst b/Documentation/media/uapi/v4l/pixfmt-compressed.rst > >> index abec03937bb3..e5419f046b59 100644 > >> --- a/Documentation/media/uapi/v4l/pixfmt-compressed.rst > >> +++ b/Documentation/media/uapi/v4l/pixfmt-compressed.rst > >> @@ -95,3 +95,10 @@ Compressed Formats > >> - ``V4L2_PIX_FMT_HEVC`` > >> - 'HEVC' > >> - HEVC/H.265 video elementary stream. > >> + * .. _V4L2-PIX-FMT-FWHT: > >> + > >> + - ``V4L2_PIX_FMT_FWHT`` > >> + - 'FWHT' > >> + - Video elementary stream using a codec based on the Fast Walsh Hadamard > >> + Transform. This codec is implemented by the vicodec ('Virtual Codec') > >> + driver. > >> > >> Since the whole codec is implemented in the vicodec source I didn't think it > >> necessary to say more about it. > > > > Oh, well. The source is there but user space developers shouldn't need to > > read it. OTOH it might be that they're also not the primary audience for > > this driver either. If there's a Wikipedia article you could refer to or > > such that'd be fine IMO, too. > > > > Up to you. > > > > Tom, > > Do you have a newer version of your document? If not, can I refer to the version > I have? If it can be put up at the linuxtv.org <http://linuxtv.org> website, then that takes care of > the documentation. > > Regards, > > Hans >
diff --git a/Documentation/media/uapi/v4l/pixfmt-compressed.rst b/Documentation/media/uapi/v4l/pixfmt-compressed.rst index abec03937bb3..e5419f046b59 100644 --- a/Documentation/media/uapi/v4l/pixfmt-compressed.rst +++ b/Documentation/media/uapi/v4l/pixfmt-compressed.rst @@ -95,3 +95,10 @@ Compressed Formats - ``V4L2_PIX_FMT_HEVC`` - 'HEVC' - HEVC/H.265 video elementary stream. + * .. _V4L2-PIX-FMT-FWHT: + + - ``V4L2_PIX_FMT_FWHT`` + - 'FWHT' + - Video elementary stream using a codec based on the Fast Walsh Hadamard + Transform. This codec is implemented by the vicodec ('Virtual Codec') + driver.