diff mbox series

[097/141] media: saa7134: Fix fall-through warnings for Clang

Message ID cc5053e144f9ff5901e9cf894c72aa933cf480f3.1605896060.git.gustavoars@kernel.org (mailing list archive)
State Accepted, archived
Delegated to: Hans Verkuil
Headers
Series Fix fall-through warnings for Clang |

Commit Message

Gustavo A. R. Silva Nov. 20, 2020, 6:37 p.m. UTC 
  In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
by explicitly adding a break statement instead of letting the code fall
through to the next case.

Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
 drivers/media/pci/saa7134/saa7134-tvaudio.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Mauro Carvalho Chehab Nov. 22, 2020, 4:32 p.m. UTC | #1 
Em Fri, 20 Nov 2020 12:37:08 -0600
"Gustavo A. R. Silva" <gustavoars@kernel.org> escreveu:

> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
> by explicitly adding a break statement instead of letting the code fall
> through to the next case.
> 
> Link: https://github.com/KSPP/linux/issues/115
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>

Reviewed-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

> ---
>  drivers/media/pci/saa7134/saa7134-tvaudio.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/pci/saa7134/saa7134-tvaudio.c b/drivers/media/pci/saa7134/saa7134-tvaudio.c
> index 5cc4ef21f9d3..5dc97990fa0e 100644
> --- a/drivers/media/pci/saa7134/saa7134-tvaudio.c
> +++ b/drivers/media/pci/saa7134/saa7134-tvaudio.c
> @@ -885,6 +885,7 @@ void saa7134_enable_i2s(struct saa7134_dev *dev)
>  	    saa_writeb(SAA7134_I2S_OUTPUT_FORMAT, i2s_format);
>  	    saa_writeb(SAA7134_I2S_OUTPUT_LEVEL,  0x0F);
>  	    saa_writeb(SAA7134_I2S_AUDIO_OUTPUT,  0x01);
> +	    break;
>  
>  	default:
>  	    break;



Thanks,
Mauro
diff mbox series

Patch

diff --git a/drivers/media/pci/saa7134/saa7134-tvaudio.c b/drivers/media/pci/saa7134/saa7134-tvaudio.c
index 5cc4ef21f9d3..5dc97990fa0e 100644
--- a/drivers/media/pci/saa7134/saa7134-tvaudio.c
+++ b/drivers/media/pci/saa7134/saa7134-tvaudio.c
@@ -885,6 +885,7 @@  void saa7134_enable_i2s(struct saa7134_dev *dev)
 	    saa_writeb(SAA7134_I2S_OUTPUT_FORMAT, i2s_format);
 	    saa_writeb(SAA7134_I2S_OUTPUT_LEVEL,  0x0F);
 	    saa_writeb(SAA7134_I2S_AUDIO_OUTPUT,  0x01);
+	    break;
 
 	default:
 	    break;