Message ID | c2e46020-aaa6-4e06-bf73-f05823f913f0@I-love.SAKURA.ne.jp (mailing list archive) |
---|---|
State | New |
Headers |
Received: from sv.mirrors.kernel.org ([139.178.88.99]) by linuxtv.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from <linux-media+bounces-10789-patchwork=linuxtv.org@vger.kernel.org>) id 1s3cYL-0003f4-0m for patchwork@linuxtv.org; Sun, 05 May 2024 14:09:23 +0000 Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 97E20281A9A for <patchwork@linuxtv.org>; Sun, 5 May 2024 14:09:20 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1CA7A1D556; Sun, 5 May 2024 14:09:16 +0000 (UTC) X-Original-To: linux-media@vger.kernel.org Received: from www262.sakura.ne.jp (www262.sakura.ne.jp [202.181.97.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38DC7B65F for <linux-media@vger.kernel.org>; Sun, 5 May 2024 14:09:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.181.97.72 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714918155; cv=none; b=XYKR0jd+dL0lZsSdC5ZHP5Pf3MOn+p6JII7zfD4Izy1wu7VR1zNZy6x8n4UImwkDjL3dkmnGhlknsE8+C9L2/OMBUUOCEF5bWSxHV19HG/CF497Z974db3w1pzWoGb2ZM313ReseLQjmpNcQczZLej4hShd3RyYBsyQV/Dd663g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714918155; c=relaxed/simple; bh=48dyCltHZm9KjXWlneKhANnNx0XM1xDXBAlePa1xNao=; h=Message-ID:Date:MIME-Version:Subject:To:References:Cc:From: In-Reply-To:Content-Type; b=PqncxsD4unjSd3XE21h9VxBD1iDSlJG5pE50nzazFK7obVRSrdzSoefA2ztmMl8EaL6ERE+QB7ygNoQfLl7dueuotBOUYRoeI651qPKi5jrIZd6RTbgPEplDTamnuSJ8ql8EjqipVSuICsBM7SqNU27aYA3hK1HbteLTV3I7iRE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=I-love.SAKURA.ne.jp; spf=pass smtp.mailfrom=I-love.SAKURA.ne.jp; arc=none smtp.client-ip=202.181.97.72 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=I-love.SAKURA.ne.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=I-love.SAKURA.ne.jp Received: from fsav111.sakura.ne.jp (fsav111.sakura.ne.jp [27.133.134.238]) by www262.sakura.ne.jp (8.15.2/8.15.2) with ESMTP id 445E8WqX064578; Sun, 5 May 2024 23:08:32 +0900 (JST) (envelope-from penguin-kernel@I-love.SAKURA.ne.jp) Received: from www262.sakura.ne.jp (202.181.97.72) by fsav111.sakura.ne.jp (F-Secure/fsigk_smtp/550/fsav111.sakura.ne.jp); Sun, 05 May 2024 23:08:32 +0900 (JST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/fsav111.sakura.ne.jp) Received: from [192.168.1.6] (M106072142033.v4.enabler.ne.jp [106.72.142.33]) (authenticated bits=0) by www262.sakura.ne.jp (8.15.2/8.15.2) with ESMTPSA id 445E8WnO064575 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NO); Sun, 5 May 2024 23:08:32 +0900 (JST) (envelope-from penguin-kernel@I-love.SAKURA.ne.jp) Message-ID: <c2e46020-aaa6-4e06-bf73-f05823f913f0@I-love.SAKURA.ne.jp> Date: Sun, 5 May 2024 23:08:31 +0900 Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: <linux-media.vger.kernel.org> List-Subscribe: <mailto:linux-media+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-media+unsubscribe@vger.kernel.org> MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH] dma-buf/sw-sync: don't enable IRQ from sync_print_obj() To: syzbot <syzbot+a225ee3df7e7f9372dbe@syzkaller.appspotmail.com>, syzkaller-bugs@googlegroups.com, Sumit Semwal <sumit.semwal@linaro.org>, Gustavo Padovan <gustavo@padovan.org>, Christian Konig <christian.koenig@amd.com>, Sean Paul <seanpaul@chromium.org>, Chris Wilson <chris@chris-wilson.co.uk> References: <0000000000000946190610bf7bd5@google.com> Content-Language: en-US Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org, dri-devel@lists.freedesktop.org From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> In-Reply-To: <0000000000000946190610bf7bd5@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-LSpam-Score: -4.8 (----) X-LSpam-Report: No, score=-4.8 required=5.0 tests=ARC_SIGNED=0.001,ARC_VALID=-0.1,BAYES_00=-1.9,DMARC_MISSING=0.001,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1,RCVD_IN_DNSWL_MED=-2.3,SPF_HELO_NONE=0.001,SPF_PASS=-0.001 autolearn=ham autolearn_force=no |
Series |
dma-buf/sw-sync: don't enable IRQ from sync_print_obj()
|
|
Commit Message
Tetsuo Handa
May 5, 2024, 2:08 p.m. UTC
Since commit a6aa8fca4d79 ("dma-buf/sw-sync: Reduce irqsave/irqrestore from
known context") by error replaced spin_unlock_irqrestore() with
spin_unlock_irq() for both sync_debugfs_show() and sync_print_obj() despite
sync_print_obj() is called from sync_debugfs_show(), lockdep complains
inconsistent lock state warning.
Use plain spin_{lock,unlock}() for sync_print_obj(), for
sync_debugfs_show() is already using spin_{lock,unlock}_irq().
Reported-by: syzbot <syzbot+a225ee3df7e7f9372dbe@syzkaller.appspotmail.com>
Closes: https://syzkaller.appspot.com/bug?extid=a225ee3df7e7f9372dbe
Fixes: a6aa8fca4d79 ("dma-buf/sw-sync: Reduce irqsave/irqrestore from known context")
Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
---
drivers/dma-buf/sync_debug.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Comments
Am 05.05.24 um 16:08 schrieb Tetsuo Handa: > Since commit a6aa8fca4d79 ("dma-buf/sw-sync: Reduce irqsave/irqrestore from > known context") by error replaced spin_unlock_irqrestore() with > spin_unlock_irq() for both sync_debugfs_show() and sync_print_obj() despite > sync_print_obj() is called from sync_debugfs_show(), lockdep complains > inconsistent lock state warning. > > Use plain spin_{lock,unlock}() for sync_print_obj(), for > sync_debugfs_show() is already using spin_{lock,unlock}_irq(). > > Reported-by: syzbot <syzbot+a225ee3df7e7f9372dbe@syzkaller.appspotmail.com> > Closes: https://syzkaller.appspot.com/bug?extid=a225ee3df7e7f9372dbe > Fixes: a6aa8fca4d79 ("dma-buf/sw-sync: Reduce irqsave/irqrestore from known context") > Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Reviewed-by: Christian König <christian.koenig@amd.com> > --- > drivers/dma-buf/sync_debug.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/dma-buf/sync_debug.c b/drivers/dma-buf/sync_debug.c > index 101394f16930..237bce21d1e7 100644 > --- a/drivers/dma-buf/sync_debug.c > +++ b/drivers/dma-buf/sync_debug.c > @@ -110,12 +110,12 @@ static void sync_print_obj(struct seq_file *s, struct sync_timeline *obj) > > seq_printf(s, "%s: %d\n", obj->name, obj->value); > > - spin_lock_irq(&obj->lock); > + spin_lock(&obj->lock); /* Caller already disabled IRQ. */ > list_for_each(pos, &obj->pt_list) { > struct sync_pt *pt = container_of(pos, struct sync_pt, link); > sync_print_fence(s, &pt->base, false); > } > - spin_unlock_irq(&obj->lock); > + spin_unlock(&obj->lock); > } > > static void sync_print_sync_file(struct seq_file *s,
diff --git a/drivers/dma-buf/sync_debug.c b/drivers/dma-buf/sync_debug.c index 101394f16930..237bce21d1e7 100644 --- a/drivers/dma-buf/sync_debug.c +++ b/drivers/dma-buf/sync_debug.c @@ -110,12 +110,12 @@ static void sync_print_obj(struct seq_file *s, struct sync_timeline *obj) seq_printf(s, "%s: %d\n", obj->name, obj->value); - spin_lock_irq(&obj->lock); + spin_lock(&obj->lock); /* Caller already disabled IRQ. */ list_for_each(pos, &obj->pt_list) { struct sync_pt *pt = container_of(pos, struct sync_pt, link); sync_print_fence(s, &pt->base, false); } - spin_unlock_irq(&obj->lock); + spin_unlock(&obj->lock); } static void sync_print_sync_file(struct seq_file *s,