Message ID | ad3e13dcf101ff613c7fc72c99db8dd2@208suo.com (mailing list archive) |
---|---|
State | Changes Requested |
Delegated to: | Hans Verkuil |
Headers |
Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from <linux-media-owner@vger.kernel.org>) id 1qKDs5-00G37M-FY; Fri, 14 Jul 2023 08:09:50 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235406AbjGNIJp (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Fri, 14 Jul 2023 04:09:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59770 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234611AbjGNIJF (ORCPT <rfc822;linux-media@vger.kernel.org>); Fri, 14 Jul 2023 04:09:05 -0400 Received: from mail.208.org (unknown [183.242.55.162]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EDB9D3C39 for <linux-media@vger.kernel.org>; Fri, 14 Jul 2023 01:06:47 -0700 (PDT) Received: from mail.208.org (email.208.org [127.0.0.1]) by mail.208.org (Postfix) with ESMTP id 4R2PFc5MrdzBR9sj for <linux-media@vger.kernel.org>; Fri, 14 Jul 2023 16:06:44 +0800 (CST) Authentication-Results: mail.208.org (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=208.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=208.org; h= content-transfer-encoding:content-type:message-id:user-agent :references:in-reply-to:subject:to:from:date:mime-version; s= dkim; t=1689322004; x=1691914005; bh=XnHXJPirhwWBp38ABP/TuJuTwR8 3qRslG4kr4zY2jQE=; b=prRBxH8oaDBDTnR82sVlKMzhnplxgraSpUiFkTrSEAi PL/0jsa+/sZJSgNgjvqdrFQxajScW/0VMmk1IkERiOJnCxIrMehW37VmPbLwXLTz 4/Gg6Epqe4zEUM8ajdjI6Emvj6lYvp3VJs3ihqxvcok75YhIfp5jDc/08LR4ZkJY DJR48ZTH6xczM1qTomDWaAvfVGKk2V529dYKCtUB80aGWWZ/CX6qltAQ3ViLWxqD lnf1NQjE0i2Pt5XDCz6HEsa2yzHyW+YTtD0wixN1haz5NiBN1wLqxmY+PHSop7WZ EGAY3AuUQCUrdLd8ZPKP/0alZxTnW14UuYWckTM1FFw== X-Virus-Scanned: amavisd-new at mail.208.org Received: from mail.208.org ([127.0.0.1]) by mail.208.org (mail.208.org [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id RQDUuf8Qp81B for <linux-media@vger.kernel.org>; Fri, 14 Jul 2023 16:06:44 +0800 (CST) Received: from localhost (email.208.org [127.0.0.1]) by mail.208.org (Postfix) with ESMTPSA id 4R2PFc412lzBR9sc; Fri, 14 Jul 2023 16:06:44 +0800 (CST) MIME-Version: 1.0 Date: Fri, 14 Jul 2023 16:06:44 +0800 From: sunran001@208suo.com To: mchehab@kernel.org Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] media: dvb: remove spaces before '[' In-Reply-To: <20230714080514.14297-1-xujianghui@cdjrlc.com> References: <20230714080514.14297-1-xujianghui@cdjrlc.com> User-Agent: Roundcube Webmail Message-ID: <ad3e13dcf101ff613c7fc72c99db8dd2@208suo.com> X-Sender: sunran001@208suo.com Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,RDNS_NONE,SPF_HELO_FAIL,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -4.6 (----) X-LSpam-Report: No, score=-4.6 required=5.0 tests=BAYES_00=-1.9,DKIM_SIGNED=0.1,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1,RCVD_IN_DNSWL_MED=-2.3,T_DKIM_INVALID=0.01 autolearn=ham autolearn_force=no |
Series |
media: dvb: remove spaces before '['
|
|
Commit Message
sunran001@208suo.com
July 14, 2023, 8:06 a.m. UTC
Remove spaces to clear checkpatch errors.
ERROR: space prohibited before open square bracket '['
Signed-off-by: Ran Sun <sunran001@208suo.com>
---
drivers/media/dvb-frontends/tda826x.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
dprintk("%s:\n", __func__);
@@ -65,7 +65,7 @@ static int tda826x_set_params(struct dvb_frontend *fe)
u32 div;
u32 ksyms;
u32 bandwidth;
- u8 buf [11];
+ u8 buf[11];
struct i2c_msg msg = { .addr = priv->i2c_address, .flags = 0, .buf
= buf, .len = 11 };
dprintk("%s:\n", __func__);
@@ -130,7 +130,7 @@ static const struct dvb_tuner_ops tda826x_tuner_ops
= {
struct dvb_frontend *tda826x_attach(struct dvb_frontend *fe, int addr,
struct i2c_adapter *i2c, int has_loopthrough)
{
struct tda826x_priv *priv = NULL;
- u8 b1 [] = { 0, 0 };
+ u8 b1[] = { 0, 0 };
struct i2c_msg msg[2] = {
{ .addr = addr, .flags = 0, .buf = NULL, .len = 0 },
{ .addr = addr, .flags = I2C_M_RD, .buf = b1, .len = 2 }
Comments
Hi Ran Sun, On 14/07/2023 10:06, sunran001@208suo.com wrote: > Remove spaces to clear checkpatch errors. > > ERROR: space prohibited before open square bracket '[' > > Signed-off-by: Ran Sun <sunran001@208suo.com> > --- > drivers/media/dvb-frontends/tda826x.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/media/dvb-frontends/tda826x.c b/drivers/media/dvb-frontends/tda826x.c > index f9703a1dd758..7f17efe17d11 100644 > --- a/drivers/media/dvb-frontends/tda826x.c > +++ b/drivers/media/dvb-frontends/tda826x.c > @@ -38,7 +38,7 @@ static int tda826x_sleep(struct dvb_frontend *fe) > { > struct tda826x_priv *priv = fe->tuner_priv; > int ret; > - u8 buf [] = { 0x00, 0x8d }; > + u8 buf[] = { 0x00, 0x8d }; This patch is corrupt: TABs have been replaced by spaces. It's not just this patch, but all 7 patches you posted to linux-media. Also, please mention the name of the driver you fixed in the subject. So: "media: dvb: tda826x: remove space before '['". Regards, Hans > struct i2c_msg msg = { .addr = priv->i2c_address, .flags = 0, .buf = buf, .len = 2 }; > > dprintk("%s:\n", __func__); > @@ -65,7 +65,7 @@ static int tda826x_set_params(struct dvb_frontend *fe) > u32 div; > u32 ksyms; > u32 bandwidth; > - u8 buf [11]; > + u8 buf[11]; > struct i2c_msg msg = { .addr = priv->i2c_address, .flags = 0, .buf = buf, .len = 11 }; > > dprintk("%s:\n", __func__); > @@ -130,7 +130,7 @@ static const struct dvb_tuner_ops tda826x_tuner_ops = { > struct dvb_frontend *tda826x_attach(struct dvb_frontend *fe, int addr, struct i2c_adapter *i2c, int has_loopthrough) > { > struct tda826x_priv *priv = NULL; > - u8 b1 [] = { 0, 0 }; > + u8 b1[] = { 0, 0 }; > struct i2c_msg msg[2] = { > { .addr = addr, .flags = 0, .buf = NULL, .len = 0 }, > { .addr = addr, .flags = I2C_M_RD, .buf = b1, .len = 2 }
diff --git a/drivers/media/dvb-frontends/tda826x.c b/drivers/media/dvb-frontends/tda826x.c index f9703a1dd758..7f17efe17d11 100644 --- a/drivers/media/dvb-frontends/tda826x.c +++ b/drivers/media/dvb-frontends/tda826x.c @@ -38,7 +38,7 @@ static int tda826x_sleep(struct dvb_frontend *fe) { struct tda826x_priv *priv = fe->tuner_priv; int ret; - u8 buf [] = { 0x00, 0x8d }; + u8 buf[] = { 0x00, 0x8d }; struct i2c_msg msg = { .addr = priv->i2c_address, .flags = 0, .buf = buf, .len = 2 };