diff mbox

[1/2] dvb: mantis: use '%pM' format to print MAC address

Message ID a548f44961f97f81054fc877aaef068f936c5ca2.1284213506.git.andy.shevchenko@gmail.com (mailing list archive)
State Superseded, archived
Headers

Commit Message

Andy Shevchenko Sept. 11, 2010, 1:59 p.m. UTC 
  Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>
---
 drivers/media/dvb/mantis/mantis_core.c |    5 +----
 drivers/media/dvb/mantis/mantis_ioc.c  |    9 +--------
 2 files changed, 2 insertions(+), 12 deletions(-)

Comments

Joe Perches Sept. 11, 2010, 4:47 p.m. UTC | #1 
On Sat, 2010-09-11 at 16:59 +0300, Andy Shevchenko wrote:
>  drivers/media/dvb/mantis/mantis_core.c |    5 +----
>  drivers/media/dvb/mantis/mantis_ioc.c  |    9 +--------

Hi Andy.

I think these are clearer and more commonly used as:

>  	dprintk(verbose, MANTIS_ERROR, 0,
> +		"    MAC Address=[%pM]\n", &mantis->mac_address[0]);

		"    MAC Address=[%pM]\n", mantis->mac_address);

and

> +	dprintk(MANTIS_ERROR, 0, "    MAC Address=[%pM]\n", &mac_addr[0]);

	dprintk(MANTIS_ERROR, 0, "    MAC Address=[%pM]\n", mac_addr);


--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/media/dvb/mantis/mantis_core.c b/drivers/media/dvb/mantis/mantis_core.c
index 8113b23..0163e8e 100644
--- a/drivers/media/dvb/mantis/mantis_core.c
+++ b/drivers/media/dvb/mantis/mantis_core.c
@@ -91,10 +91,7 @@  static int get_mac_address(struct mantis_pci *mantis)
 		return err;
 	}
 	dprintk(verbose, MANTIS_ERROR, 0,
-		"    MAC Address=[%02x:%02x:%02x:%02x:%02x:%02x]\n",
-		mantis->mac_address[0], mantis->mac_address[1],
-		mantis->mac_address[2],	mantis->mac_address[3],
-		mantis->mac_address[4], mantis->mac_address[5]);
+		"    MAC Address=[%pM]\n", &mantis->mac_address[0]);
 
 	return 0;
 }
diff --git a/drivers/media/dvb/mantis/mantis_ioc.c b/drivers/media/dvb/mantis/mantis_ioc.c
index de148de..8932f34 100644
--- a/drivers/media/dvb/mantis/mantis_ioc.c
+++ b/drivers/media/dvb/mantis/mantis_ioc.c
@@ -68,14 +68,7 @@  int mantis_get_mac(struct mantis_pci *mantis)
 		return err;
 	}
 
-	dprintk(MANTIS_ERROR, 0,
-		"    MAC Address=[%02x:%02x:%02x:%02x:%02x:%02x]\n",
-		mac_addr[0],
-		mac_addr[1],
-		mac_addr[2],
-		mac_addr[3],
-		mac_addr[4],
-		mac_addr[5]);
+	dprintk(MANTIS_ERROR, 0, "    MAC Address=[%pM]\n", &mac_addr[0]);
 
 	return 0;
 }