Message ID | ZJAdH+Ftqyd79QF4@valkosipuli.retiisi.eu (mailing list archive) |
---|---|
State | Accepted |
Headers |
Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from <linux-media-owner@vger.kernel.org>) id 1qBB0q-004gxB-77; Mon, 19 Jun 2023 09:17:28 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230212AbjFSJRZ (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Mon, 19 Jun 2023 05:17:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229732AbjFSJRY (ORCPT <rfc822;linux-media@vger.kernel.org>); Mon, 19 Jun 2023 05:17:24 -0400 Received: from lahtoruutu.iki.fi (lahtoruutu.iki.fi [IPv6:2a0b:5c81:1c1::37]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2699883 for <linux-media@vger.kernel.org>; Mon, 19 Jun 2023 02:17:23 -0700 (PDT) Received: from hillosipuli.retiisi.eu (82-181-192-243.bb.dnainternet.fi [82.181.192.243]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: sailus) by lahtoruutu.iki.fi (Postfix) with ESMTPSA id 4Ql40b6hnYz49Py9 for <linux-media@vger.kernel.org>; Mon, 19 Jun 2023 12:17:19 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1687166240; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=eaYiKhUSRI5sE17BBIa+FrC4lnUTPZCsig1TKfurh7M=; b=BV/T1NsnWfhubIrXhPd9pCjn7G3EerQN3gii/2FZMT2yAUtodOkBMZTAn535ZITGD/eDLw 9dOzOgjKIowBq7Wt22F2ABuH3XIhib6HzvyUhxk7Tk/tkA48lAXcWpD880VIDXwHIXEAa+ PvDXZb/MKqjJXLK7uG1Co+17vvct9R87m34u2zep/HBk89NXP8Ou5G0iLIU8V34+lJMirc ErYrJnrQiEkcY9T3vDXz0FjeNB/FPhrCL6nB6L1WVKxFytnYKmTyXMRVShLEXulp5XAgMv L41siqXvRX4DGrTTDmeruLPEIAo52zIImwv4F9C+8DPAeODRwpgGrxAEwAYEUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1687166240; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=eaYiKhUSRI5sE17BBIa+FrC4lnUTPZCsig1TKfurh7M=; b=P7a98wfuAO7ZzqNkru6Yg0Ek+dRd+LDjBO015vHgE2v5gA0a6cRgvGS6DmI/4J/wWaXq26 faWTeRrO/JcHwU93yD4toscJXzKXms0tkz7uwajEdGGFmEJabZJS5rpjTeILeHdyJ4TNsP +aDngQmTz9jJ5gce4R8gklTsGLW00VZO1JnwxVNg8K3dnf7p9CdUQbN7QUr6VQmqGsVa2+ GqJwJmqbJmnen9MLODRAqJIIWBt0hEoOCSGxrxQyhTHzI4B1I/LClgbSSt9v3c6oGmdoJg WQKYQ0LxXyhxCURdEELPoq2EsrTGPgi/4q/FzInLFftxBerV31iNeMoFOa2Lbw== ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=sailus smtp.mailfrom=sakari.ailus@iki.fi ARC-Seal: i=1; s=lahtoruutu; d=iki.fi; t=1687166240; a=rsa-sha256; cv=none; b=PKuK1Q5vPcRj5itDRTX3fpZUUkpam4+IeSR3EO11ICsGJibDWzxZ2G1t0FEHiIgQNNIhCC TlkU+qKVxAPbwIlb9ZZTIPBWWxWVyy1+LFaKWydUhxT+4zqxgrhHTnxAsj7ZRDH4qRh1tb s25Y20jPAHgLVAj1G6ztiAtYVSOkpZ0vssK8dzU1WRRS6YCZBapQ2KejcLqhgd8iHrKzzX FJQEVJWGjhb6rpeLgfwJdRhCY0o8GOKZuFqTcIzgjPTrMm4nBelaDl72iVFDYUVf5WTJhM RQnWmBo280Lb2ELFjq/47zPLtGqjJOVxbsWBWPuVUzQdPIhxiLiENhNSuK1tDA== Received: from valkosipuli.retiisi.eu (valkosipuli.localdomain [192.168.4.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by hillosipuli.retiisi.eu (Postfix) with ESMTPS id 53C53634C94 for <linux-media@vger.kernel.org>; Mon, 19 Jun 2023 12:17:19 +0300 (EEST) Date: Mon, 19 Jun 2023 12:17:19 +0300 From: Sakari Ailus <sakari.ailus@iki.fi> To: linux-media@vger.kernel.org Subject: [GIT FIXES FOR 6.4] Fix compile warnings and errors for tc358756 and atomisp Message-ID: <ZJAdH+Ftqyd79QF4@valkosipuli.retiisi.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -4.8 (----) X-LSpam-Report: No, score=-4.8 required=5.0 tests=BAYES_00=-1.9,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1,RCVD_IN_DNSWL_MED=-2.3 autolearn=ham autolearn_force=no |
Series |
[GIT,FIXES,FOR,6.4] Fix compile warnings and errors for tc358756 and atomisp
|
|
Pull-request
git://linuxtv.org/sailus/media_tree.git tags/fixes-6.4-3-signedMessage
Sakari Ailus
June 19, 2023, 9:17 a.m. UTC
Hi Mauro, These two patches address compile warnings and dependency-related build failures for tc358746 and atomisp drivers. Please pull. The following changes since commit ac9a78681b921877518763ba0e89202254349d1b: Linux 6.4-rc1 (2023-05-07 13:34:35 -0700) are available in the Git repository at: git://linuxtv.org/sailus/media_tree.git tags/fixes-6.4-3-signed for you to fetch changes up to afbb61fca19be4eaf2cfacece749f2815686dde0: media: staging: atomisp: select V4L2_FWNODE (2023-06-19 12:11:55 +0300) ---------------------------------------------------------------- V4L2 fixes for 6.4 ---------------------------------------------------------------- Sakari Ailus (2): media: tc358746: Address compiler warnings media: staging: atomisp: select V4L2_FWNODE drivers/media/i2c/tc358746.c | 4 ++-- drivers/staging/media/atomisp/Kconfig | 1 + 2 files changed, 3 insertions(+), 2 deletions(-)
Comments
From: builder@linuxtv.org
Pull request: https://patchwork.linuxtv.org/project/linux-media/patch/ZJAdH+Ftqyd79QF4@valkosipuli.retiisi.eu/
Build log: https://builder.linuxtv.org/job/patchwork/315937/
Build time: 00:19:04
Link: https://lore.kernel.org/linux-media/ZJAdH+Ftqyd79QF4@valkosipuli.retiisi.eu
gpg: Signature made Mon 19 Jun 2023 09:13:17 AM UTC
gpg: using DSA key 53AC58A5F5948636C04A1BF8141DFA54A1EC8DEA
gpg: issuer "sakari.ailus@linux.intel.com"
gpg: Good signature from "Sakari Ailus <sakari.ailus@linux.intel.com>" [full]
Summary: got 2/2 patches with issues, being 1 at build time, plus one error when buinding PDF document
Error/warnings:
patches/0001-media-tc358746-Address-compiler-warnings.patch:
allyesconfig: return code #0:
../scripts/genksyms/parse.y: warning: 9 shift/reduce conflicts [-Wconflicts-sr]
../scripts/genksyms/parse.y: warning: 5 reduce/reduce conflicts [-Wconflicts-rr]
../scripts/genksyms/parse.y: note: rerun with option '-Wcounterexamples' to generate conflict counterexamples
SPARSE:../drivers/staging/media/tegra-video/vip.c ../drivers/staging/media/tegra-video/vip.c:280:24: warning: symbol 'tegra_vip_driver' was not declared. Should it be static?
../drivers/staging/media/atomisp/i2c/atomisp-ov2680.c: ../drivers/staging/media/atomisp/i2c/atomisp-ov2680.c:476 ov2680_init_cfg() error: we previously assumed 'sd_state' could be null (see line 468)
../drivers/staging/media/atomisp/i2c/atomisp-ov2680.c:524 ov2680_s_stream() warn: missing error code 'ret'
../drivers/staging/media/atomisp/i2c/atomisp-gc0310.c:447 gc0310_s_stream() warn: missing error code 'ret'
../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:2801 atomisp_cp_dvs_6axis_config() warn: missing unwind goto?
../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:2900 atomisp_cp_morph_table() warn: missing unwind goto?
../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:4283 atomisp_set_fmt_to_snr() warn: variable dereferenced before check 'asd' (see line 4268)
../drivers/staging/media/atomisp/pci/atomisp_fops.c: ../drivers/staging/media/atomisp/pci/atomisp_fops.c:517 atomisp_open() warn: missing unwind goto?
allyesconfig: return code #0:
../drivers/media/i2c/adp1653.c: ../drivers/media/i2c/adp1653.c:444 adp1653_of_init() warn: missing unwind goto?
../drivers/media/platform/mediatek/vcodec/vdec_msg_queue.c: ../drivers/media/platform/mediatek/vcodec/vdec_msg_queue.c:347 vdec_msg_queue_init() warn: missing unwind goto?
../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2570 dvb_register() parse error: OOM: 3000016Kb sm_state_count = 1963126
../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2570 dvb_register() warn: Function too hairy. No more merges.
../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2570 dvb_register() parse error: __split_smt: function too hairy. Giving up after 52 seconds
../drivers/media/pci/ivtv/ivtvfb.c: note: in included file (through ../arch/x86/include/asm/uaccess.h, ../include/linux/uaccess.h, ../include/linux/sched/task.h, ../include/linux/sched/signal.h, ../drivers/media/pci/ivtv/ivtv-driver.h):
SPARSE:../drivers/media/pci/ivtv/ivtvfb.c ../arch/x86/include/asm/uaccess_64.h:88:24: warning: cast removes address space '__user' of expression
../drivers/media/i2c/ov5645.c: ../drivers/media/i2c/ov5645.c:687 ov5645_set_power_on() warn: 'ov5645->xclk' from clk_prepare_enable() not released on lines: 687.
../drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c: ../drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c:2775 mxc_jpeg_probe() warn: missing unwind goto?
SMATCH:../drivers/media/usb/siano/smsusb.c ../drivers/media/usb/siano/smsusb.c:53:38: :warning: array of flexible structures
../drivers/media/usb/uvc/uvc_v4l2.c: note: in included file (through ../arch/x86/include/asm/uaccess.h, ../include/linux/uaccess.h, ../include/linux/sched/task.h, ../include/linux/sched/signal.h, ../include/linux/rcuwait.h, ...):
SPARSE:../drivers/media/usb/uvc/uvc_v4l2.c ../arch/x86/include/asm/uaccess_64.h:88:24: warning: cast removes address space '__user' of expression
../drivers/media/usb/em28xx/em28xx-video.c: ../drivers/media/usb/em28xx/em28xx-video.c:2884 em28xx_v4l2_init() parse error: turning off implications after 60 seconds
../drivers/media/usb/pvrusb2/pvrusb2-hdw.c: ../drivers/media/usb/pvrusb2/pvrusb2-hdw.c:3293 pvr2_hdw_get_tuner_status() warn: inconsistent indenting
checkpatch.pl:
$ cat patches/0001-media-tc358746-Address-compiler-warnings.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict
-:10: WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
-:24: WARNING: Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("<title line>")' - ie: 'Fixes: 80a21da36051 ("media: tc358746: add Toshiba TC358746 Parallel to CSI-2 bridge driver")'
patches/0002-media-staging-atomisp-select-V4L2_FWNODE.patch:
checkpatch.pl:
$ cat patches/0002-media-staging-atomisp-select-V4L2_FWNODE.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict
-:8: WARNING: Reported-by: should be immediately followed by Closes: with a URL to the report
Error #512 when building PDF docs