| Message ID | YtF9MkyD11fMnpYp@pendragon.ideasonboard.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers |
Received: from vger.kernel.org ([23.128.96.18])
by www.linuxtv.org with esmtp (Exim 4.92)
(envelope-from <linux-media-owner@vger.kernel.org>)
id 1oCMYc-00C525-0v; Fri, 15 Jul 2022 14:44:42 +0000
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S230301AbiGOOoj (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other);
Fri, 15 Jul 2022 10:44:39 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34698 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S229510AbiGOOoi (ORCPT
<rfc822;linux-media@vger.kernel.org>);
Fri, 15 Jul 2022 10:44:38 -0400
Received: from perceval.ideasonboard.com (perceval.ideasonboard.com
[213.167.242.64])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D52C421E28
for <linux-media@vger.kernel.org>;
Fri, 15 Jul 2022 07:44:35 -0700 (PDT)
Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi
[62.78.145.57])
by perceval.ideasonboard.com (Postfix) with ESMTPSA id D9C25993;
Fri, 15 Jul 2022 16:44:33 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;
s=mail; t=1657896274;
bh=KKsRJWOui/B9ctlc8kETpuiGrhxdWxuYS0CooEZdSkc=;
h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
b=u+dTSQZYG425uhPAtZAdHpSqPlLZgH/cJYJXVEpxfNqC0/ouRldXYq+h5LWN13+Ya
4ieL/O2UsKrvLO8QlVItJJ1HQff78NCk9/QBtq51rixynwPFEWOvKysrRZnDbgAK+6
oKELXHvHB0K4ZpsLIRyj5umUuo/M0wVn95TvlyBw=
Date: Fri, 15 Jul 2022 17:44:02 +0300
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-media@vger.kernel.org
Cc: Dafna Hirschfeld <dafna@fastmail.com>,
Paul Elder <paul.elder@ideasonboard.com>
Subject: [GIT PULL FOR v5.20 - v2] rkisp1 refactoring to prepare for i.MX8MP
support
Message-ID: <YtF9MkyD11fMnpYp@pendragon.ideasonboard.com>
References: <Ys30elcTTEnlu7c7@pendragon.ideasonboard.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <Ys30elcTTEnlu7c7@pendragon.ideasonboard.com>
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS
autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-media.vger.kernel.org>
X-Mailing-List: linux-media@vger.kernel.org
X-LSpam-Score: -2.5 (--)
X-LSpam-Report: No,
score=-2.5 required=5.0 tests=BAYES_00=-1.9,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1
autolearn=ham autolearn_force=no
|
| Series |
[GIT,PULL,FOR,v5.20,-,v2] rkisp1 refactoring to prepare for i.MX8MP support
|
|
Pull-request
git://linuxtv.org/pinchartl/media.git tags/v4l2-next-20220715Message
Laurent Pinchart
July 15, 2022, 2:44 p.m. UTC
Hi Mauro,
This v2 addresses a compilation issue in commit "media: mc-entity:
Rename media_entity_remote_pad() to media_pad_remote_pad_first()" that
was caused by another pull request not present in my base branch. It is
now rebased on top of the stage/master branch, with an update of the
offending patch sent to the mailing list.
The following changes since commit 109670df7dfed3fa0cb33e0868a889f4f512b698:
media: ov5693: add ov5693_of_match, dts support (2022-07-15 15:33:08 +0100)
are available in the Git repository at:
git://linuxtv.org/pinchartl/media.git tags/v4l2-next-20220715
for you to fetch changes up to 6d295cbc759d68143699f1c2abdd0e7433b987c1:
media: rkisp1: debug: Add dump file in debugfs for MI main path registers (2022-07-15 17:36:10 +0300)
----------------------------------------------------------------
rkisp1 refactoring to prepare for i.MX8MP support
----------------------------------------------------------------
Laurent Pinchart (38):
media: v4l2-async: Add notifier operation to destroy asd instances
media: mc-entity: Rename media_entity_remote_pad() to media_pad_remote_pad_first()
media: mc-entity: Add a new helper function to get a remote pad
media: mc-entity: Add a new helper function to get a remote pad for a pad
media: rkisp1: Enable compilation on ARCH_MXC
media: rkisp1: Disable runtime PM in probe error path
media: rkisp1: Read the ID register at probe time instead of streamon
media: rkisp1: Rename rkisp1_match_data to rkisp1_info
media: rkisp1: Access ISP version from info pointer
media: rkisp1: cap: Print debug message on failed link validation
media: rkisp1: Move sensor .s_stream() call to ISP
media: rkisp1: Reject sensors without pixel rate control at bound time
media: rkisp1: Create link from sensor to ISP at notifier bound time
media: rkisp1: Create internal links at probe time
media: rkisp1: Rename rkisp1_subdev_notifier() to rkisp1_subdev_notifier_register()
media: rkisp1: Fix sensor source pad retrieval at bound time
media: rkisp1: isp: Start CSI-2 receiver before ISP
media: rkisp1: csi: Handle CSI-2 RX configuration fully in rkisp1-csi.c
media: rkisp1: csi: Rename CSI functions with a common rkisp1_csi prefix
media: rkisp1: csi: Move start delay to rkisp1_csi_start()
media: rkisp1: csi: Pass sensor pointer to rkisp1_csi_config()
media: rkisp1: csi: Constify argument to rkisp1_csi_start()
media: rkisp1: isp: Don't initialize ret to 0 in rkisp1_isp_s_stream()
media: rkisp1: isp: Pass mbus type and flags to rkisp1_config_cif()
media: rkisp1: isp: Rename rkisp1_device.active_sensor to source
media: rkisp1: isp: Add container_of wrapper to cast subdev to rkisp1_isp
media: rkisp1: isp: Add rkisp1_device backpointer to rkisp1_isp
media: rkisp1: isp: Pass rkisp1_isp pointer to internal ISP functions
media: rkisp1: isp: Move input configuration to rkisp1_config_isp()
media: rkisp1: isp: Merge ISP_ACQ_PROP configuration in single variable
media: rkisp1: isp: Initialize some variables at declaration time
media: rkisp1: isp: Fix whitespace issues
media: rkisp1: isp: Constify various local variables
media: rkisp1: isp: Rename rkisp1_get_remote_source()
media: rkisp1: isp: Disallow multiple active sources
media: rkisp1: csi: Plumb the CSI RX subdev
media: rkisp1: Add infrastructure to support ISP features
media: rkisp1: Make the internal CSI-2 receiver optional
Paul Elder (8):
media: rkisp1: Save info pointer in rkisp1_device
media: rkisp1: Make rkisp1_isp_mbus_info common
media: rkisp1: Split CSI handling to separate file
media: rkisp1: csi: Implement a V4L2 subdev for the CSI receiver
media: rkisp1: Use fwnode_graph_for_each_endpoint
dt-bindings: media: rkisp1: Add port for parallel interface
media: rkisp1: Support the ISP parallel input
media: rkisp1: debug: Add dump file in debugfs for MI main path registers
.../devicetree/bindings/media/rockchip-isp1.yaml | 23 +-
Documentation/driver-api/media/mc-core.rst | 5 +-
Documentation/driver-api/media/v4l2-subdev.rst | 6 +
drivers/media/i2c/adv748x/adv748x.h | 2 +-
drivers/media/i2c/tvp5150.c | 2 +-
drivers/media/mc/mc-entity.c | 74 ++-
drivers/media/pci/intel/ipu3/ipu3-cio2-main.c | 2 +-
drivers/media/platform/qcom/camss/camss-csid.c | 6 +-
drivers/media/platform/qcom/camss/camss-csiphy.c | 2 +-
drivers/media/platform/qcom/camss/camss-ispif.c | 4 +-
drivers/media/platform/qcom/camss/camss-vfe.c | 2 +-
drivers/media/platform/qcom/camss/camss-video.c | 6 +-
drivers/media/platform/qcom/camss/camss.c | 2 +-
.../media/platform/renesas/rcar-vin/rcar-core.c | 2 +-
.../media/platform/renesas/rcar-vin/rcar-csi2.c | 2 +-
drivers/media/platform/renesas/rcar-vin/rcar-dma.c | 2 +-
.../media/platform/renesas/rcar-vin/rcar-v4l2.c | 2 +-
drivers/media/platform/renesas/vsp1/vsp1_entity.c | 4 +-
drivers/media/platform/renesas/vsp1/vsp1_video.c | 2 +-
drivers/media/platform/rockchip/rkisp1/Kconfig | 2 +-
drivers/media/platform/rockchip/rkisp1/Makefile | 1 +
.../platform/rockchip/rkisp1/rkisp1-capture.c | 22 +-
.../media/platform/rockchip/rkisp1/rkisp1-common.c | 143 ++++++
.../media/platform/rockchip/rkisp1/rkisp1-common.h | 109 +++-
.../media/platform/rockchip/rkisp1/rkisp1-csi.c | 536 +++++++++++++++++++
.../media/platform/rockchip/rkisp1/rkisp1-csi.h | 28 +
.../media/platform/rockchip/rkisp1/rkisp1-debug.c | 21 +
.../media/platform/rockchip/rkisp1/rkisp1-dev.c | 431 +++++++++-------
.../media/platform/rockchip/rkisp1/rkisp1-isp.c | 571 +++++----------------
.../media/platform/rockchip/rkisp1/rkisp1-params.c | 2 +-
.../platform/rockchip/rkisp1/rkisp1-resizer.c | 14 +-
.../media/platform/rockchip/rkisp1/rkisp1-stats.c | 4 +-
drivers/media/platform/samsung/exynos4-is/common.c | 2 +-
.../platform/samsung/exynos4-is/fimc-capture.c | 6 +-
.../platform/samsung/exynos4-is/fimc-isp-video.c | 2 +-
.../media/platform/samsung/exynos4-is/fimc-lite.c | 2 +-
.../media/platform/samsung/exynos4-is/media-dev.c | 2 +-
.../platform/samsung/s3c-camif/camif-capture.c | 2 +-
drivers/media/platform/st/stm32/stm32-dcmi.c | 6 +-
.../media/platform/sunxi/sun6i-csi/sun6i_video.c | 4 +-
drivers/media/platform/ti/cal/cal-camerarx.c | 2 +-
drivers/media/platform/ti/cal/cal-video.c | 2 +-
drivers/media/platform/ti/omap3isp/isp.c | 6 +-
drivers/media/platform/ti/omap3isp/ispccdc.c | 2 +-
drivers/media/platform/ti/omap3isp/ispccp2.c | 2 +-
drivers/media/platform/ti/omap3isp/ispcsi2.c | 2 +-
drivers/media/platform/ti/omap3isp/ispvideo.c | 4 +-
drivers/media/platform/video-mux.c | 2 +-
drivers/media/platform/xilinx/xilinx-csi2rxss.c | 2 +-
drivers/media/platform/xilinx/xilinx-dma.c | 4 +-
drivers/media/test-drivers/vimc/vimc-streamer.c | 2 +-
drivers/media/v4l2-core/v4l2-async.c | 10 +
drivers/staging/media/imx/imx-media-dev-common.c | 2 +-
drivers/staging/media/imx/imx-media-utils.c | 2 +-
drivers/staging/media/imx/imx7-media-csi.c | 2 +-
drivers/staging/media/omap4iss/iss.c | 6 +-
drivers/staging/media/omap4iss/iss_csi2.c | 2 +-
drivers/staging/media/omap4iss/iss_video.c | 2 +-
drivers/staging/media/tegra-video/vi.c | 4 +-
include/media/media-entity.h | 68 ++-
include/media/v4l2-async.h | 2 +
61 files changed, 1479 insertions(+), 711 deletions(-)
create mode 100644 drivers/media/platform/rockchip/rkisp1/rkisp1-csi.c
create mode 100644 drivers/media/platform/rockchip/rkisp1/rkisp1-csi.h
Comments
From: builder@linuxtv.org
Pull request: https://patchwork.linuxtv.org/project/linux-media/patch/YtF9MkyD11fMnpYp@pendragon.ideasonboard.com/
Build log: https://builder.linuxtv.org/job/patchwork/225089/
Build time: 00:43:02
Link: https://lore.kernel.org/linux-media/YtF9MkyD11fMnpYp@pendragon.ideasonboard.com
gpg: Signature made Fri 15 Jul 2022 02:39:29 PM UTC
gpg: using RSA key CB9D6877529820CD53099B1B65F89C37BC54210D
gpg: issuer "laurent.pinchart@ideasonboard.com"
gpg: Can't check signature: No public key
Summary: got 7/46 patches with issues, being 5 at build time, plus one error when buinding PDF document
Error/warnings:
patches/0001-media-v4l2-async-Add-notifier-operation-to-destroy-a.patch:
allyesconfig: return code #0:
../scripts/genksyms/parse.y: warning: 9 shift/reduce conflicts [-Wconflicts-sr]
../scripts/genksyms/parse.y: warning: 5 reduce/reduce conflicts [-Wconflicts-rr]
../scripts/genksyms/parse.y: note: rerun with option '-Wcounterexamples' to generate conflict counterexamples
allyesconfig: return code #0:
../drivers/media/i2c/cx25840/cx25840-core.c: ../drivers/media/i2c/cx25840/cx25840-core.c:5077 cx23885_dif_setup() parse error: turning off implications after 60 seconds
../drivers/media/platform/sunxi/sun6i-mipi-csi2/sun6i_mipi_csi2.c:193 sun6i_mipi_csi2_s_stream() warn: missing error code 'ret'
../drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/sun8i_a83t_mipi_csi2.c:225 sun8i_a83t_mipi_csi2_s_stream() warn: missing error code 'ret'
../drivers/media/dvb-frontends/sp887x.c: ../drivers/media/dvb-frontends/sp887x.c:178 sp887x_initial_setup() error: __memcpy() '&buf[2]' too small (30 vs 16384)
SMATCH:../drivers/media/usb/siano/smsusb.c ../drivers/media/usb/siano/smsusb.c:53:38: :warning: array of flexible structures
SPARSE:../drivers/media/usb/siano/smsusb.c ../drivers/media/usb/siano/smsusb.c:53:38: warning: array of flexible structures
../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2548 dvb_register() parse error: OOM: 3000032Kb sm_state_count = 1725745
../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2548 dvb_register() warn: Function too hairy. No more merges.
../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2548 dvb_register() parse error: __split_smt: function too hairy. Giving up after 58 seconds
../drivers/media/pci/cx88/cx88-dvb.c: ../drivers/media/pci/cx88/cx88-dvb.c:1626 dvb_register() error: we previously assumed 'fe1->dvb.frontend' could be null (see line 1086)
../drivers/media/usb/em28xx/em28xx-video.c: ../drivers/media/usb/em28xx/em28xx-video.c:2818 em28xx_v4l2_init() parse error: turning off implications after 60 seconds
../drivers/media/test-drivers/vimc/vimc-core.c: ../drivers/media/test-drivers/vimc/vimc-core.c:214 vimc_create_links() warn: passing a valid pointer to 'PTR_ERR'
patches/0002-media-mc-entity-Rename-media_entity_remote_pad-to-me.patch:
allyesconfig: return code #0:
../drivers/media/test-drivers/vimc/vimc-core.c: ../drivers/media/test-drivers/vimc/vimc-core.c:214 vimc_create_links() warn: passing a valid pointer to 'PTR_ERR'
../drivers/media/i2c/cx25840/cx25840-core.c: ../drivers/media/i2c/cx25840/cx25840-core.c:5121 cx23885_dif_setup() parse error: turning off implications after 60 seconds
../drivers/media/test-drivers/vivid/vivid-core.c: ../drivers/media/test-drivers/vivid/vivid-core.c:1981 vivid_create_instance() parse error: turning off implications after 60 seconds
../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2507 dvb_register() parse error: turning off implications after 60 seconds
../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2548 dvb_register() parse error: OOM: 3000032Kb sm_state_count = 1725782
../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2548 dvb_register() warn: Function too hairy. No more merges.
../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2548 dvb_register() parse error: __split_smt: function too hairy. Giving up after 62 seconds
../drivers/media/dvb-frontends/sp887x.c: ../drivers/media/dvb-frontends/sp887x.c:178 sp887x_initial_setup() error: __memcpy() '&buf[2]' too small (30 vs 16384)
SMATCH:../drivers/media/usb/siano/smsusb.c ../drivers/media/usb/siano/smsusb.c:53:38: :warning: array of flexible structures
SPARSE:../drivers/media/usb/siano/smsusb.c ../drivers/media/usb/siano/smsusb.c:53:38: warning: array of flexible structures
../drivers/media/pci/cx88/cx88-dvb.c: ../drivers/media/pci/cx88/cx88-dvb.c:1626 dvb_register() error: we previously assumed 'fe1->dvb.frontend' could be null (see line 1086)
../drivers/media/platform/sunxi/sun6i-mipi-csi2/sun6i_mipi_csi2.c:193 sun6i_mipi_csi2_s_stream() warn: missing error code 'ret'
../drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/sun8i_a83t_mipi_csi2.c:225 sun8i_a83t_mipi_csi2_s_stream() warn: missing error code 'ret'
../drivers/media/usb/em28xx/em28xx-video.c: ../drivers/media/usb/em28xx/em28xx-video.c:2810 em28xx_v4l2_init() parse error: turning off implications after 60 seconds
checkpatch.pl:
$ cat patches/0002-media-mc-entity-Rename-media_entity_remote_pad-to-me.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict
-:268: CHECK: Lines should not end with a '('
patches/0003-media-mc-entity-Add-a-new-helper-function-to-get-a-r.patch:
allyesconfig: return code #0:
../drivers/media/i2c/cx25840/cx25840-core.c: ../drivers/media/i2c/cx25840/cx25840-core.c:5341 cx23885_dif_setup() parse error: turning off implications after 60 seconds
SMATCH:../drivers/media/usb/siano/smsusb.c ../drivers/media/usb/siano/smsusb.c:53:38: :warning: array of flexible structures
SPARSE:../drivers/media/usb/siano/smsusb.c ../drivers/media/usb/siano/smsusb.c:53:38: warning: array of flexible structures
../drivers/media/test-drivers/vimc/vimc-core.c: ../drivers/media/test-drivers/vimc/vimc-core.c:214 vimc_create_links() warn: passing a valid pointer to 'PTR_ERR'
../drivers/media/dvb-frontends/mb86a16.c: ../drivers/media/dvb-frontends/mb86a16.c:1483 mb86a16_set_fe() parse error: turning off implications after 60 seconds
../drivers/media/platform/sunxi/sun6i-mipi-csi2/sun6i_mipi_csi2.c:193 sun6i_mipi_csi2_s_stream() warn: missing error code 'ret'
../drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/sun8i_a83t_mipi_csi2.c:225 sun8i_a83t_mipi_csi2_s_stream() warn: missing error code 'ret'
../drivers/media/test-drivers/vivid/vivid-core.c: ../drivers/media/test-drivers/vivid/vivid-core.c:1981 vivid_create_instance() parse error: turning off implications after 60 seconds
../drivers/media/dvb-frontends/sp887x.c: ../drivers/media/dvb-frontends/sp887x.c:178 sp887x_initial_setup() error: __memcpy() '&buf[2]' too small (30 vs 16384)
../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2346 dvb_register() parse error: turning off implications after 60 seconds
../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2548 dvb_register() parse error: OOM: 3000024Kb sm_state_count = 1724942
../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2548 dvb_register() warn: Function too hairy. No more merges.
../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2548 dvb_register() parse error: __split_smt: function too hairy. Giving up after 68 seconds
../drivers/media/pci/cx88/cx88-dvb.c: ../drivers/media/pci/cx88/cx88-dvb.c:1626 dvb_register() error: we previously assumed 'fe1->dvb.frontend' could be null (see line 1086)
../drivers/media/usb/em28xx/em28xx-video.c: ../drivers/media/usb/em28xx/em28xx-video.c:2831 em28xx_v4l2_init() parse error: turning off implications after 60 seconds
patches/0004-media-mc-entity-Add-a-new-helper-function-to-get-a-r.patch:
allyesconfig: return code #0:
../drivers/media/i2c/cx25840/cx25840-core.c: ../drivers/media/i2c/cx25840/cx25840-core.c:4989 cx23885_dif_setup() parse error: turning off implications after 60 seconds
../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2362 dvb_register() parse error: turning off implications after 60 seconds
../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2548 dvb_register() parse error: OOM: 3000028Kb sm_state_count = 1724927
../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2548 dvb_register() warn: Function too hairy. No more merges.
../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2548 dvb_register() parse error: __split_smt: function too hairy. Giving up after 69 seconds
../drivers/media/pci/cx88/cx88-dvb.c: ../drivers/media/pci/cx88/cx88-dvb.c:1626 dvb_register() error: we previously assumed 'fe1->dvb.frontend' could be null (see line 1086)
../drivers/media/platform/sunxi/sun6i-mipi-csi2/sun6i_mipi_csi2.c:193 sun6i_mipi_csi2_s_stream() warn: missing error code 'ret'
../drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/sun8i_a83t_mipi_csi2.c:225 sun8i_a83t_mipi_csi2_s_stream() warn: missing error code 'ret'
SMATCH:../drivers/media/usb/siano/smsusb.c ../drivers/media/usb/siano/smsusb.c:53:38: :warning: array of flexible structures
SPARSE:../drivers/media/usb/siano/smsusb.c ../drivers/media/usb/siano/smsusb.c:53:38: warning: array of flexible structures
../drivers/media/dvb-frontends/sp887x.c: ../drivers/media/dvb-frontends/sp887x.c:178 sp887x_initial_setup() error: __memcpy() '&buf[2]' too small (30 vs 16384)
../drivers/media/test-drivers/vimc/vimc-core.c: ../drivers/media/test-drivers/vimc/vimc-core.c:214 vimc_create_links() warn: passing a valid pointer to 'PTR_ERR'
../drivers/media/test-drivers/vivid/vivid-core.c: ../drivers/media/test-drivers/vivid/vivid-core.c:1981 vivid_create_instance() parse error: turning off implications after 60 seconds
../drivers/media/usb/em28xx/em28xx-video.c: ../drivers/media/usb/em28xx/em28xx-video.c:2831 em28xx_v4l2_init() parse error: turning off implications after 60 seconds
patches/0019-media-rkisp1-Split-CSI-handling-to-separate-file.patch:
checkpatch.pl:
$ cat patches/0019-media-rkisp1-Split-CSI-handling-to-separate-file.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict
-:101: WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
patches/0021-media-rkisp1-csi-Handle-CSI-2-RX-configuration-fully.patch:
allyesconfig: return code #512:
../drivers/media/platform/rockchip/rkisp1/rkisp1-csi.c:72:6: error: no previous prototype for ‘rkisp1_mipi_start’ [-Werror=missing-prototypes]
../drivers/media/platform/rockchip/rkisp1/rkisp1-csi.c:82:6: error: no previous prototype for ‘rkisp1_mipi_stop’ [-Werror=missing-prototypes]
cc1: all warnings being treated as errors
make[6]: *** [../scripts/Makefile.build:249: drivers/media/platform/rockchip/rkisp1/rkisp1-csi.o] Error 1
make[6]: *** Waiting for unfinished jobs....
make[5]: *** [../scripts/Makefile.build:466: drivers/media/platform/rockchip/rkisp1] Error 2
make[4]: *** [../scripts/Makefile.build:466: drivers/media/platform/rockchip] Error 2
make[3]: *** [../scripts/Makefile.build:466: drivers/media/platform] Error 2
make[2]: *** [../scripts/Makefile.build:466: drivers/media] Error 2
make[1]: *** [/var/lib/jenkins/workspace/patchwork/Makefile:1843: drivers] Error 2
make: *** [Makefile:219: __sub-make] Error 2
patches/0039-media-rkisp1-csi-Implement-a-V4L2-subdev-for-the-CSI.patch:
checkpatch.pl:
$ cat patches/0039-media-rkisp1-csi-Implement-a-V4L2-subdev-for-the-CSI.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict
-:65: CHECK: struct mutex definition without comment
Error #512 when building PDF docs
From: builder@linuxtv.org
Pull request: https://patchwork.linuxtv.org/project/linux-media/patch/YtF9MkyD11fMnpYp@pendragon.ideasonboard.com/
Build log: https://builder.linuxtv.org/job/patchwork/225499/
Build time: 00:20:50
Link: https://lore.kernel.org/linux-media/YtF9MkyD11fMnpYp@pendragon.ideasonboard.com
gpg: Signature made Fri 15 Jul 2022 02:39:29 PM UTC
gpg: using RSA key CB9D6877529820CD53099B1B65F89C37BC54210D
gpg: issuer "laurent.pinchart@ideasonboard.com"
gpg: Can't check signature: No public key
Summary: got 7/46 patches with issues, being 5 at build time, plus one error when buinding PDF document
Error/warnings:
patches/0001-media-v4l2-async-Add-notifier-operation-to-destroy-a.patch:
allyesconfig: return code #0:
../scripts/genksyms/parse.y: warning: 9 shift/reduce conflicts [-Wconflicts-sr]
../scripts/genksyms/parse.y: warning: 5 reduce/reduce conflicts [-Wconflicts-rr]
../scripts/genksyms/parse.y: note: rerun with option '-Wcounterexamples' to generate conflict counterexamples
allyesconfig: return code #0:
SMATCH:../drivers/media/usb/siano/smsusb.c ../drivers/media/usb/siano/smsusb.c:53:38: :warning: array of flexible structures
SPARSE:../drivers/media/usb/siano/smsusb.c ../drivers/media/usb/siano/smsusb.c:53:38: warning: array of flexible structures
../drivers/media/i2c/cx25840/cx25840-core.c: ../drivers/media/i2c/cx25840/cx25840-core.c:5429 cx23885_dif_setup() parse error: turning off implications after 60 seconds
../drivers/media/test-drivers/vimc/vimc-core.c: ../drivers/media/test-drivers/vimc/vimc-core.c:214 vimc_create_links() warn: passing a valid pointer to 'PTR_ERR'
../drivers/media/usb/uvc/uvc_ctrl.c: ../drivers/media/usb/uvc/uvc_ctrl.c:2472 uvc_ctrl_init_ctrl() error: we previously assumed 'mapping' could be null (see line 2458)
../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2548 dvb_register() parse error: OOM: 3000024Kb sm_state_count = 1725741
../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2548 dvb_register() warn: Function too hairy. No more merges.
../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2548 dvb_register() parse error: __split_smt: function too hairy. Giving up after 49 seconds
../drivers/media/dvb-frontends/sp887x.c: ../drivers/media/dvb-frontends/sp887x.c:178 sp887x_initial_setup() error: __memcpy() '&buf[2]' too small (30 vs 16384)
../drivers/media/platform/sunxi/sun6i-mipi-csi2/sun6i_mipi_csi2.c:193 sun6i_mipi_csi2_s_stream() warn: missing error code 'ret'
../drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/sun8i_a83t_mipi_csi2.c:225 sun8i_a83t_mipi_csi2_s_stream() warn: missing error code 'ret'
../drivers/media/usb/em28xx/em28xx-video.c: ../drivers/media/usb/em28xx/em28xx-video.c:2858 em28xx_v4l2_init() parse error: turning off implications after 60 seconds
patches/0002-media-mc-entity-Rename-media_entity_remote_pad-to-me.patch:
allyesconfig: return code #0:
../drivers/media/test-drivers/vimc/vimc-core.c: ../drivers/media/test-drivers/vimc/vimc-core.c:214 vimc_create_links() warn: passing a valid pointer to 'PTR_ERR'
SMATCH:../drivers/media/usb/siano/smsusb.c ../drivers/media/usb/siano/smsusb.c:53:38: :warning: array of flexible structures
SPARSE:../drivers/media/usb/siano/smsusb.c ../drivers/media/usb/siano/smsusb.c:53:38: warning: array of flexible structures
../drivers/media/i2c/cx25840/cx25840-core.c: ../drivers/media/i2c/cx25840/cx25840-core.c:5451 cx23885_dif_setup() parse error: turning off implications after 60 seconds
../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2548 dvb_register() parse error: OOM: 3000024Kb sm_state_count = 1725741
../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2548 dvb_register() warn: Function too hairy. No more merges.
../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2548 dvb_register() parse error: __split_smt: function too hairy. Giving up after 50 seconds
../drivers/media/dvb-frontends/sp887x.c: ../drivers/media/dvb-frontends/sp887x.c:178 sp887x_initial_setup() error: __memcpy() '&buf[2]' too small (30 vs 16384)
../drivers/media/platform/sunxi/sun6i-mipi-csi2/sun6i_mipi_csi2.c:193 sun6i_mipi_csi2_s_stream() warn: missing error code 'ret'
../drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/sun8i_a83t_mipi_csi2.c:225 sun8i_a83t_mipi_csi2_s_stream() warn: missing error code 'ret'
../drivers/media/usb/uvc/uvc_ctrl.c: ../drivers/media/usb/uvc/uvc_ctrl.c:2472 uvc_ctrl_init_ctrl() error: we previously assumed 'mapping' could be null (see line 2458)
../drivers/media/usb/em28xx/em28xx-video.c: ../drivers/media/usb/em28xx/em28xx-video.c:2858 em28xx_v4l2_init() parse error: turning off implications after 60 seconds
checkpatch.pl:
$ cat patches/0002-media-mc-entity-Rename-media_entity_remote_pad-to-me.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict
-:268: CHECK: Lines should not end with a '('
patches/0003-media-mc-entity-Add-a-new-helper-function-to-get-a-r.patch:
allyesconfig: return code #0:
../drivers/media/platform/sunxi/sun6i-mipi-csi2/sun6i_mipi_csi2.c:193 sun6i_mipi_csi2_s_stream() warn: missing error code 'ret'
../drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/sun8i_a83t_mipi_csi2.c:225 sun8i_a83t_mipi_csi2_s_stream() warn: missing error code 'ret'
../drivers/media/i2c/cx25840/cx25840-core.c: ../drivers/media/i2c/cx25840/cx25840-core.c:5429 cx23885_dif_setup() parse error: turning off implications after 60 seconds
../drivers/media/test-drivers/vimc/vimc-core.c: ../drivers/media/test-drivers/vimc/vimc-core.c:214 vimc_create_links() warn: passing a valid pointer to 'PTR_ERR'
SMATCH:../drivers/media/usb/siano/smsusb.c ../drivers/media/usb/siano/smsusb.c:53:38: :warning: array of flexible structures
SPARSE:../drivers/media/usb/siano/smsusb.c ../drivers/media/usb/siano/smsusb.c:53:38: warning: array of flexible structures
../drivers/media/dvb-frontends/sp887x.c: ../drivers/media/dvb-frontends/sp887x.c:178 sp887x_initial_setup() error: __memcpy() '&buf[2]' too small (30 vs 16384)
../drivers/media/usb/uvc/uvc_ctrl.c: ../drivers/media/usb/uvc/uvc_ctrl.c:2472 uvc_ctrl_init_ctrl() error: we previously assumed 'mapping' could be null (see line 2458)
../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2548 dvb_register() parse error: OOM: 3000012Kb sm_state_count = 1725651
../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2548 dvb_register() warn: Function too hairy. No more merges.
../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2548 dvb_register() parse error: __split_smt: function too hairy. Giving up after 53 seconds
../drivers/media/usb/em28xx/em28xx-video.c: ../drivers/media/usb/em28xx/em28xx-video.c:2846 em28xx_v4l2_init() parse error: turning off implications after 60 seconds
patches/0004-media-mc-entity-Add-a-new-helper-function-to-get-a-r.patch:
allyesconfig: return code #0:
../drivers/media/i2c/cx25840/cx25840-core.c: ../drivers/media/i2c/cx25840/cx25840-core.c:5451 cx23885_dif_setup() parse error: turning off implications after 60 seconds
../drivers/media/test-drivers/vimc/vimc-core.c: ../drivers/media/test-drivers/vimc/vimc-core.c:214 vimc_create_links() warn: passing a valid pointer to 'PTR_ERR'
SMATCH:../drivers/media/usb/siano/smsusb.c ../drivers/media/usb/siano/smsusb.c:53:38: :warning: array of flexible structures
SPARSE:../drivers/media/usb/siano/smsusb.c ../drivers/media/usb/siano/smsusb.c:53:38: warning: array of flexible structures
../drivers/media/platform/sunxi/sun6i-mipi-csi2/sun6i_mipi_csi2.c:193 sun6i_mipi_csi2_s_stream() warn: missing error code 'ret'
../drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/sun8i_a83t_mipi_csi2.c:225 sun8i_a83t_mipi_csi2_s_stream() warn: missing error code 'ret'
../drivers/media/dvb-frontends/sp887x.c: ../drivers/media/dvb-frontends/sp887x.c:178 sp887x_initial_setup() error: __memcpy() '&buf[2]' too small (30 vs 16384)
../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2548 dvb_register() parse error: OOM: 3000008Kb sm_state_count = 1725648
../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2548 dvb_register() warn: Function too hairy. No more merges.
../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2548 dvb_register() parse error: __split_smt: function too hairy. Giving up after 52 seconds
../drivers/media/usb/uvc/uvc_ctrl.c: ../drivers/media/usb/uvc/uvc_ctrl.c:2472 uvc_ctrl_init_ctrl() error: we previously assumed 'mapping' could be null (see line 2458)
../drivers/media/usb/em28xx/em28xx-video.c: ../drivers/media/usb/em28xx/em28xx-video.c:2890 em28xx_v4l2_init() parse error: turning off implications after 60 seconds
patches/0019-media-rkisp1-Split-CSI-handling-to-separate-file.patch:
checkpatch.pl:
$ cat patches/0019-media-rkisp1-Split-CSI-handling-to-separate-file.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict
-:101: WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
patches/0021-media-rkisp1-csi-Handle-CSI-2-RX-configuration-fully.patch:
allyesconfig: return code #512:
../drivers/media/platform/rockchip/rkisp1/rkisp1-csi.c:72:6: error: no previous prototype for ‘rkisp1_mipi_start’ [-Werror=missing-prototypes]
../drivers/media/platform/rockchip/rkisp1/rkisp1-csi.c:82:6: error: no previous prototype for ‘rkisp1_mipi_stop’ [-Werror=missing-prototypes]
cc1: all warnings being treated as errors
make[6]: *** [../scripts/Makefile.build:249: drivers/media/platform/rockchip/rkisp1/rkisp1-csi.o] Error 1
make[6]: *** Waiting for unfinished jobs....
make[5]: *** [../scripts/Makefile.build:466: drivers/media/platform/rockchip/rkisp1] Error 2
make[4]: *** [../scripts/Makefile.build:466: drivers/media/platform/rockchip] Error 2
make[3]: *** [../scripts/Makefile.build:466: drivers/media/platform] Error 2
make[2]: *** [../scripts/Makefile.build:466: drivers/media] Error 2
make[1]: *** [/var/lib/jenkins/workspace/patchwork/Makefile:1843: drivers] Error 2
make: *** [Makefile:219: __sub-make] Error 2
patches/0039-media-rkisp1-csi-Implement-a-V4L2-subdev-for-the-CSI.patch:
checkpatch.pl:
$ cat patches/0039-media-rkisp1-csi-Implement-a-V4L2-subdev-for-the-CSI.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict
-:65: CHECK: struct mutex definition without comment
Error #512 when building PDF docs