Message ID | Yn41HyGCOJyZU98T@valkosipuli.retiisi.eu (mailing list archive) |
---|---|
State | Changes Requested |
Headers |
Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from <linux-media-owner@vger.kernel.org>) id 1npSgo-009mND-G3; Fri, 13 May 2022 10:38:31 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379519AbiEMKi2 (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Fri, 13 May 2022 06:38:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237341AbiEMKi1 (ORCPT <rfc822;linux-media@vger.kernel.org>); Fri, 13 May 2022 06:38:27 -0400 Received: from lahtoruutu.iki.fi (lahtoruutu.iki.fi [IPv6:2a0b:5c81:1c1::37]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B540160ABD for <linux-media@vger.kernel.org>; Fri, 13 May 2022 03:38:26 -0700 (PDT) Received: from hillosipuli.retiisi.eu (89-27-103-169.bb.dnainternet.fi [89.27.103.169]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: sailus) by lahtoruutu.iki.fi (Postfix) with ESMTPSA id 580FB1B003E5 for <linux-media@vger.kernel.org>; Fri, 13 May 2022 13:38:24 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1652438304; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=V/udHH2BKb7Dvj5W/aaJo3o1xcu+TJygPOPY8VAycjk=; b=YovPGmhZbjd91wzra6BEueUvocTmnVkELgK2Gjr59RpRATpAmOWU5+9Bb/94jpgrcAO2Qj wiq6n4AiW7hFWzccpyaki4mwbW2PHRnNNyFk9VEtSbDWSj56POvms5Pa3bQ++/IXQkVZT/ 6eGQjNCRZCihUuSj9jB6v7bn4nLbyTuqBw+axm58eCdruqSZQh+7Oo70ZzkaDVcwp5hrrZ FPkaOQ8eyiZtw+eYiK9epMcm9+5AoybG2rRfBvEtrtxTC9tt3bfb+xdedFykfy0q/s+OC3 n16nrxBaKbIRZe260ow752E/ON7i2/JZ+3vnsNor7RlQqVtTcoFilGUfefbyBg== Received: from valkosipuli.retiisi.eu (valkosipuli.localdomain [192.168.4.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by hillosipuli.retiisi.eu (Postfix) with ESMTPS id EB057634C91 for <linux-media@vger.kernel.org>; Fri, 13 May 2022 13:38:23 +0300 (EEST) Date: Fri, 13 May 2022 13:38:23 +0300 From: Sakari Ailus <sakari.ailus@iki.fi> To: linux-media@vger.kernel.org Subject: [GIT PULL FOR 5.19] Ov5640 driver improvements Message-ID: <Yn41HyGCOJyZU98T@valkosipuli.retiisi.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline ARC-Seal: i=1; s=lahtoruutu; d=iki.fi; t=1652438304; a=rsa-sha256; cv=none; b=londcs+g22EMkQ2i29TFuvfI/OXR+hrz6AGYGkzg/O1X+IBB1mKD2eTBUCsGXtu6O286ck vrK8oyJmXUs8/7mkgXEqxZNhkzzuwWa63vtcHRqaiNeHbFFmn6h9t63nLR7+BfJKhdgv4Q uSfy/5ruSs5Da0fu+NHbrt95H5B3qdABClCr2fKbzRGKL2B0szdVcGNORg2NjPckC84zZd gvB9ZO+tSPCYIuJAV5Y0ps64kmE5oFmM/08Hqt75ext5bK56VbGVXak3e4sSeU0y9Ieva0 wB/sFhAZIy9cr+e7K6ERgs9j4pZuegyR1KdjjTu3js8GXRKNR3r/kQe5GfRSMw== ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=sailus smtp.mailfrom=sakari.ailus@iki.fi ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1652438304; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=V/udHH2BKb7Dvj5W/aaJo3o1xcu+TJygPOPY8VAycjk=; b=hPcqJyQ+ErVlTbljTJi7KL7LtsSb4KVv0/NjuPM/BgSUDY3ptsJdjHKXxjSfJFKrfYdHVn nCtFTvFjYXXEqgx7665bpVNlksgLYOfT5DgrTP5LyOa7FQx2aCJrf0epjmcuJl5qc1WfH4 Z2xkZIaYIxQe7LJ+N5hehdw4XMQ/+0lKS/Nj7MGQ5FyILPPl1tJMwwW2SlzswWxz7OW/eW yAgZv9swaQg8GmnKCBK8wLp2r31HIwjusBTNWKe9sUe5gEKd83U012DOtuOCHZ2rE+uWBx mgk2IL4ggUEDfv15RSdTt6Mexuqrd8VaCN9OoKoYksXS58ZDVeKZy4O7EXqoHg== X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -2.5 (--) X-LSpam-Report: No, score=-2.5 required=5.0 tests=BAYES_00=-1.9,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1 autolearn=ham autolearn_force=no |
Series |
[GIT,PULL,FOR,5.19] Ov5640 driver improvements
|
|
Pull-request
git://linuxtv.org/sailus/media_tree.git tags/for-5.19-3-signedMessage
Sakari Ailus
May 13, 2022, 10:38 a.m. UTC
Hi Mauro, One more pull request. This contains the ov5640 driver improvements Jacopo has been working on for quite some time. Please pull. The following changes since commit 6c1c1eb8c87de221051b9198d40971640060842f: media: ext-ctrls-codec.rst: fix indentation (2022-04-25 23:55:02 +0100) are available in the Git repository at: git://linuxtv.org/sailus/media_tree.git tags/for-5.19-3-signed for you to fetch changes up to 8dd4316b66ace25bfd31c943f146b665ff48dd0e: media: ov5640: Move format mux config in format (2022-05-13 12:29:17 +0300) ---------------------------------------------------------------- ov5640 driver improvements for 5.19 ---------------------------------------------------------------- Hugues Fruchet (1): media: ov5640: Adjust vblank with s_frame_interval Jacopo Mondi (27): media: ov5640: Add pixel rate to modes media: ov5640: Re-arrange modes definition media: ov5640: Add ov5640_is_csi2() function media: ov5640: Associate bpp with formats media: ov5640: Add LINK_FREQ control media: ov5640: Update pixel_rate and link_freq media: ov5640: Rework CSI-2 clock tree media: ov5640: Rework timings programming media: ov5640: Fix 720x480 in RGB888 mode media: ov5640: Split DVP and CSI-2 timings media: ov5640: Provide timings accessor media: ov5640: Re-sort per-mode register tables media: ov5640: Remove duplicated mode settings media: ov5640: Remove ov5640_mode_init_data media: ov5640: Add HBLANK control media: ov5640: Add VBLANK control media: ov5640: Remove frame rate check from find_mode() media: ov5640: Change CSI-2 timings to comply with FPS media: ov5640: Implement init_cfg media: ov5640: Implement get_selection media: ov5640: Register device properties media: ov5640: Add RGB565_1X16 format media: ov5640: Add BGR888 format media: ov5640: Restrict sizes to mbus code media: ov5640: Adjust format to bpp in s_fmt media: ov5640: Split DVP and CSI-2 formats media: ov5640: Move format mux config in format drivers/media/i2c/ov5640.c | 1650 +++++++++++++++++++++++++++++++------------- 1 file changed, 1188 insertions(+), 462 deletions(-)
Comments
From: builder@linuxtv.org
Pull request: https://patchwork.linuxtv.org/project/linux-media/patch/Yn41HyGCOJyZU98T@valkosipuli.retiisi.eu/
Build log: https://builder.linuxtv.org/job/patchwork/207146/
Build time: 00:26:48
Link: https://lore.kernel.org/linux-media/Yn41HyGCOJyZU98T@valkosipuli.retiisi.eu
gpg: Signature made Fri 13 May 2022 10:35:38 AM UTC
gpg: using DSA key F0D0377A0D4F25A79238EFE56D40361B6E28C193
gpg: issuer "sakari.ailus@linux.intel.com"
gpg: Good signature from "Sakari Ailus <sakari.ailus@linux.intel.com>" [unknown]
gpg: WARNING: This key is not certified with a trusted signature!
gpg: There is no indication that the signature belongs to the owner.
Primary key fingerprint: F0D0 377A 0D4F 25A7 9238 EFE5 6D40 361B 6E28 C193
Summary: got 26/28 patches with issues, being 26 at build time, plus one error when buinding PDF document
Error/warnings:
patches/0001-media-ov5640-Add-pixel-rate-to-modes.patch:
allyesconfig: return code #0:
../scripts/genksyms/parse.y: warning: 9 shift/reduce conflicts [-Wconflicts-sr]
../scripts/genksyms/parse.y: warning: 5 reduce/reduce conflicts [-Wconflicts-rr]
../scripts/genksyms/parse.y: note: rerun with option '-Wcounterexamples' to generate conflict counterexamples
allyesconfig: return code #0:
SMATCH:../drivers/media/usb/siano/smsusb.c ../drivers/media/usb/siano/smsusb.c:53:38: :warning: array of flexible structures
SPARSE:../drivers/media/usb/siano/smsusb.c ../drivers/media/usb/siano/smsusb.c:53:38: warning: array of flexible structures
../drivers/media/test-drivers/vivid/vivid-core.c: ../drivers/media/test-drivers/vivid/vivid-core.c:1981 vivid_create_instance() parse error: turning off implications after 60 seconds
../drivers/media/platform/qcom/venus/helpers.c: ../drivers/media/platform/qcom/venus/helpers.c:678 venus_helper_get_bufreq() error: we previously assumed 'req' could be null (see line 674)
../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2617 dvb_register() parse error: turning off implications after 60 seconds
../drivers/media/usb/em28xx/em28xx-video.c: ../drivers/media/usb/em28xx/em28xx-video.c:2868 em28xx_v4l2_init() parse error: turning off implications after 60 seconds
patches/0004-media-ov5640-Associate-bpp-with-formats.patch:
allyesconfig: return code #512:
../drivers/media/i2c/ov5640.c:205:12: error: ‘ov5640_code_to_bpp’ defined but not used [-Werror=unused-function]
cc1: all warnings being treated as errors
make[4]: *** [../scripts/Makefile.build:288: drivers/media/i2c/ov5640.o] Error 1
make[3]: *** [../scripts/Makefile.build:550: drivers/media/i2c] Error 2
make[2]: *** [../scripts/Makefile.build:550: drivers/media] Error 2
make[1]: *** [/var/lib/jenkins/workspace/patchwork/Makefile:1834: drivers] Error 2
make: *** [Makefile:219: __sub-make] Error 2
allmodconfig: return code #512:
../drivers/media/i2c/ov5640.c:205:12: error: ‘ov5640_code_to_bpp’ defined but not used [-Werror=unused-function]
cc1: all warnings being treated as errors
make[4]: *** [../scripts/Makefile.build:288: drivers/media/i2c/ov5640.o] Error 1
make[3]: *** [../scripts/Makefile.build:550: drivers/media/i2c] Error 2
make[2]: *** [../scripts/Makefile.build:550: drivers/media] Error 2
make[1]: *** [/var/lib/jenkins/workspace/patchwork/Makefile:1834: drivers] Error 2
make: *** [Makefile:219: __sub-make] Error 2
patches/0005-media-ov5640-Add-LINK_FREQ-control.patch:
allyesconfig: return code #512:
../drivers/media/i2c/ov5640.c:223:12: error: ‘ov5640_code_to_bpp’ defined but not used [-Werror=unused-function]
cc1: all warnings being treated as errors
make[4]: *** [../scripts/Makefile.build:288: drivers/media/i2c/ov5640.o] Error 1
make[3]: *** [../scripts/Makefile.build:550: drivers/media/i2c] Error 2
make[2]: *** [../scripts/Makefile.build:550: drivers/media] Error 2
make[1]: *** [/var/lib/jenkins/workspace/patchwork/Makefile:1834: drivers] Error 2
make: *** [Makefile:219: __sub-make] Error 2
allmodconfig: return code #512:
../drivers/media/i2c/ov5640.c:223:12: error: ‘ov5640_code_to_bpp’ defined but not used [-Werror=unused-function]
cc1: all warnings being treated as errors
make[4]: *** [../scripts/Makefile.build:288: drivers/media/i2c/ov5640.o] Error 1
make[3]: *** [../scripts/Makefile.build:550: drivers/media/i2c] Error 2
make[2]: *** [../scripts/Makefile.build:550: drivers/media] Error 2
make[1]: *** [/var/lib/jenkins/workspace/patchwork/Makefile:1834: drivers] Error 2
make: *** [Makefile:219: __sub-make] Error 2
checkpatch.pl:
$ cat patches/0005-media-ov5640-Add-LINK_FREQ-control.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict
-:60: CHECK: Alignment should match open parenthesis
patches/0006-media-ov5640-Update-pixel_rate-and-link_freq.patch:
allyesconfig: return code #0:
internal error: file too large: db/kernel.return_fixes (limit 4096 bytes)
patches/0007-media-ov5640-Rework-CSI-2-clock-tree.patch:
allyesconfig: return code #0:
internal error: file too large: db/kernel.return_fixes (limit 4096 bytes)
patches/0008-media-ov5640-Rework-timings-programming.patch:
allyesconfig: return code #0:
internal error: file too large: db/kernel.return_fixes (limit 4096 bytes)
patches/0009-media-ov5640-Fix-720x480-in-RGB888-mode.patch:
allyesconfig: return code #0:
internal error: file too large: db/kernel.return_fixes (limit 4096 bytes)
patches/0010-media-ov5640-Split-DVP-and-CSI-2-timings.patch:
allyesconfig: return code #0:
internal error: file too large: db/kernel.return_fixes (limit 4096 bytes)
patches/0011-media-ov5640-Provide-timings-accessor.patch:
allyesconfig: return code #0:
internal error: file too large: db/kernel.return_fixes (limit 4096 bytes)
patches/0012-media-ov5640-Re-sort-per-mode-register-tables.patch:
allyesconfig: return code #0:
internal error: file too large: db/kernel.return_fixes (limit 4096 bytes)
patches/0013-media-ov5640-Remove-duplicated-mode-settings.patch:
allyesconfig: return code #0:
internal error: file too large: db/kernel.return_fixes (limit 4096 bytes)
patches/0014-media-ov5640-Remove-ov5640_mode_init_data.patch:
allyesconfig: return code #0:
internal error: file too large: db/kernel.return_fixes (limit 4096 bytes)
patches/0015-media-ov5640-Add-HBLANK-control.patch:
allyesconfig: return code #0:
internal error: file too large: db/kernel.return_fixes (limit 4096 bytes)
patches/0016-media-ov5640-Add-VBLANK-control.patch:
allyesconfig: return code #0:
internal error: file too large: db/kernel.return_fixes (limit 4096 bytes)
patches/0017-media-ov5640-Adjust-vblank-with-s_frame_interval.patch:
allyesconfig: return code #0:
internal error: file too large: db/kernel.return_fixes (limit 4096 bytes)
patches/0018-media-ov5640-Remove-frame-rate-check-from-find_mode.patch:
allyesconfig: return code #0:
internal error: file too large: db/kernel.return_fixes (limit 4096 bytes)
patches/0019-media-ov5640-Change-CSI-2-timings-to-comply-with-FPS.patch:
allyesconfig: return code #0:
internal error: file too large: db/kernel.return_fixes (limit 4096 bytes)
patches/0020-media-ov5640-Implement-init_cfg.patch:
allyesconfig: return code #0:
internal error: file too large: db/kernel.return_fixes (limit 4096 bytes)
patches/0021-media-ov5640-Implement-get_selection.patch:
allyesconfig: return code #0:
internal error: file too large: db/kernel.return_fixes (limit 4096 bytes)
patches/0022-media-ov5640-Register-device-properties.patch:
allyesconfig: return code #0:
internal error: file too large: db/kernel.return_fixes (limit 4096 bytes)
patches/0023-media-ov5640-Add-RGB565_1X16-format.patch:
allyesconfig: return code #0:
internal error: file too large: db/kernel.return_fixes (limit 4096 bytes)
patches/0024-media-ov5640-Add-BGR888-format.patch:
allyesconfig: return code #0:
internal error: file too large: db/kernel.return_fixes (limit 4096 bytes)
patches/0025-media-ov5640-Restrict-sizes-to-mbus-code.patch:
allyesconfig: return code #0:
internal error: file too large: db/kernel.return_fixes (limit 4096 bytes)
patches/0026-media-ov5640-Adjust-format-to-bpp-in-s_fmt.patch:
allyesconfig: return code #0:
internal error: file too large: db/kernel.return_fixes (limit 4096 bytes)
patches/0027-media-ov5640-Split-DVP-and-CSI-2-formats.patch:
allyesconfig: return code #0:
internal error: file too large: db/kernel.return_fixes (limit 4096 bytes)
patches/0028-media-ov5640-Move-format-mux-config-in-format.patch:
allyesconfig: return code #0:
internal error: file too large: db/kernel.return_fixes (limit 4096 bytes)
Error #512 when building PDF docs
Sakari, Em Fri, 13 May 2022 11:20:17 +0000 Jenkins <jenkins@linuxtv.org> escreveu: > ../drivers/media/i2c/ov5640.c:205:12: error: ‘ov5640_code_to_bpp’ defined but not used [-Werror=unused-function] > cc1: all warnings being treated as errors > make[4]: *** [../scripts/Makefile.build:288: drivers/media/i2c/ov5640.o] Error 1 > make[3]: *** [../scripts/Makefile.build:550: drivers/media/i2c] Error 2 > make[2]: *** [../scripts/Makefile.build:550: drivers/media] Error 2 > make[1]: *** [/var/lib/jenkins/workspace/patchwork/Makefile:1834: drivers] Error 2 > make: *** [Makefile:219: __sub-make] Error 2 Please fix this compilation breakage on this series. Thanks, Mauro