media: ccs: Remove uninitialized, unused variable

Message ID X9B0NIm4Iv4uFlkT@mwanda (mailing list archive)
State Not Applicable, archived
Delegated to: Sakari Ailus
Headers
Series media: ccs: Remove uninitialized, unused variable |

Commit Message

Dan Carpenter Dec. 9, 2020, 6:52 a.m. UTC
  The "reg" value isn't used any more but it's still printed in the
debug code.  Delete it.

Fixes: fd9065812c7b ("media: smiapp: Obtain frame descriptor from CCS limits")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/media/i2c/ccs/ccs-core.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
  

Comments

Sakari Ailus Dec. 9, 2020, 9:50 a.m. UTC | #1
Hi Dan,

On Wed, Dec 09, 2020 at 09:52:36AM +0300, Dan Carpenter wrote:
> The "reg" value isn't used any more but it's still printed in the
> debug code.  Delete it.
> 
> Fixes: fd9065812c7b ("media: smiapp: Obtain frame descriptor from CCS limits")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Thank you for the patch. This has been already fixed by another patch:

<URL:https://patchwork.linuxtv.org/project/linux-media/patch/20201203222828.1029943-1-arnd@kernel.org/>
  

Patch

diff --git a/drivers/media/i2c/ccs/ccs-core.c b/drivers/media/i2c/ccs/ccs-core.c
index 4447ca367a84..7a461c0a730d 100644
--- a/drivers/media/i2c/ccs/ccs-core.c
+++ b/drivers/media/i2c/ccs/ccs-core.c
@@ -268,7 +268,6 @@  static int ccs_read_frame_fmt(struct ccs_sensor *sensor)
 		u32 pixels;
 		char *which;
 		char *what;
-		u32 reg;
 
 		if (fmt_model_type == CCS_FRAME_FORMAT_MODEL_TYPE_2_BYTE) {
 			desc = CCS_LIM_AT(sensor, FRAME_FORMAT_DESCRIPTOR, i);
@@ -322,7 +321,7 @@  static int ccs_read_frame_fmt(struct ccs_sensor *sensor)
 		}
 
 		dev_dbg(&client->dev,
-			"0x%8.8x %s pixels: %d %s (pixelcode %u)\n", reg,
+			"%s pixels: %d %s (pixelcode %u)\n",
 			what, pixels, which, pixelcode);
 
 		if (i < ncol_desc) {