Message ID | CAOMZO5CRWC1qbYa3wAYfd+_ig0s9Bq2Z8Hz1SmM95Zuxb6LqRw@mail.gmail.com (mailing list archive) |
---|---|
State | Superseded, archived |
Headers |
Received: from vger.kernel.org ([209.132.180.67]) by www.linuxtv.org with esmtp (Exim 4.84_2) (envelope-from <linux-media-owner@vger.kernel.org>) id 1gPuU7-0006zC-9h; Thu, 22 Nov 2018 19:17:55 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392191AbeKWF6g (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Fri, 23 Nov 2018 00:58:36 -0500 Received: from mail-ot1-f66.google.com ([209.85.210.66]:34650 "EHLO mail-ot1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726009AbeKWF6g (ORCPT <rfc822;linux-media@vger.kernel.org>); Fri, 23 Nov 2018 00:58:36 -0500 Received: by mail-ot1-f66.google.com with SMTP id t5so8893110otk.1 for <linux-media@vger.kernel.org>; Thu, 22 Nov 2018 11:17:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Rucf7INNyZlIh8QsXGSWmufoKDW6jWUSg+2WFyaqUM4=; b=gGGIIvXvQ0usZwkfx696lzzoaDh+ENzMMiisGlvMXYMK+37lkfzbJKhqSXLkYhV3H8 dWjVDnXvAVv6o4ttcUyN2uquylAfFO1ZLtwDWTYzuiUiUfKHqOyrQujRCgMDdPAeZ8HD eI0AJ9twUKCGs0t2WTa20An3wgW4fsicu77fA/Yy+5coES2PNzcMHbv0T9p9Ojp1cwGd ZSb60G5msTQNqnAuNADvksAtEKOxVKrlzxJL7p4ZYJmmlg8tuHG198ii10PZamDnk9wK LwVfMhv3SM6yFLTdNZKHUPAiOK/OvR5xTj0CDozWTYf+1zdjZzwdUhYEuAthTi4SEi7a CslA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Rucf7INNyZlIh8QsXGSWmufoKDW6jWUSg+2WFyaqUM4=; b=Ztp4X8ZsJ1nUl08yWef9x4elbB58DeFGN9VYwDPlr53RvYFNVxvgKhzkf2fJ5bsp4A 7RObaUx4eZmqkQP/eq0Ma9rWeJSd6q5YNOKF5ygi4q5r1PdtoBsIx7NTqPR3T5DReG+a Pz/a3A2JRg90Pxdzf/8g8u3ErZbQVukX3w/j0kV/fZvj54ysnJPSa49is6GaTI8M3ZqA hlNOg9jO9G1lDiHH+6F5HJGZjk6kMyc3MWX3vnPxTCW+EVvdPVhfauXtetUKKtaoHwal 5SzFZsZWWSonD8citGoLr1EAi4gCPvrloejHv9eEqhdghCxcMHRXivmtLU80Uz36SBQ1 0eEA== X-Gm-Message-State: AA+aEWYCIfk893IkRcqCvnrD6wRug1ugZSRie5MYMYEhUoW+YnLGIdSL nEfodwEMsg502j1zTQLDvpzllq9NL5J613ilqY4= X-Google-Smtp-Source: AFSGD/WF1+d3HbzkRai0ehz9yyqhhILkaymsbXyx6xEqVndEag69VB1ORyciF1FHW5Jju8LQDxouiCeQptqSyHI8KUQ= X-Received: by 2002:a9d:7e87:: with SMTP id m7mr7680339otp.225.1542914272213; Thu, 22 Nov 2018 11:17:52 -0800 (PST) MIME-Version: 1.0 References: <CAOMZO5DP8JEMfjXJ8Hihm684+3=pOoCo1Gz7kt-TnCB7h-8EvA@mail.gmail.com> <1542904065.16720.2.camel@pengutronix.de> In-Reply-To: <1542904065.16720.2.camel@pengutronix.de> From: Fabio Estevam <festevam@gmail.com> Date: Thu, 22 Nov 2018 17:17:44 -0200 Message-ID: <CAOMZO5CRWC1qbYa3wAYfd+_ig0s9Bq2Z8Hz1SmM95Zuxb6LqRw@mail.gmail.com> Subject: Re: 'bad remote port parent' warnings To: Philipp Zabel <p.zabel@pengutronix.de> Cc: Sakari Ailus <sakari.ailus@linux.intel.com>, Steve Longerbeam <slongerbeam@gmail.com>, Hans Verkuil <hverkuil@xs4all.nl>, linux-media <linux-media@vger.kernel.org> Content-Type: text/plain; charset="UTF-8" Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org |
Commit Message
Fabio Estevam
Nov. 22, 2018, 7:17 p.m. UTC
Hi Philipp, On Thu, Nov 22, 2018 at 2:27 PM Philipp Zabel <p.zabel@pengutronix.de> wrote: > There are empty endpoint nodes (without remote-endpoint property) > labeled ipu1_csi[01]_mux_from_parallel_sensor in the i.MX6 device trees > for board DT implementers' convenience. See commit 2539f517acbdc ("ARM: > dts: imx6qdl: Add video multiplexers, mipi_csi, and their connections"). > > We had a discussion about this issue in February when this caused a > probing error: https://patchwork.kernel.org/patch/10234469/ Thanks for the clarification. We could demote the warning to a debug message, make the wording a bit > less misleading (there is no bad remote port parent, there is just no > remote endpoint at all), or we could just accept the error message for Something like this? } And how should we treat these error probes? [ 3.449564] imx-ipuv3 2400000.ipu: driver could not parse port@1/endpoint@0 (-22) [ 3.457342] imx-ipuv3-csi: probe of imx-ipuv3-csi.1 failed with error -22 [ 3.464498] imx-ipuv3 2800000.ipu: driver could not parse port@0/endpoint@0 (-22) [ 3.472120] imx-ipuv3-csi: probe of imx-ipuv3-csi.4 failed with error -22 Thanks
Comments
Hi Fabio, Philipp, On Thu, Nov 22, 2018 at 05:17:44PM -0200, Fabio Estevam wrote: > Hi Philipp, > > On Thu, Nov 22, 2018 at 2:27 PM Philipp Zabel <p.zabel@pengutronix.de> wrote: > > > There are empty endpoint nodes (without remote-endpoint property) > > labeled ipu1_csi[01]_mux_from_parallel_sensor in the i.MX6 device trees > > for board DT implementers' convenience. See commit 2539f517acbdc ("ARM: > > dts: imx6qdl: Add video multiplexers, mipi_csi, and their connections"). > > > > We had a discussion about this issue in February when this caused a > > probing error: https://patchwork.kernel.org/patch/10234469/ > > Thanks for the clarification. > > We could demote the warning to a debug message, make the wording a bit > > less misleading (there is no bad remote port parent, there is just no > > remote endpoint at all), or we could just accept the error message for > > Something like this? > > --- a/drivers/media/v4l2-core/v4l2-fwnode.c > +++ b/drivers/media/v4l2-core/v4l2-fwnode.c > @@ -613,7 +613,7 @@ v4l2_async_notifier_fwnode_parse_endpoint(struct > device *dev, > asd->match.fwnode = > fwnode_graph_get_remote_port_parent(endpoint); > if (!asd->match.fwnode) { > - dev_warn(dev, "bad remote port parent\n"); > + dev_dbg(dev, "no remote endpoint found\n"); Makes sense. This is not necessarily a fatal error. Could you send a patch? > ret = -ENOTCONN; > goto out_err; > } > > And how should we treat these error probes? > > [ 3.449564] imx-ipuv3 2400000.ipu: driver could not parse > port@1/endpoint@0 (-22) > [ 3.457342] imx-ipuv3-csi: probe of imx-ipuv3-csi.1 failed with error -22 > [ 3.464498] imx-ipuv3 2800000.ipu: driver could not parse > port@0/endpoint@0 (-22) > [ 3.472120] imx-ipuv3-csi: probe of imx-ipuv3-csi.4 failed with error -22 I'm not sure if this is a real problem, I presume it's just that the device has nothing connected to it, and so cannot work. Steve probably has a better understanding of this, I'm just guessing here. :-)
Hi Sakari,
On Fri, Nov 23, 2018 at 10:35 AM Sakari Ailus
<sakari.ailus@linux.intel.com> wrote:
> Makes sense. This is not necessarily a fatal error. Could you send a patch?
Yes, I have just sent it.
Thanks
Hi Fabio, On 11/22/18 11:17 AM, Fabio Estevam wrote: > Hi Philipp, > > On Thu, Nov 22, 2018 at 2:27 PM Philipp Zabel <p.zabel@pengutronix.de> wrote: > >> There are empty endpoint nodes (without remote-endpoint property) >> labeled ipu1_csi[01]_mux_from_parallel_sensor in the i.MX6 device trees >> for board DT implementers' convenience. See commit 2539f517acbdc ("ARM: >> dts: imx6qdl: Add video multiplexers, mipi_csi, and their connections"). >> >> We had a discussion about this issue in February when this caused a >> probing error: https://patchwork.kernel.org/patch/10234469/ > Thanks for the clarification. > > We could demote the warning to a debug message, make the wording a bit >> less misleading (there is no bad remote port parent, there is just no >> remote endpoint at all), or we could just accept the error message for > Something like this? > > --- a/drivers/media/v4l2-core/v4l2-fwnode.c > +++ b/drivers/media/v4l2-core/v4l2-fwnode.c > @@ -613,7 +613,7 @@ v4l2_async_notifier_fwnode_parse_endpoint(struct > device *dev, > asd->match.fwnode = > fwnode_graph_get_remote_port_parent(endpoint); > if (!asd->match.fwnode) { > - dev_warn(dev, "bad remote port parent\n"); > + dev_dbg(dev, "no remote endpoint found\n"); > ret = -ENOTCONN; > goto out_err; > } > > And how should we treat these error probes? > > [ 3.449564] imx-ipuv3 2400000.ipu: driver could not parse > port@1/endpoint@0 (-22) > [ 3.457342] imx-ipuv3-csi: probe of imx-ipuv3-csi.1 failed with error -22 > [ 3.464498] imx-ipuv3 2800000.ipu: driver could not parse > port@0/endpoint@0 (-22) > [ 3.472120] imx-ipuv3-csi: probe of imx-ipuv3-csi.4 failed with error -22 Yes, this is a regression caused by the imx subdev notifier patches. I've already sent a patch to the list for this, see https://www.spinics.net/lists/linux-media/msg141809.html Steve
Hi Steve, On Fri, Nov 23, 2018 at 8:37 PM Steve Longerbeam <slongerbeam@gmail.com> wrote: > Yes, this is a regression caused by the imx subdev notifier patches. > I've already sent a patch to the list for this, see > > https://www.spinics.net/lists/linux-media/msg141809.html Thanks, this fixes it. Hopefully it will be applied as a fix for 4.20. Thanks
--- a/drivers/media/v4l2-core/v4l2-fwnode.c +++ b/drivers/media/v4l2-core/v4l2-fwnode.c @@ -613,7 +613,7 @@ v4l2_async_notifier_fwnode_parse_endpoint(struct device *dev, asd->match.fwnode = fwnode_graph_get_remote_port_parent(endpoint); if (!asd->match.fwnode) { - dev_warn(dev, "bad remote port parent\n"); + dev_dbg(dev, "no remote endpoint found\n"); ret = -ENOTCONN; goto out_err;