Message ID | CALzAhNVDnyjwNqcWDcgv2kgQ97Hr0gArk8=V_mL62J0cD0Ydag@mail.gmail.com (mailing list archive) |
---|---|
State | Superseded, archived |
Headers |
Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from <linux-media-owner@vger.kernel.org>) id 1SqArK-0003dd-Tq for patchwork@linuxtv.org; Sun, 15 Jul 2012 00:30:42 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.75/mailfrontend-2) with esmtp for <patchwork@linuxtv.org> id 1SqArJ-0000Li-I7; Sun, 15 Jul 2012 00:30:42 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752165Ab2GNW3y (ORCPT <rfc822;patchwork@linuxtv.org>); Sat, 14 Jul 2012 18:29:54 -0400 Received: from mail-ob0-f174.google.com ([209.85.214.174]:41391 "EHLO mail-ob0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751310Ab2GNW3x convert rfc822-to-8bit (ORCPT <rfc822;linux-media@vger.kernel.org>); Sat, 14 Jul 2012 18:29:53 -0400 Received: by obbuo13 with SMTP id uo13so7031102obb.19 for <linux-media@vger.kernel.org>; Sat, 14 Jul 2012 15:29:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:date:message-id:subject:from:to:cc:content-type :content-transfer-encoding:x-gm-message-state; bh=JpgSTmsX2OzS5XvpP2WvHgoCatrLG1B5L+5zKk+y+Jc=; b=HJH3sqZVdWb7Z6jzFno94w8cTmtNchTgYQHrhACN0iVhX8/20mSFqwWRuY/71XZ76N ZtRiJRnrHy4TSm6dKfl9WC1EKPnoxhdCrJmPkOpAvDrGnm88sG2Wz5QunxojpoK+ORWM In2jEipptGH8srVAzgx2D6M+WbNAEcS1XvFZANv4Us57VLHE5tY5WD4m1gV8juXMErDX bu3/doVQKS3Egl6JmQxyIzw1MZ1+M4nT4K7qE9XLrxFBBheqEYND0cKwSZfBWjUsSlEF 6QbfO66eN1ZnMKinjfKZVVwRqqz4njiZexCjyjrVV/TxrUlb4ivHNVzKIs/wcJTxber4 T2oA== MIME-Version: 1.0 Received: by 10.50.181.232 with SMTP id dz8mr2131663igc.72.1342304992496; Sat, 14 Jul 2012 15:29:52 -0700 (PDT) Received: by 10.64.145.39 with HTTP; Sat, 14 Jul 2012 15:29:52 -0700 (PDT) Date: Sat, 14 Jul 2012 18:29:52 -0400 Message-ID: <CALzAhNVDnyjwNqcWDcgv2kgQ97Hr0gArk8=V_mL62J0cD0Ydag@mail.gmail.com> Subject: staging/for_v3.6 is currently broken From: Steven Toth <stoth@kernellabs.com> To: Mauro Chehab <mchehab@infradead.org> Cc: Linux-Media <linux-media@vger.kernel.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8BIT X-Gm-Message-State: ALoCoQmj3VQ3C5EvQ97b9Bcpv4/ye46RRfrwmBQllS+uiT2M6/xVeIzDzkSyCcVEF+wi8NQERFMu Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2012.7.14.222118 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' HTML_00_01 0.05, HTML_00_10 0.05, MSGID_ADDED_BY_MTA 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1800_1899 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, DATE_TZ_NA 0, URI_ENDS_IN_HTML 0, WEBMAIL_SOURCE 0, __ANY_URI 0, __CP_MEDIA_BODY 0, __CP_URI_IN_BODY 0, __CT 0, __CTE 0, __CT_TEXT_PLAIN 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __PHISH_SPEAR_HTTP_RECEIVED 0, __PHISH_SPEAR_STRUCTURE_1 0, __PHISH_SPEAR_STRUCTURE_2 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __URI_NS ' |
Commit Message
Steven Toth
July 14, 2012, 10:29 p.m. UTC
Looks like the new union in v4l2_ioctl_info breaks things. -bash-4.1$ make -j6 make[1]: Nothing to be done for `all'. CHK include/linux/version.h CHK include/generated/utsrelease.h CALL scripts/checksyscalls.sh CHK include/generated/compile.h CC drivers/media/video/v4l2-ioctl.o drivers/media/video/v4l2-ioctl.c:1848:517: error: unknown field ‘func’ specified in initializer drivers/media/video/v4l2-ioctl.c:1848:517: warning: missing braces around initializer drivers/media/video/v4l2-ioctl.c:1848:517: warning: (near initialization for ‘v4l2_ioctls[0].<anonymous>’) drivers/media/video/v4l2-ioctl.c:1848:517: warning: initialization makes integer from pointer without a cast drivers/media/video/v4l2-ioctl.c:1849:644: error: unknown field ‘func’ specified in initializer drivers/media/video/v4l2-ioctl.c:1849:644: warning: initialization makes integer from pointer without a cast Removing the union and the code compiles, although that probably wasn't the original authors intension. FYI
Comments
Steven Toth <stoth@kernellabs.com> wrote: >Looks like the new union in v4l2_ioctl_info breaks things. > >-bash-4.1$ make -j6 >make[1]: Nothing to be done for `all'. > CHK include/linux/version.h > CHK include/generated/utsrelease.h > CALL scripts/checksyscalls.sh > CHK include/generated/compile.h > CC drivers/media/video/v4l2-ioctl.o >drivers/media/video/v4l2-ioctl.c:1848:517: error: unknown field ‘func’ >specified in initializer >drivers/media/video/v4l2-ioctl.c:1848:517: warning: missing braces >around initializer >drivers/media/video/v4l2-ioctl.c:1848:517: warning: (near >initialization for ‘v4l2_ioctls[0].<anonymous>’) >drivers/media/video/v4l2-ioctl.c:1848:517: warning: initialization >makes integer from pointer without a cast >drivers/media/video/v4l2-ioctl.c:1849:644: error: unknown field ‘func’ >specified in initializer >drivers/media/video/v4l2-ioctl.c:1849:644: warning: initialization >makes integer from pointer without a cast > >Removing the union and the code compiles, although that probably >wasn't the original authors intension. > >diff --git a/drivers/media/video/v4l2-ioctl.c >b/drivers/media/video/v4l2-ioctl.c >index 70e0efb..1f090c4 100644 >--- a/drivers/media/video/v4l2-ioctl.c >+++ b/drivers/media/video/v4l2-ioctl.c >@@ -1802,11 +1802,9 @@ struct v4l2_ioctl_info { > unsigned int ioctl; > u32 flags; > const char * const name; >- union { > u32 offset; > int (*func)(const struct v4l2_ioctl_ops *ops, > struct file *file, void *fh, void *p); >- }; > void (*debug)(const void *arg, bool write_only); > }; > >FYI > >-- >Steven Toth - Kernel Labs >http://www.kernellabs.com >-- >To unsubscribe from this list: send the line "unsubscribe linux-media" >in >the body of a message to majordomo@vger.kernel.org >More majordomo info at http://vger.kernel.org/majordomo-info.html I think Hans fixed it another way: http://www.spinics.net/lists/linux-media/msg50234.html Regards, Andy -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sat, Jul 14, 2012 at 6:36 PM, Andy Walls <awalls@md.metrocast.net> wrote: > Steven Toth <stoth@kernellabs.com> wrote: > >>Looks like the new union in v4l2_ioctl_info breaks things. > > I think Hans fixed it another way: > > http://www.spinics.net/lists/linux-media/msg50234.html Thanks Andy.
diff --git a/drivers/media/video/v4l2-ioctl.c b/drivers/media/video/v4l2-ioctl.c index 70e0efb..1f090c4 100644 --- a/drivers/media/video/v4l2-ioctl.c +++ b/drivers/media/video/v4l2-ioctl.c @@ -1802,11 +1802,9 @@ struct v4l2_ioctl_info { unsigned int ioctl; u32 flags; const char * const name; - union { u32 offset; int (*func)(const struct v4l2_ioctl_ops *ops, struct file *file, void *fh, void *p); - }; void (*debug)(const void *arg, bool write_only); };