[PULL] git://git.linuxtv.org/mkrufky/mxl111sf.git mfe-fixes | WAS: Re: [git:v4l-dvb/for_v3.2] [media] dvb-usb: refactor MFE code for individual streaming config per frontend
Message ID | CAHAyoxyG9pS+3pOSQYepXsc+HDLGiW8EOud10JaXjas4Ku0fxw@mail.gmail.com (mailing list archive) |
---|---|
State | Accepted, archived |
Headers |
Return-path: <linux-media-owner@vger.kernel.org> Envelope-to: mchehab@infradead.org Delivery-date: Thu, 08 Sep 2011 04:28:36 +0000 Received: from casper.infradead.org [85.118.1.10] by localhost.localdomain with IMAP (fetchmail-6.3.17) for <mchehab@localhost> (single-drop); Thu, 08 Sep 2011 01:28:58 -0300 (BRT) Received: from vger.kernel.org ([209.132.180.67]) by casper.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1R1WE6-00034s-Nu; Thu, 08 Sep 2011 04:28:36 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751509Ab1IHE2c (ORCPT <rfc822; kmpark@infradead.org> + 1 other); Thu, 8 Sep 2011 00:28:32 -0400 Received: from mail-vw0-f43.google.com ([209.85.212.43]:54889 "EHLO mail-vw0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751175Ab1IHE2b convert rfc822-to-8bit (ORCPT <rfc822; linux-media@vger.kernel.org>); Thu, 8 Sep 2011 00:28:31 -0400 Received: by vws10 with SMTP id 10so593895vws.2 for <linux-media@vger.kernel.org>; Wed, 07 Sep 2011 21:28:30 -0700 (PDT) MIME-Version: 1.0 Received: by 10.52.67.168 with SMTP id o8mr209169vdt.30.1315456110343; Wed, 07 Sep 2011 21:28:30 -0700 (PDT) Received: by 10.52.167.169 with HTTP; Wed, 7 Sep 2011 21:28:30 -0700 (PDT) Date: Thu, 8 Sep 2011 00:28:30 -0400 Message-ID: <CAHAyoxyG9pS+3pOSQYepXsc+HDLGiW8EOud10JaXjas4Ku0fxw@mail.gmail.com> Subject: [PULL] git://git.linuxtv.org/mkrufky/mxl111sf.git mfe-fixes | WAS: Re: [git:v4l-dvb/for_v3.2] [media] dvb-usb: refactor MFE code for individual streaming config per frontend From: Michael Krufky <mkrufky@kernellabs.com> To: Mauro Carvalho Chehab <mchehab@redhat.com> Cc: linux-media@vger.kernel.org, Antti Palosaari <crope@iki.fi> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-CRM114-Version: 20090807-BlameThorstenAndJenny ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20110908_052835_188467_4794EF4E X-CRM114-Status: GOOD ( 20.44 ) X-Spam-Score: -2.2 (--) X-Spam-Report: SpamAssassin version 3.3.2 on casper.infradead.org summary: Content analysis details: (-2.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/, high trust [209.132.180.67 listed in list.dnswl.org] 2.8 KB_DATE_CONTAINS_TAB KB_DATE_CONTAINS_TAB 2.5 TAB_IN_FROM From starts with a tab -0.5 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] |
Pull-request
git://git.linuxtv.org/mkrufky/mxl111sf.git mfe-fixesMessage
Michael Krufky
Sept. 8, 2011, 4:28 a.m. UTC
>>>>>> On 09/08/2011 12:18 AM, Antti Palosaari wrote: >>>>>>> This patch seems to break all DVB USB devices we have. Michael, could >>>>>>> you check and fix it asap. [snip] >>>>>>>> Subject: [media] dvb-usb: refactor MFE code for individual streaming >>>>>>>> config per frontend [snip] >>>>>> This error is shown by VLC when channel changed: >>>>>> >>>>>> [0x7f1bbc000cd0] dvb access error: DMXSetFilter: failed with -1 (Invalid >>>>>> argument) >>>>>> [0x7f1bbc000cd0] dvb access error: DMXSetFilter failed >>>>>> [0x7f1bbc32f910] main stream error: cannot pre fill buffer >>>>>> >>>>>> but it seems to be related dvb_usb_ctrl_feed() I pointed earlier mail. [snip] >>> >>> Commenting out that >>>>>>> if ((adap->feedcount == onoff)&& (!onoff)) >>>>>>> adap->active_fe = -1; >>> >>> resolves problem. >> >> OK... I think it's safe to remove that code. The only time that >> "adap->active_fe" should really be set to -1 is at startup, before >> *any* frontend is used. Does removal of those two lines fix it for >> you completely? > > BTW, I understand the cause of this now -- this error case occurs when > the application stops streaming but leaves the frontend open. (for > instance, to change the channel) We only want to set (adap->active_fe > = -1) if ( ((adap->feedcount == onoff)&& (!onoff)) AND ALSO only if > the file handle gets closed. > > It's safe to just disable those lines for now. Mauro, Please pull from git://git.linuxtv.org/mkrufky/mxl111sf.git mfe-fixes branch, to fix the issue that Antti pointed out. The following changes since commit d4d4e3c97211f20d4fde5d82878561adaa42b578: Sylwester Nawrocki (1): [media] s5p-csis: Rework the system suspend/resume helpers are available in the git repository at: git://git.linuxtv.org/mkrufky/mxl111sf.git mfe-fixes Michael Krufky (2): dvb-usb: fix streaming failure on channel change dvb-usb: improve sanity check of adap->active_fe in dvb_usb_ctrl_feed drivers/media/dvb/dvb-usb/dvb-usb-dvb.c | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-) Cheers, Michael Krufky -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html