patchowork parsing issue?
Commit Message
Hello
I've submitted this patch a couple of times:
[PATCH] media_build: support building against a specific kernel
I formatted it with git-format-patch and it makes it into patchwork:
https://patchwork.linuxtv.org/patch/60186/
https://patchwork.linuxtv.org/patch/59979/
but it doesn't look right when it gets there. For some reason,
the last hunk of the patch is included with the patch description.
This was why I resent it the first time, I thought I must have
messed up the formatting.
Admittedly I'm sending from gmail's web interface but I have taken
some care to get the text correctly formatted and patchwork did the
same thing with it twice, so I'm starting to wonder if there's an issue
with patchwork.
I've attached my copy of the last outgoing email attempt in case
that's useful. The only thing that looks suspicous to me is on the
signed-off-by line I did not enclose my email address in '< >' markers,
while that last hunk happens to have those characters in it.
Kind regards
Vince
From vincent.mcintyre@gmail.com Fri Nov 15 22:11:14 2019
MIME-Version: 1.0
Received: by 2002:a19:905:0:0:0:0:0 with HTTP; Fri, 15 Nov 2019 03:11:14 -0800 (PST)
Date: Fri, 15 Nov 2019 22:11:14 +1100
Delivered-To: vincent.mcintyre@gmail.com
Message-ID: <CAEsFdVP9FkvG8+oPLkMUuaxPNYnc2Ug1dBgnAAxZqS_fUGf77Q@mail.gmail.com>
Subject: [PATCH] media_build: support building against a specific kernel.
From: Vincent McIntyre <vincent.mcintyre@gmail.com>
To: linux-media <linux-media@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Status: RO
Content-Length: 2188
Lines: 73
I find it helpful to be able to build the linux-media modules
for a kernel other than the one I am currently running.
This is a resend of the patch that appeared at
https://patchwork.linuxtv.org/patch/59979/
and completely supercedes that patch.
There are no differences in the patch, just the formatting of the
submission email.
Signed-off-by: vincent.mcintyre@gmail.com
---
build | 16 ++++++++++++++--
1 file changed, 14 insertions(+), 2 deletions(-)
@@ -579,6 +586,11 @@ depth parameter, in order to get a smaller tree.
That helps to reduce disk storage and download time.
+=item B<--version> [KERNELVERSION]
+
+Try to build for a particular kernel version. The format of the
+version string is the same as the output from 'uname -r'.
+
=back
=head1 DESCRIPTION
Comments
On Wed, Dec 04, 2019 at 08:40:59PM +1100, Vincent McIntyre wrote:
>
> https://patchwork.linuxtv.org/patch/60186/
> https://patchwork.linuxtv.org/patch/59979/
>
> but it doesn't look right when it gets there. For some reason,
> the last hunk of the patch is included with the patch description.
> This was why I resent it the first time, I thought I must have
> messed up the formatting.
>
> Admittedly I'm sending from gmail's web interface but I have taken
> some care to get the text correctly formatted and patchwork did the
> same thing with it twice, so I'm starting to wonder if there's an issue
> with patchwork.
...
> @@ -539,7 +546,7 @@ build - Builds the media drivers without needing
> to compile a new kernel
This line seems to be wrapped.
Quoting
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/email-clients.rst
Gmail (Web GUI)
***************
Does not work for sending patches.
Gmail web client converts tabs to spaces automatically.
At the same time it wraps lines every 78 chars with CRLF style line breaks
although tab2space problem can be solved with external editor.
Another problem is that Gmail will base64-encode any message that has a
non-ASCII character. That includes things like European names.
HTH,
Johannes
Thank you Johannes for taking the time to spot the wrapped line.
I did actually find that document...after I sent my email.
I'll resend from a saner mail service.
Regards
Vince
On 12/4/19, Johannes Stezenbach <js@linuxtv.org> wrote:
> On Wed, Dec 04, 2019 at 08:40:59PM +1100, Vincent McIntyre wrote:
>>
>> https://patchwork.linuxtv.org/patch/60186/
>> https://patchwork.linuxtv.org/patch/59979/
>>
>> but it doesn't look right when it gets there. For some reason,
>> the last hunk of the patch is included with the patch description.
>> This was why I resent it the first time, I thought I must have
>> messed up the formatting.
>>
>> Admittedly I'm sending from gmail's web interface but I have taken
>> some care to get the text correctly formatted and patchwork did the
>> same thing with it twice, so I'm starting to wonder if there's an issue
>> with patchwork.
> ...
>> @@ -539,7 +546,7 @@ build - Builds the media drivers without needing
>> to compile a new kernel
>
> This line seems to be wrapped.
>
> Quoting
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/email-clients.rst
>
> Gmail (Web GUI)
> ***************
>
> Does not work for sending patches.
>
> Gmail web client converts tabs to spaces automatically.
>
> At the same time it wraps lines every 78 chars with CRLF style line
> breaks
> although tab2space problem can be solved with external editor.
>
> Another problem is that Gmail will base64-encode any message that has a
> non-ASCII character. That includes things like European names.
>
>
> HTH,
> Johannes
>
@@ -14,6 +14,7 @@ my $check_only = 0;
my $main_git = 0;
my $depth;
my @git;
+my $kernel_version = '';
my $main_git_url = "git://linuxtv.org/media_tree.git";
my $main_branch = "master";
@@ -27,6 +28,7 @@ GetOptions('v|verbose' => \$level,
'main_git|main-git' => \$main_git,
'depth=i' => \$depth,
'git=s{2}' => \@git,
+ 'version=s' => \$kernel_version,
) or pod2usage(2);
pod2usage(1) if $help;
pod2usage(-exitstatus => 0, -verbose => 2) if $man;
@@ -522,7 +524,12 @@ print "******************\n";
print "* Start building *\n";
print "******************\n";
-run("make allyesconfig", "can't select all drivers");
+if ($kernel_version =~ /\S/) {
+ print "Building for kernel version $kernel_version\n";
+ run("make allyesconfig VER=$kernel_version", "can't select all drivers");
+} else {
+ run("make allyesconfig", "can't select all drivers");
+}
run("make", "build failed");
print "**********************************************************\n";
@@ -539,7 +546,7 @@ build - Builds the media drivers without needing
to compile a new kernel
=head1 SYNOPSIS
build [--help] [--man] [--verbose] [--check-only] [<--git> [URL] [BRANCH]]
- [--main-git] [--depth [DEPTH]]
+ [--main-git] [--depth [DEPTH]] [--version [KERNELVERSION]]
=head1 OPTIONS