[1/1] media: i2c: ov2640: Depend on V4L2_FWNODE

Message ID 90ec589b-7361-03aa-dab1-54ccd4116207@gentoo.org (mailing list archive)
State Under Review
Delegated to: Sakari Ailus
Headers
Series [1/1] media: i2c: ov2640: Depend on V4L2_FWNODE |

Commit Message

Mike Pagano April 27, 2022, 8:20 p.m. UTC
  Add V4L2_FWNODE as a dependency to match other drivers and prevent
failures when compile testing.

Signed-off-by: Mike Pagano <mpagano@gentoo.org>
---
  drivers/media/i2c/Kconfig | 1 +
  1 file changed, 1 insertion(+)
  

Comments

sakari.ailus@iki.fi April 27, 2022, 8:54 p.m. UTC | #1
Hi Mike,

Thanks for the patch.

On Wed, Apr 27, 2022 at 04:20:12PM -0400, Mike Pagano wrote:
> Add V4L2_FWNODE as a dependency to match other drivers and prevent
> failures when compile testing.
> 
> Signed-off-by: Mike Pagano <mpagano@gentoo.org>
> ---
>  drivers/media/i2c/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
> index fae2baabb773..6168c04d8b37 100644
> --- a/drivers/media/i2c/Kconfig
> +++ b/drivers/media/i2c/Kconfig
> @@ -372,6 +372,7 @@ config VIDEO_OV13B10
>  config VIDEO_OV2640
>  	tristate "OmniVision OV2640 sensor support"
>  	depends on VIDEO_DEV && I2C
> +	select V4L2_FWNODE

The driver doesn't use v4l2-fwnode but seems to depend on v4l2-async.

Shouldn't this be V4L2_ASYNC instead?

Could you also add this tag:

Fixes: ff3cc65cadb5 ("media: v4l: async, fwnode: Improve module organisation")

>  	help
>  	  This is a Video4Linux2 sensor driver for the OmniVision
>  	  OV2640 camera.
  
Mike Pagano April 27, 2022, 8:56 p.m. UTC | #2
On 4/27/22 16:54, Sakari Ailus wrote:
> Hi Mike,
> 
> Thanks for the patch.
> 
> On Wed, Apr 27, 2022 at 04:20:12PM -0400, Mike Pagano wrote:
>> Add V4L2_FWNODE as a dependency to match other drivers and prevent
>> failures when compile testing.
>>
>> Signed-off-by: Mike Pagano <mpagano@gentoo.org>
>> ---
>>   drivers/media/i2c/Kconfig | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
>> index fae2baabb773..6168c04d8b37 100644
>> --- a/drivers/media/i2c/Kconfig
>> +++ b/drivers/media/i2c/Kconfig
>> @@ -372,6 +372,7 @@ config VIDEO_OV13B10
>>   config VIDEO_OV2640
>>   	tristate "OmniVision OV2640 sensor support"
>>   	depends on VIDEO_DEV && I2C
>> +	select V4L2_FWNODE
> 
> The driver doesn't use v4l2-fwnode but seems to depend on v4l2-async.
> 
> Shouldn't this be V4L2_ASYNC instead?
> 
> Could you also add this tag:
> 
> Fixes: ff3cc65cadb5 ("media: v4l: async, fwnode: Improve module organisation")
> 
>>   	help
>>   	  This is a Video4Linux2 sensor driver for the OmniVision
>>   	  OV2640 camera.
> 

Thank-you for the response, Sakari, I will fix and resubmit.
  
Mike Pagano April 27, 2022, 9:59 p.m. UTC | #3
Add V4L2_ASYNC as a dependency to match other drivers and prevent failures when compile testing.

Fixes: ff3cc65cadb5 ("media: v4l: async, fwnode: Improve module organisation")

Signed-off-by: Mike Pagano <mpagano@gentoo.org>
---
  drivers/media/i2c/Kconfig | 1 +
  1 file changed, 1 insertion(+)

diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
index fae2baabb773..2b20aa6c37b1 100644
--- a/drivers/media/i2c/Kconfig
+++ b/drivers/media/i2c/Kconfig
@@ -372,6 +372,7 @@ config VIDEO_OV13B10
  config VIDEO_OV2640
  	tristate "OmniVision OV2640 sensor support"
  	depends on VIDEO_DEV && I2C
+	select V4L2_ASYNC
  	help
  	  This is a Video4Linux2 sensor driver for the OmniVision
  	  OV2640 camera.
  
sakari.ailus@iki.fi April 28, 2022, 10:51 a.m. UTC | #4
Hi Mike,

Thanks for the update.

On Wed, Apr 27, 2022 at 05:59:23PM -0400, Mike Pagano wrote:
> Add V4L2_ASYNC as a dependency to match other drivers and prevent failures when compile testing.

The commit message should be wrapped at 75 characters or earlier.

> 
> Fixes: ff3cc65cadb5 ("media: v4l: async, fwnode: Improve module organisation")
> 

No newline needed here.

I'll address these when merging it.

> Signed-off-by: Mike Pagano <mpagano@gentoo.org>
> ---
>  drivers/media/i2c/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
> index fae2baabb773..2b20aa6c37b1 100644
> --- a/drivers/media/i2c/Kconfig
> +++ b/drivers/media/i2c/Kconfig
> @@ -372,6 +372,7 @@ config VIDEO_OV13B10
>  config VIDEO_OV2640
>  	tristate "OmniVision OV2640 sensor support"
>  	depends on VIDEO_DEV && I2C
> +	select V4L2_ASYNC
>  	help
>  	  This is a Video4Linux2 sensor driver for the OmniVision
>  	  OV2640 camera.
  

Patch

diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
index fae2baabb773..6168c04d8b37 100644
--- a/drivers/media/i2c/Kconfig
+++ b/drivers/media/i2c/Kconfig
@@ -372,6 +372,7 @@  config VIDEO_OV13B10
  config VIDEO_OV2640
  	tristate "OmniVision OV2640 sensor support"
  	depends on VIDEO_DEV && I2C
+	select V4L2_FWNODE
  	help
  	  This is a Video4Linux2 sensor driver for the OmniVision
  	  OV2640 camera.