Message ID | 90ec589b-7361-03aa-dab1-54ccd4116207@gentoo.org (mailing list archive) |
---|---|
State | Under Review |
Delegated to: | Sakari Ailus |
Headers |
Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from <linux-media-owner@vger.kernel.org>) id 1njo9I-004OrE-6O; Wed, 27 Apr 2022 20:20:33 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235945AbiD0UXk (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Wed, 27 Apr 2022 16:23:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60842 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236558AbiD0UXd (ORCPT <rfc822;linux-media@vger.kernel.org>); Wed, 27 Apr 2022 16:23:33 -0400 Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 347E5939CB for <linux-media@vger.kernel.org>; Wed, 27 Apr 2022 13:20:16 -0700 (PDT) Message-ID: <90ec589b-7361-03aa-dab1-54ccd4116207@gentoo.org> Date: Wed, 27 Apr 2022 16:20:12 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Content-Language: en-US To: linux-media@vger.kernel.org From: Mike Pagano <mpagano@gentoo.org> Subject: [PATCH 1/1] media: i2c: ov2640: Depend on V4L2_FWNODE Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -2.4 (--) X-LSpam-Report: No, score=-2.4 required=5.0 tests=BAYES_00=-1.9,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1 autolearn=ham autolearn_force=no |
Series |
[1/1] media: i2c: ov2640: Depend on V4L2_FWNODE
|
|
Commit Message
Mike Pagano
April 27, 2022, 8:20 p.m. UTC
Add V4L2_FWNODE as a dependency to match other drivers and prevent
failures when compile testing.
Signed-off-by: Mike Pagano <mpagano@gentoo.org>
---
drivers/media/i2c/Kconfig | 1 +
1 file changed, 1 insertion(+)
Comments
Hi Mike, Thanks for the patch. On Wed, Apr 27, 2022 at 04:20:12PM -0400, Mike Pagano wrote: > Add V4L2_FWNODE as a dependency to match other drivers and prevent > failures when compile testing. > > Signed-off-by: Mike Pagano <mpagano@gentoo.org> > --- > drivers/media/i2c/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig > index fae2baabb773..6168c04d8b37 100644 > --- a/drivers/media/i2c/Kconfig > +++ b/drivers/media/i2c/Kconfig > @@ -372,6 +372,7 @@ config VIDEO_OV13B10 > config VIDEO_OV2640 > tristate "OmniVision OV2640 sensor support" > depends on VIDEO_DEV && I2C > + select V4L2_FWNODE The driver doesn't use v4l2-fwnode but seems to depend on v4l2-async. Shouldn't this be V4L2_ASYNC instead? Could you also add this tag: Fixes: ff3cc65cadb5 ("media: v4l: async, fwnode: Improve module organisation") > help > This is a Video4Linux2 sensor driver for the OmniVision > OV2640 camera.
On 4/27/22 16:54, Sakari Ailus wrote: > Hi Mike, > > Thanks for the patch. > > On Wed, Apr 27, 2022 at 04:20:12PM -0400, Mike Pagano wrote: >> Add V4L2_FWNODE as a dependency to match other drivers and prevent >> failures when compile testing. >> >> Signed-off-by: Mike Pagano <mpagano@gentoo.org> >> --- >> drivers/media/i2c/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig >> index fae2baabb773..6168c04d8b37 100644 >> --- a/drivers/media/i2c/Kconfig >> +++ b/drivers/media/i2c/Kconfig >> @@ -372,6 +372,7 @@ config VIDEO_OV13B10 >> config VIDEO_OV2640 >> tristate "OmniVision OV2640 sensor support" >> depends on VIDEO_DEV && I2C >> + select V4L2_FWNODE > > The driver doesn't use v4l2-fwnode but seems to depend on v4l2-async. > > Shouldn't this be V4L2_ASYNC instead? > > Could you also add this tag: > > Fixes: ff3cc65cadb5 ("media: v4l: async, fwnode: Improve module organisation") > >> help >> This is a Video4Linux2 sensor driver for the OmniVision >> OV2640 camera. > Thank-you for the response, Sakari, I will fix and resubmit.
Add V4L2_ASYNC as a dependency to match other drivers and prevent failures when compile testing.
Fixes: ff3cc65cadb5 ("media: v4l: async, fwnode: Improve module organisation")
Signed-off-by: Mike Pagano <mpagano@gentoo.org>
---
drivers/media/i2c/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
index fae2baabb773..2b20aa6c37b1 100644
--- a/drivers/media/i2c/Kconfig
+++ b/drivers/media/i2c/Kconfig
@@ -372,6 +372,7 @@ config VIDEO_OV13B10
config VIDEO_OV2640
tristate "OmniVision OV2640 sensor support"
depends on VIDEO_DEV && I2C
+ select V4L2_ASYNC
help
This is a Video4Linux2 sensor driver for the OmniVision
OV2640 camera.
Hi Mike, Thanks for the update. On Wed, Apr 27, 2022 at 05:59:23PM -0400, Mike Pagano wrote: > Add V4L2_ASYNC as a dependency to match other drivers and prevent failures when compile testing. The commit message should be wrapped at 75 characters or earlier. > > Fixes: ff3cc65cadb5 ("media: v4l: async, fwnode: Improve module organisation") > No newline needed here. I'll address these when merging it. > Signed-off-by: Mike Pagano <mpagano@gentoo.org> > --- > drivers/media/i2c/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig > index fae2baabb773..2b20aa6c37b1 100644 > --- a/drivers/media/i2c/Kconfig > +++ b/drivers/media/i2c/Kconfig > @@ -372,6 +372,7 @@ config VIDEO_OV13B10 > config VIDEO_OV2640 > tristate "OmniVision OV2640 sensor support" > depends on VIDEO_DEV && I2C > + select V4L2_ASYNC > help > This is a Video4Linux2 sensor driver for the OmniVision > OV2640 camera.
diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig index fae2baabb773..6168c04d8b37 100644 --- a/drivers/media/i2c/Kconfig +++ b/drivers/media/i2c/Kconfig @@ -372,6 +372,7 @@ config VIDEO_OV13B10 config VIDEO_OV2640 tristate "OmniVision OV2640 sensor support" depends on VIDEO_DEV && I2C + select V4L2_FWNODE help This is a Video4Linux2 sensor driver for the OmniVision OV2640 camera.