staging: media: VIDEO_STARFIVE_CAMSS should depend on ARCH_STARFIVE

Message ID 81476f48f7774fdd62e95458b160688952bb0068.1701196160.git.geert+renesas@glider.be (mailing list archive)
State Accepted
Delegated to: Hans Verkuil
Headers
Series staging: media: VIDEO_STARFIVE_CAMSS should depend on ARCH_STARFIVE |

Commit Message

Geert Uytterhoeven Nov. 28, 2023, 6:31 p.m. UTC
  The StarFive Camera Subsystem is only present on the StarFive JH7110
SoC.  Hence add a dependency on ARCH_STARFIVE, to prevent asking the
user about this driver when configuring a kernel without StarFive SoC
support.

Fixes: bba185d141b12787 ("media: staging: media: starfive: camss: Add core driver")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/staging/media/starfive/camss/Kconfig | 1 +
 1 file changed, 1 insertion(+)
  

Comments

Changhuang Liang Nov. 29, 2023, 7:41 a.m. UTC | #1
On 2023/11/29 2:31, Geert Uytterhoeven wrote:
> The StarFive Camera Subsystem is only present on the StarFive JH7110
> SoC.  Hence add a dependency on ARCH_STARFIVE, to prevent asking the
> user about this driver when configuring a kernel without StarFive SoC
> support.
> 
> Fixes: bba185d141b12787 ("media: staging: media: starfive: camss: Add core driver")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Reviewed-by: Changhuang Liang <changhuang.liang@starfivetech.com>

> ---
>  drivers/staging/media/starfive/camss/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/media/starfive/camss/Kconfig b/drivers/staging/media/starfive/camss/Kconfig
> index bd184f42c98fa853..9ea5708fe40955e2 100644
> --- a/drivers/staging/media/starfive/camss/Kconfig
> +++ b/drivers/staging/media/starfive/camss/Kconfig
> @@ -5,6 +5,7 @@ config VIDEO_STARFIVE_CAMSS
>  	depends on VIDEO_DEV && OF
>  	depends on HAS_DMA
>  	depends on PM
> +	depends on ARCH_STARFIVE || COMPILE_TEST
>  	select MEDIA_CONTROLLER
>  	select VIDEO_V4L2_SUBDEV_API
>  	select VIDEOBUF2_DMA_CONTIG
  

Patch

diff --git a/drivers/staging/media/starfive/camss/Kconfig b/drivers/staging/media/starfive/camss/Kconfig
index bd184f42c98fa853..9ea5708fe40955e2 100644
--- a/drivers/staging/media/starfive/camss/Kconfig
+++ b/drivers/staging/media/starfive/camss/Kconfig
@@ -5,6 +5,7 @@  config VIDEO_STARFIVE_CAMSS
 	depends on VIDEO_DEV && OF
 	depends on HAS_DMA
 	depends on PM
+	depends on ARCH_STARFIVE || COMPILE_TEST
 	select MEDIA_CONTROLLER
 	select VIDEO_V4L2_SUBDEV_API
 	select VIDEOBUF2_DMA_CONTIG