Message ID | 710cddfc-e3c3-0cf3-d2f9-c38ef6ca8b1a@xs4all.nl (mailing list archive) |
---|---|
State | Superseded, archived |
Headers |
Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from <linux-media-owner@vger.kernel.org>) id 1mZqzr-00Est3-Dx; Mon, 11 Oct 2021 08:49:23 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235302AbhJKIvV (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Mon, 11 Oct 2021 04:51:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50360 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235276AbhJKIvU (ORCPT <rfc822;linux-media@vger.kernel.org>); Mon, 11 Oct 2021 04:51:20 -0400 Received: from lb1-smtp-cloud7.xs4all.net (lb1-smtp-cloud7.xs4all.net [IPv6:2001:888:0:108::1a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B41AAC061570 for <linux-media@vger.kernel.org>; Mon, 11 Oct 2021 01:49:20 -0700 (PDT) Received: from cust-b5b5937f ([IPv6:fc0c:c16d:66b8:757f:c639:739b:9d66:799d]) by smtp-cloud7.xs4all.net with ESMTPA id Zqzimx8DYk3b0ZqzlmLjRU; Mon, 11 Oct 2021 10:49:17 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xs4all.nl; s=s2; t=1633942158; bh=qr6r+Go4l+7HOHqf8iAnuiUvXOWkzCNrgjlzVgUbCYU=; h=To:From:Subject:Message-ID:Date:MIME-Version:Content-Type:From: Subject; b=E1jyLCkIIX/GaQqZiUcacfsioH9eXSl2Tv73X4teLYdDsT1Bi+VEsjmgJwwCFIlmT YsJEf5vDVFesd0asRDje/vm1TtdSjzJyZMxcZaiEnksNJN3CmuZuF6DOY0ANLqmNEb ZJOA4urrRsFSp9f5KahfAdtCoiePlfrjjSzyI4i4HZ6J7e/d7A7bPMobzDvxA1guHR s2+1SlSIsrx3zHG9QrbAutJVdHvTSanexb0+Zn5iaCn9ILDBUKVeu+6BWhg9cqjGSs lZcSTBZFrJSNlFBXoNXrbhtNqCUvH2seeahcQQsh741HYx5inLInJGyLLf4szwMkz/ Qsz6xsk7w1i8Q== To: Linux Media Mailing List <linux-media@vger.kernel.org> Cc: Michael Tretter <m.tretter@pengutronix.de> From: Hans Verkuil <hverkuil@xs4all.nl> Subject: [GIT PULL FOR v5.16] Allegro fixes/enhancements Message-ID: <710cddfc-e3c3-0cf3-d2f9-c38ef6ca8b1a@xs4all.nl> Date: Mon, 11 Oct 2021 10:49:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.14.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4xfKB0tj69B9Hd4QPoVoqnHLXMDvWraGlc06LuEGnLrwhQWox0a1dxvCNz22ENqd+4J6DkEgrGIVUVLODJyQ0NUX6hjrAT+ra7i4DhKJ9vgkJUwqrLKn1o uFKwN/fl65/3oKgsaWHplV+nE2mC73yYleqQQ73M/PuxswZMjFu8NUe1p+Zp1vL/pNAM+4iOr4TaT4mt0Ffwy06H1v2vR56LEhzufqVKJtZbzYZ6B8UHO1jI U2xJFCMIGYy5CxrEj20ifw== Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -4.8 (----) X-LSpam-Report: No, score=-4.8 required=5.0 tests=BAYES_00=-1.9,DKIMWL_WL_MED=0.001,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1,RCVD_IN_DNSWL_MED=-2.3 autolearn=ham autolearn_force=no |
Series |
[GIT,PULL,FOR,v5.16] Allegro fixes/enhancements
|
|
Pull-request
git://linuxtv.org/hverkuil/media_tree.git tags/br-v5.16iMessage
Hans Verkuil
Oct. 11, 2021, 8:49 a.m. UTC
The following changes since commit fd2eda71a47b095e81b9170c3f8b7ae82b04e785: media: remove myself from dvb media maintainers (2021-10-08 13:56:25 +0200) are available in the Git repository at: git://linuxtv.org/hverkuil/media_tree.git tags/br-v5.16i for you to fetch changes up to 8f472ea73758255b366fae57bde772396231efcd: media: allegro: write vui parameters for HEVC (2021-10-11 10:18:33 +0200) ---------------------------------------------------------------- Tag branch ---------------------------------------------------------------- Michael Tretter (13): media: allegro: ignore interrupt if mailbox is not initialized media: allegro: fix module removal if initialization failed media: allegro: lookup VCU settings media: allegro: add pm_runtime support media: allegro: add encoder buffer support media: allegro: add control to disable encoder buffer media: allegro: fix row and column in response message media: allegro: remove external QP table media: allegro: correctly scale the bit rate in SPS media: allegro: extract nal value lookup functions to header media: allegro: write correct colorspace into SPS media: allegro: nal-hevc: implement generator for vui media: allegro: write vui parameters for HEVC drivers/media/platform/allegro-dvt/allegro-core.c | 311 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++------- drivers/media/platform/allegro-dvt/allegro-mail.c | 23 +++--- drivers/media/platform/allegro-dvt/allegro-mail.h | 10 ++- drivers/media/platform/allegro-dvt/nal-h264.c | 74 ----------------- drivers/media/platform/allegro-dvt/nal-h264.h | 200 +++++++++++++++++++++++++++++++++++++++++++- drivers/media/platform/allegro-dvt/nal-hevc.c | 202 +++++++++++++++++++++++++++++---------------- drivers/media/platform/allegro-dvt/nal-hevc.h | 189 +++++++++++++++++++++++++++++++++++++++--- include/uapi/linux/v4l2-controls.h | 5 ++ 8 files changed, 811 insertions(+), 203 deletions(-)
Comments
From: builder@linuxtv.org
Pull request: https://patchwork.linuxtv.org/project/linux-media/patch/710cddfc-e3c3-0cf3-d2f9-c38ef6ca8b1a@xs4all.nl/
Build log: https://builder.linuxtv.org/job/patchwork/147010/
Build time: 00:41:54
Link: https://lore.kernel.org/linux-media/710cddfc-e3c3-0cf3-d2f9-c38ef6ca8b1a@xs4all.nl
gpg: Signature made Mon 11 Oct 2021 08:44:58 AM UTC
gpg: using RSA key AAA7FFBA4D2D77EF4CAEA1421326E0CD23ABDCE5
gpg: Good signature from "Hans Verkuil <hverkuil-cisco@xs4all.nl>" [unknown]
gpg: aka "Hans Verkuil <hverkuil@xs4all.nl>" [unknown]
gpg: Note: This key has expired!
Primary key fingerprint: 052C DE7B C215 053B 689F 1BCA BD2D 6148 6614 3B4C
Subkey fingerprint: AAA7 FFBA 4D2D 77EF 4CAE A142 1326 E0CD 23AB DCE5
Summary: got 5/13 patches with issues, being 5 at build time, plus one error when buinding PDF document
Error/warnings:
patches/0001-media-allegro-ignore-interrupt-if-mailbox-is-not-ini.patch:
allyesconfig: return code #0:
../scripts/genksyms/parse.y: warning: 9 shift/reduce conflicts [-Wconflicts-sr]
../scripts/genksyms/parse.y: warning: 5 reduce/reduce conflicts [-Wconflicts-rr]
../scripts/genksyms/parse.y: note: rerun with option '-Wcounterexamples' to generate conflict counterexamples
allyesconfig: return code #0:
../drivers/media/cec/core/cec-adap.c: ../drivers/media/cec/core/cec-adap.c:926 cec_transmit_msg_fh() warn: '&data->list' not removed from list
../drivers/media/rc/meson-ir-tx.c:22: warning: expecting prototype for meson(). Prototype was for DEVICE_NAME() instead
SPARSE:../drivers/media/rc/ir_toy.c ../drivers/media/rc/ir_toy.c:321:20: warning: incorrect type in assignment (different base types)
SPARSE:../drivers/media/rc/ir_toy.c ../drivers/media/rc/ir_toy.c:321:20: expected restricted __be16 [usertype]
SPARSE:../drivers/media/rc/ir_toy.c ../drivers/media/rc/ir_toy.c:321:20: got int
../drivers/media/pci/intel/ipu3/cio2-bridge.c:242 cio2_bridge_connect_sensor() warn: missing error code 'ret'
SMATCH:../drivers/media/usb/siano/smsusb.c ../drivers/media/usb/siano/smsusb.c:53:38: :warning: array of flexible structures
SPARSE:../drivers/media/usb/siano/smsusb.c ../drivers/media/usb/siano/smsusb.c:53:38: warning: array of flexible structures
../drivers/media/platform/qcom/venus/helpers.c: ../drivers/media/platform/qcom/venus/helpers.c:627 venus_helper_get_bufreq() error: we previously assumed 'req' could be null (see line 623)
../drivers/media/usb/pvrusb2/pvrusb2-encoder.c: ../drivers/media/usb/pvrusb2/pvrusb2-encoder.c:288 pvr2_encoder_cmd() warn: inconsistent indenting
../drivers/media/usb/pvrusb2/pvrusb2-hdw.c: ../drivers/media/usb/pvrusb2/pvrusb2-hdw.c:1730 pvr2_hdw_set_streaming() warn: inconsistent indenting
../drivers/media/usb/pvrusb2/pvrusb2-hdw.c: ../drivers/media/usb/pvrusb2/pvrusb2-hdw.c:3461 pvr2_hdw_cpufw_set_enabled() warn: inconsistent indenting
../drivers/media/usb/pvrusb2/pvrusb2-hdw.c: ../drivers/media/usb/pvrusb2/pvrusb2-hdw.c:3501 pvr2_hdw_cpufw_get() warn: inconsistent indenting
patches/0006-media-allegro-add-control-to-disable-encoder-buffer.patch:
allyesconfig: return code #0:
../drivers/media/pci/intel/ipu3/cio2-bridge.c:242 cio2_bridge_connect_sensor() warn: missing error code 'ret'
../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2625 dvb_register() parse error: turning off implications after 60 seconds
../drivers/media/usb/pvrusb2/pvrusb2-encoder.c: ../drivers/media/usb/pvrusb2/pvrusb2-encoder.c:288 pvr2_encoder_cmd() warn: inconsistent indenting
../drivers/media/platform/qcom/venus/helpers.c: ../drivers/media/platform/qcom/venus/helpers.c:627 venus_helper_get_bufreq() error: we previously assumed 'req' could be null (see line 623)
../drivers/media/usb/pvrusb2/pvrusb2-hdw.c: ../drivers/media/usb/pvrusb2/pvrusb2-hdw.c:1730 pvr2_hdw_set_streaming() warn: inconsistent indenting
../drivers/media/usb/pvrusb2/pvrusb2-hdw.c: ../drivers/media/usb/pvrusb2/pvrusb2-hdw.c:3461 pvr2_hdw_cpufw_set_enabled() warn: inconsistent indenting
../drivers/media/usb/pvrusb2/pvrusb2-hdw.c: ../drivers/media/usb/pvrusb2/pvrusb2-hdw.c:3501 pvr2_hdw_cpufw_get() warn: inconsistent indenting
../drivers/media/usb/em28xx/em28xx-video.c: ../drivers/media/usb/em28xx/em28xx-video.c:2900 em28xx_v4l2_init() parse error: turning off implications after 60 seconds
checkpatch.pl:
$ cat patches/0006-media-allegro-add-control-to-disable-encoder-buffer.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict
-:115: CHECK: Alignment should match open parenthesis
patches/0010-media-allegro-extract-nal-value-lookup-functions-to-.patch:
allyesconfig: return code #512:
In file included from ../drivers/media/platform/allegro-dvt/nal-hevc.c:24:
../drivers/media/platform/allegro-dvt/nal-hevc.h:416:30: error: ‘enum v4l2_quantization’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
../drivers/media/platform/allegro-dvt/nal-hevc.h:417:40: error: ‘enum v4l2_colorspace’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
../drivers/media/platform/allegro-dvt/nal-hevc.h:419:14: error: ‘enum v4l2_xfer_func’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
../drivers/media/platform/allegro-dvt/nal-hevc.h:418:49: error: ‘enum v4l2_colorspace’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
../drivers/media/platform/allegro-dvt/nal-hevc.h:421:10: error: ‘enum v4l2_ycbcr_encoding’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
../drivers/media/platform/allegro-dvt/nal-hevc.h:420:38: error: ‘enum v4l2_colorspace’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
cc1: all warnings being treated as errors
make[5]: *** [../scripts/Makefile.build:277: drivers/media/platform/allegro-dvt/nal-hevc.o] Error 1
make[5]: *** Waiting for unfinished jobs....
make[4]: *** [../scripts/Makefile.build:540: drivers/media/platform/allegro-dvt] Error 2
make[3]: *** [../scripts/Makefile.build:540: drivers/media/platform] Error 2
make[2]: *** [../scripts/Makefile.build:540: drivers/media] Error 2
make[1]: *** [/var/lib/jenkins/workspace/patchwork/Makefile:1868: drivers] Error 2
make: *** [Makefile:219: __sub-make] Error 2
allmodconfig: return code #512:
In file included from ../drivers/media/platform/allegro-dvt/nal-hevc.c:24:
../drivers/media/platform/allegro-dvt/nal-hevc.h:416:30: error: ‘enum v4l2_quantization’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
../drivers/media/platform/allegro-dvt/nal-hevc.h:417:40: error: ‘enum v4l2_colorspace’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
../drivers/media/platform/allegro-dvt/nal-hevc.h:419:14: error: ‘enum v4l2_xfer_func’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
../drivers/media/platform/allegro-dvt/nal-hevc.h:418:49: error: ‘enum v4l2_colorspace’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
../drivers/media/platform/allegro-dvt/nal-hevc.h:421:10: error: ‘enum v4l2_ycbcr_encoding’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
../drivers/media/platform/allegro-dvt/nal-hevc.h:420:38: error: ‘enum v4l2_colorspace’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
cc1: all warnings being treated as errors
make[5]: *** [../scripts/Makefile.build:277: drivers/media/platform/allegro-dvt/nal-hevc.o] Error 1
make[5]: *** Waiting for unfinished jobs....
make[4]: *** [../scripts/Makefile.build:540: drivers/media/platform/allegro-dvt] Error 2
make[3]: *** [../scripts/Makefile.build:540: drivers/media/platform] Error 2
make[2]: *** [../scripts/Makefile.build:540: drivers/media] Error 2
make[1]: *** [/var/lib/jenkins/workspace/patchwork/Makefile:1868: drivers] Error 2
make: *** [Makefile:219: __sub-make] Error 2
patches/0011-media-allegro-write-correct-colorspace-into-SPS.patch:
allyesconfig: return code #512:
In file included from ../drivers/media/platform/allegro-dvt/nal-hevc.c:24:
../drivers/media/platform/allegro-dvt/nal-hevc.h:416:30: error: ‘enum v4l2_quantization’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
../drivers/media/platform/allegro-dvt/nal-hevc.h:417:40: error: ‘enum v4l2_colorspace’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
../drivers/media/platform/allegro-dvt/nal-hevc.h:419:14: error: ‘enum v4l2_xfer_func’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
../drivers/media/platform/allegro-dvt/nal-hevc.h:418:49: error: ‘enum v4l2_colorspace’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
../drivers/media/platform/allegro-dvt/nal-hevc.h:421:10: error: ‘enum v4l2_ycbcr_encoding’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
../drivers/media/platform/allegro-dvt/nal-hevc.h:420:38: error: ‘enum v4l2_colorspace’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
cc1: all warnings being treated as errors
make[5]: *** [../scripts/Makefile.build:277: drivers/media/platform/allegro-dvt/nal-hevc.o] Error 1
make[5]: *** Waiting for unfinished jobs....
make[4]: *** [../scripts/Makefile.build:540: drivers/media/platform/allegro-dvt] Error 2
make[3]: *** [../scripts/Makefile.build:540: drivers/media/platform] Error 2
make[2]: *** [../scripts/Makefile.build:540: drivers/media] Error 2
make[1]: *** [/var/lib/jenkins/workspace/patchwork/Makefile:1868: drivers] Error 2
make: *** [Makefile:219: __sub-make] Error 2
allmodconfig: return code #512:
In file included from ../drivers/media/platform/allegro-dvt/nal-hevc.c:24:
../drivers/media/platform/allegro-dvt/nal-hevc.h:416:30: error: ‘enum v4l2_quantization’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
../drivers/media/platform/allegro-dvt/nal-hevc.h:417:40: error: ‘enum v4l2_colorspace’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
../drivers/media/platform/allegro-dvt/nal-hevc.h:419:14: error: ‘enum v4l2_xfer_func’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
../drivers/media/platform/allegro-dvt/nal-hevc.h:418:49: error: ‘enum v4l2_colorspace’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
../drivers/media/platform/allegro-dvt/nal-hevc.h:421:10: error: ‘enum v4l2_ycbcr_encoding’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
../drivers/media/platform/allegro-dvt/nal-hevc.h:420:38: error: ‘enum v4l2_colorspace’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
cc1: all warnings being treated as errors
make[5]: *** [../scripts/Makefile.build:277: drivers/media/platform/allegro-dvt/nal-hevc.o] Error 1
make[5]: *** Waiting for unfinished jobs....
make[4]: *** [../scripts/Makefile.build:540: drivers/media/platform/allegro-dvt] Error 2
make[3]: *** [../scripts/Makefile.build:540: drivers/media/platform] Error 2
make[2]: *** [../scripts/Makefile.build:540: drivers/media] Error 2
make[1]: *** [/var/lib/jenkins/workspace/patchwork/Makefile:1868: drivers] Error 2
make: *** [Makefile:219: __sub-make] Error 2
patches/0012-media-allegro-nal-hevc-implement-generator-for-vui.patch:
allyesconfig: return code #512:
In file included from ../drivers/media/platform/allegro-dvt/nal-hevc.c:24:
../drivers/media/platform/allegro-dvt/nal-hevc.h:416:30: error: ‘enum v4l2_quantization’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
../drivers/media/platform/allegro-dvt/nal-hevc.h:417:40: error: ‘enum v4l2_colorspace’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
../drivers/media/platform/allegro-dvt/nal-hevc.h:419:14: error: ‘enum v4l2_xfer_func’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
../drivers/media/platform/allegro-dvt/nal-hevc.h:418:49: error: ‘enum v4l2_colorspace’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
../drivers/media/platform/allegro-dvt/nal-hevc.h:421:10: error: ‘enum v4l2_ycbcr_encoding’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
../drivers/media/platform/allegro-dvt/nal-hevc.h:420:38: error: ‘enum v4l2_colorspace’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
cc1: all warnings being treated as errors
make[5]: *** [../scripts/Makefile.build:277: drivers/media/platform/allegro-dvt/nal-hevc.o] Error 1
make[4]: *** [../scripts/Makefile.build:540: drivers/media/platform/allegro-dvt] Error 2
make[3]: *** [../scripts/Makefile.build:540: drivers/media/platform] Error 2
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [../scripts/Makefile.build:540: drivers/media] Error 2
make[1]: *** [/var/lib/jenkins/workspace/patchwork/Makefile:1868: drivers] Error 2
make: *** [Makefile:219: __sub-make] Error 2
allmodconfig: return code #512:
In file included from ../drivers/media/platform/allegro-dvt/nal-hevc.c:24:
../drivers/media/platform/allegro-dvt/nal-hevc.h:416:30: error: ‘enum v4l2_quantization’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
../drivers/media/platform/allegro-dvt/nal-hevc.h:417:40: error: ‘enum v4l2_colorspace’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
../drivers/media/platform/allegro-dvt/nal-hevc.h:419:14: error: ‘enum v4l2_xfer_func’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
../drivers/media/platform/allegro-dvt/nal-hevc.h:418:49: error: ‘enum v4l2_colorspace’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
../drivers/media/platform/allegro-dvt/nal-hevc.h:421:10: error: ‘enum v4l2_ycbcr_encoding’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
../drivers/media/platform/allegro-dvt/nal-hevc.h:420:38: error: ‘enum v4l2_colorspace’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
cc1: all warnings being treated as errors
make[5]: *** [../scripts/Makefile.build:277: drivers/media/platform/allegro-dvt/nal-hevc.o] Error 1
make[4]: *** [../scripts/Makefile.build:540: drivers/media/platform/allegro-dvt] Error 2
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [../scripts/Makefile.build:540: drivers/media/platform] Error 2
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [../scripts/Makefile.build:540: drivers/media] Error 2
make[1]: *** [/var/lib/jenkins/workspace/patchwork/Makefile:1868: drivers] Error 2
make: *** [Makefile:219: __sub-make] Error 2
Error #512 when building PDF docs
Em Mon, 11 Oct 2021 10:49:14 +0200 Hans Verkuil <hverkuil@xs4all.nl> escreveu: > The following changes since commit fd2eda71a47b095e81b9170c3f8b7ae82b04e785: > > media: remove myself from dvb media maintainers (2021-10-08 13:56:25 +0200) > > are available in the Git repository at: > > git://linuxtv.org/hverkuil/media_tree.git tags/br-v5.16i > > for you to fetch changes up to 8f472ea73758255b366fae57bde772396231efcd: > > media: allegro: write vui parameters for HEVC (2021-10-11 10:18:33 +0200) > > ---------------------------------------------------------------- > Tag branch > > ---------------------------------------------------------------- > Michael Tretter (13): > media: allegro: ignore interrupt if mailbox is not initialized > media: allegro: fix module removal if initialization failed > media: allegro: lookup VCU settings > media: allegro: add pm_runtime support > media: allegro: add encoder buffer support > media: allegro: add control to disable encoder buffer > media: allegro: fix row and column in response message > media: allegro: remove external QP table > media: allegro: correctly scale the bit rate in SPS > media: allegro: extract nal value lookup functions to header > media: allegro: write correct colorspace into SPS > media: allegro: nal-hevc: implement generator for vui > media: allegro: write vui parameters for HEVC Jenkins is reporting compilation breakage when -Werror is turned on: patches/0010-media-allegro-extract-nal-value-lookup-functions-to-.patch: allyesconfig: return code #512: In file included from ../drivers/media/platform/allegro-dvt/nal-hevc.c:24: ../drivers/media/platform/allegro-dvt/nal-hevc.h:416:30: error: ‘enum v4l2_quantization’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror] ../drivers/media/platform/allegro-dvt/nal-hevc.h:417:40: error: ‘enum v4l2_colorspace’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror] ../drivers/media/platform/allegro-dvt/nal-hevc.h:419:14: error: ‘enum v4l2_xfer_func’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror] ../drivers/media/platform/allegro-dvt/nal-hevc.h:418:49: error: ‘enum v4l2_colorspace’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror] ../drivers/media/platform/allegro-dvt/nal-hevc.h:421:10: error: ‘enum v4l2_ycbcr_encoding’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror] ../drivers/media/platform/allegro-dvt/nal-hevc.h:420:38: error: ‘enum v4l2_colorspace’ declared inside parameter list will not be visible Are there any missing include? Regards, Mauro
Hi Mauro, On 18/10/2021 10:40, Mauro Carvalho Chehab wrote: > Em Mon, 11 Oct 2021 10:49:14 +0200 > Hans Verkuil <hverkuil@xs4all.nl> escreveu: > >> The following changes since commit fd2eda71a47b095e81b9170c3f8b7ae82b04e785: >> >> media: remove myself from dvb media maintainers (2021-10-08 13:56:25 +0200) >> >> are available in the Git repository at: >> >> git://linuxtv.org/hverkuil/media_tree.git tags/br-v5.16i >> >> for you to fetch changes up to 8f472ea73758255b366fae57bde772396231efcd: >> >> media: allegro: write vui parameters for HEVC (2021-10-11 10:18:33 +0200) >> >> ---------------------------------------------------------------- >> Tag branch >> >> ---------------------------------------------------------------- >> Michael Tretter (13): >> media: allegro: ignore interrupt if mailbox is not initialized >> media: allegro: fix module removal if initialization failed >> media: allegro: lookup VCU settings >> media: allegro: add pm_runtime support >> media: allegro: add encoder buffer support >> media: allegro: add control to disable encoder buffer >> media: allegro: fix row and column in response message >> media: allegro: remove external QP table >> media: allegro: correctly scale the bit rate in SPS >> media: allegro: extract nal value lookup functions to header >> media: allegro: write correct colorspace into SPS >> media: allegro: nal-hevc: implement generator for vui >> media: allegro: write vui parameters for HEVC > > Jenkins is reporting compilation breakage when -Werror is turned on: > > patches/0010-media-allegro-extract-nal-value-lookup-functions-to-.patch: > > allyesconfig: return code #512: > In file included from ../drivers/media/platform/allegro-dvt/nal-hevc.c:24: > ../drivers/media/platform/allegro-dvt/nal-hevc.h:416:30: error: ‘enum v4l2_quantization’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror] > ../drivers/media/platform/allegro-dvt/nal-hevc.h:417:40: error: ‘enum v4l2_colorspace’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror] > ../drivers/media/platform/allegro-dvt/nal-hevc.h:419:14: error: ‘enum v4l2_xfer_func’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror] > ../drivers/media/platform/allegro-dvt/nal-hevc.h:418:49: error: ‘enum v4l2_colorspace’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror] > ../drivers/media/platform/allegro-dvt/nal-hevc.h:421:10: error: ‘enum v4l2_ycbcr_encoding’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror] > ../drivers/media/platform/allegro-dvt/nal-hevc.h:420:38: error: ‘enum v4l2_colorspace’ declared inside parameter list will not be visible > > Are there any missing include? Ah, the next two patches add the necessary videodev2.h includes. I've fixed up the patch series to add videodev2.h to this patch instead of later patches, and will post a new PR soon. Michael, no need for you to do anything. Regards, Hans > > Regards, > Mauro >