[OMAPZOOM] CAM: Make PACK8 mode on CCDC work only with CCIR-656

Message ID 5e9665e10903011822i5afbf588x8e9fc9596d94519a@mail.gmail.com (mailing list archive)
State Superseded, archived
Headers

Commit Message

DongSoo Kim March 2, 2009, 2:22 a.m. UTC
  Hello,

Besides the patch I've posted couple of hours ago, there is one more
thing in omap3 ispccdc.c.
According to omap3 datasheet, PACK8 could be enabled only when
CCDC_SYN_MODE is with CCIR-656 mode.
If you try to use external camera module with ITU-R.601 mode without
this patch, you could face weird data from your camera interface.
Please find following patch, and any comments will be welcomed.

Cheers,

Nate

From 23425c97233c93f9b572351d8a93a13ae3cb3188 Mon Sep 17 00:00:00 2001
From: Dongsoo Kim <dongsoo45.kim@samsung.com>
Date: Mon, 2 Mar 2009 11:01:14 +0900
Subject: [PATCH 2/2] CAM: Make PACK8 mode on CCDC work only with CCIR-656
 Signed-off-by: Dongsoo Kim <dongsoo45.kim@samsung.com>

---
 drivers/media/video/isp/ispccdc.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
  

Patch

diff --git a/drivers/media/video/isp/ispccdc.c
b/drivers/media/video/isp/ispccdc.c
index 8f7e896..2945c6f 100644
--- a/drivers/media/video/isp/ispccdc.c
+++ b/drivers/media/video/isp/ispccdc.c
@@ -762,7 +762,8 @@  void ispccdc_config_sync_if(struct ispccdc_syncif syncif)
 	switch (syncif.datsz) {
 	case DAT8:
 		syn_mode |= ISPCCDC_SYN_MODE_DATSIZ_8;
-		syn_mode |= ISPCCDC_SYN_MODE_PACK8; /* Added by MMS */
+		if (syncif.bt_r656_en)
+			syn_mode |= ISPCCDC_SYN_MODE_PACK8; /* Added by MMS */
 		break;
 	case DAT10:
 		syn_mode |= ISPCCDC_SYN_MODE_DATSIZ_10;