[GIT,PULL,FOR,3.13] Exynos5 SoC FIMC-IS imaging subsystem driver
Message ID | 5261967E.6010001@samsung.com (mailing list archive) |
---|---|
State | Superseded, archived |
Headers |
Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from <linux-media-owner@vger.kernel.org>) id 1VXGQs-0000hZ-1M; Fri, 18 Oct 2013 22:14:02 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-8) with esmtp id 1VXGQp-00069C-lk; Fri, 18 Oct 2013 22:14:01 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757128Ab3JRUN5 (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Fri, 18 Oct 2013 16:13:57 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:32712 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753413Ab3JRUN5 (ORCPT <rfc822;linux-media@vger.kernel.org>); Fri, 18 Oct 2013 16:13:57 -0400 Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout3.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MUV00537S76B430@mailout3.w1.samsung.com> for linux-media@vger.kernel.org; Fri, 18 Oct 2013 21:13:54 +0100 (BST) X-AuditID: cbfec7f5-b7ef66d00000795a-fc-52619682346d Received: from eusync2.samsung.com ( [203.254.199.212]) by eucpsbgm2.samsung.com (EUCPMTA) with SMTP id FA.4F.31066.28691625; Fri, 18 Oct 2013 21:13:54 +0100 (BST) Received: from [106.116.147.32] by eusync2.samsung.com (Oracle Communications Messaging Server 7u4-23.01(7.0.4.23.0) 64bit (built Aug 10 2011)) with ESMTPA id <0MUV006J0S76DL50@eusync2.samsung.com> for linux-media@vger.kernel.org; Fri, 18 Oct 2013 21:13:54 +0100 (BST) Message-id: <5261967E.6010001@samsung.com> Date: Fri, 18 Oct 2013 22:13:50 +0200 From: Sylwester Nawrocki <s.nawrocki@samsung.com> User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0 MIME-version: 1.0 To: LMML <linux-media@vger.kernel.org> Subject: [GIT PULL FOR 3.13] Exynos5 SoC FIMC-IS imaging subsystem driver Content-type: text/plain; charset=ISO-8859-1 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrGJMWRmVeSWpSXmKPExsVy+t/xK7pN0xKDDM4/Fbfo2bCV1YHR4/Mm uQDGKC6blNSczLLUIn27BK6M/etzC25rV1y/f4algfGgShcjJ4eEgInE+gn/GSFsMYkL99az dTFycQgJLGWU2LDsJjuEM4lJYu75tawgVbwCWhKrL7Wzg9gsAqoS866sZwax2QQMJXqP9oFN EhUIkzja9BOqXlDix+R7LCC2iICaxJpFk4B6OTiEBTwlvnaEgYSZBXQk9rdOY4Ow5SU2r3nL PIGRdxaS7llIymYhKVvAyLyKUTS1NLmgOCk910ivODG3uDQvXS85P3cTIyRsvu5gXHrM6hCj AAejEg9vh01ikBBrYllxZe4hRgkOZiUR3jeVQCHelMTKqtSi/Pii0pzU4kOMTBycUg2MiZfc PNZ9WPFZ/eH0hOaZOTe/1wgkTmC6+O0E37I9Zaz++h8XxKhe/WFYck4n+7hWpnLrzLD/hwUF zQL3GKZtLzV4MntpwBn3z1ZG1320JZ5XP73KV3rj1i5LTt+D0Zv+X/47wUPt7WmR+bMXf3wt /EZ0ldCNWzzPXD7NisxY6tzW6v5kYiiHkhJLcUaioRZzUXEiAHeLD/L5AQAA Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2013.10.18.200316 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' HTML_00_01 0.05, HTML_00_10 0.05, BODY_SIZE_5000_5999 0, BODY_SIZE_7000_LESS 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_MEDIA_BODY 0, __CP_URI_IN_BODY 0, __CT 0, __CTE 0, __CT_TEXT_PLAIN 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __MOZILLA_MSGID 0, __MOZILLA_USER_AGENT 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __URI_NO_WWW 0, __URI_NS , __USER_AGENT 0' |
Pull-request
git://linuxtv.org/snawrocki/samsung.git for-v3.13-2Message
Sylwester Nawrocki
Oct. 18, 2013, 8:13 p.m. UTC
Hi Mauro, This change set is V4L2 driver for the Exynos5 series camera subsystem. There is also included a minimal driver for the s5k4e5 image sensor. The FIMC-IS driver is pretty huge, even though there are some hardware similarities between FIMC-IS found on Exynos5 and Exynos4 SoCs, the firmwares are significantly different, which makes writing a common driver not quite sensible. Anyway some of the exynos4 subdevs are already reused and some further code consolidation will likely be possible. The following changes since commit 8ca5d2d8e58df7235b77ed435e63c484e123fede: [media] uvcvideo: Fix data type for pan/tilt control (2013-10-17 06:55:29 -0300) are available in the git repository at: git://linuxtv.org/snawrocki/samsung.git for-v3.13-2 for you to fetch changes up to 6eb89d71b27e6731755ab5722f3cdc0f6e8273f2: V4L: Add s5k4e5 sensor driver (2013-10-18 21:36:42 +0200) ---------------------------------------------------------------- Arun Kumar K (12): exynos5-fimc-is: Add Exynos5 FIMC-IS device tree bindings documentation exynos5-fimc-is: Add driver core files exynos5-fimc-is: Add common driver header files exynos5-fimc-is: Add register definition and context header exynos5-fimc-is: Add isp subdev exynos5-fimc-is: Add scaler subdev exynos5-fimc-is: Add sensor interface exynos5-fimc-is: Add the hardware pipeline control exynos5-fimc-is: Add the hardware interface module exynos5-is: Add Kconfig and Makefile V4L: Add DT binding doc for s5k4e5 image sensor V4L: Add s5k4e5 sensor driver Shaik Ameer Basha (1): exynos5-is: Add media device driver for exynos5 SoCs camera subsystem .../devicetree/bindings/media/exynos5-fimc-is.txt | 84 + .../bindings/media/exynos5250-camera.txt | 126 ++ .../devicetree/bindings/media/samsung-s5k4e5.txt | 45 + drivers/media/i2c/Kconfig | 8 + drivers/media/i2c/Makefile | 1 + drivers/media/i2c/s5k4e5.c | 344 ++++ drivers/media/platform/Kconfig | 1 + drivers/media/platform/Makefile | 1 + drivers/media/platform/exynos5-is/Kconfig | 20 + drivers/media/platform/exynos5-is/Makefile | 7 + drivers/media/platform/exynos5-is/exynos5-mdev.c | 1210 ++++++++++++++ drivers/media/platform/exynos5-is/exynos5-mdev.h | 126 ++ drivers/media/platform/exynos5-is/fimc-is-cmd.h | 187 +++ drivers/media/platform/exynos5-is/fimc-is-core.c | 410 +++++ drivers/media/platform/exynos5-is/fimc-is-core.h | 132 ++ drivers/media/platform/exynos5-is/fimc-is-err.h | 257 +++ .../media/platform/exynos5-is/fimc-is-interface.c | 810 ++++++++++ .../media/platform/exynos5-is/fimc-is-interface.h | 124 ++ drivers/media/platform/exynos5-is/fimc-is-isp.c | 534 ++++++ drivers/media/platform/exynos5-is/fimc-is-isp.h | 90 ++ .../media/platform/exynos5-is/fimc-is-metadata.h | 767 +++++++++ drivers/media/platform/exynos5-is/fimc-is-param.h | 1159 +++++++++++++ .../media/platform/exynos5-is/fimc-is-pipeline.c | 1699 ++++++++++++++++++++ .../media/platform/exynos5-is/fimc-is-pipeline.h | 129 ++ drivers/media/platform/exynos5-is/fimc-is-regs.h | 105 ++ drivers/media/platform/exynos5-is/fimc-is-scaler.c | 476 ++++++ drivers/media/platform/exynos5-is/fimc-is-scaler.h | 106 ++ drivers/media/platform/exynos5-is/fimc-is-sensor.c | 45 + drivers/media/platform/exynos5-is/fimc-is-sensor.h | 65 + drivers/media/platform/exynos5-is/fimc-is.h | 160 ++ 30 files changed, 9228 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/exynos5-fimc-is.txt create mode 100644 Documentation/devicetree/bindings/media/exynos5250-camera.txt create mode 100644 Documentation/devicetree/bindings/media/samsung-s5k4e5.txt create mode 100644 drivers/media/i2c/s5k4e5.c create mode 100644 drivers/media/platform/exynos5-is/Kconfig create mode 100644 drivers/media/platform/exynos5-is/Makefile create mode 100644 drivers/media/platform/exynos5-is/exynos5-mdev.c create mode 100644 drivers/media/platform/exynos5-is/exynos5-mdev.h create mode 100644 drivers/media/platform/exynos5-is/fimc-is-cmd.h create mode 100644 drivers/media/platform/exynos5-is/fimc-is-core.c create mode 100644 drivers/media/platform/exynos5-is/fimc-is-core.h create mode 100644 drivers/media/platform/exynos5-is/fimc-is-err.h create mode 100644 drivers/media/platform/exynos5-is/fimc-is-interface.c create mode 100644 drivers/media/platform/exynos5-is/fimc-is-interface.h create mode 100644 drivers/media/platform/exynos5-is/fimc-is-isp.c create mode 100644 drivers/media/platform/exynos5-is/fimc-is-isp.h create mode 100644 drivers/media/platform/exynos5-is/fimc-is-metadata.h create mode 100644 drivers/media/platform/exynos5-is/fimc-is-param.h create mode 100644 drivers/media/platform/exynos5-is/fimc-is-pipeline.c create mode 100644 drivers/media/platform/exynos5-is/fimc-is-pipeline.h create mode 100644 drivers/media/platform/exynos5-is/fimc-is-regs.h create mode 100644 drivers/media/platform/exynos5-is/fimc-is-scaler.c create mode 100644 drivers/media/platform/exynos5-is/fimc-is-scaler.h create mode 100644 drivers/media/platform/exynos5-is/fimc-is-sensor.c create mode 100644 drivers/media/platform/exynos5-is/fimc-is-sensor.h create mode 100644 drivers/media/platform/exynos5-is/fimc-is.h -- Thanks, Sylwester -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Comments
Hi Sylwester, Em Fri, 18 Oct 2013 22:13:50 +0200 Sylwester Nawrocki <s.nawrocki@samsung.com> escreveu: > Hi Mauro, > > This change set is V4L2 driver for the Exynos5 series camera subsystem. > There is also included a minimal driver for the s5k4e5 image sensor. > > The FIMC-IS driver is pretty huge, even though there are some hardware > similarities between FIMC-IS found on Exynos5 and Exynos4 SoCs, the firmwares > are significantly different, which makes writing a common driver not quite > sensible. > Anyway some of the exynos4 subdevs are already reused and some further code > consolidation will likely be possible. > > The following changes since commit 8ca5d2d8e58df7235b77ed435e63c484e123fede: > > [media] uvcvideo: Fix data type for pan/tilt control (2013-10-17 06:55:29 -0300) > > are available in the git repository at: > > git://linuxtv.org/snawrocki/samsung.git for-v3.13-2 > > for you to fetch changes up to 6eb89d71b27e6731755ab5722f3cdc0f6e8273f2: > > V4L: Add s5k4e5 sensor driver (2013-10-18 21:36:42 +0200) > > ---------------------------------------------------------------- > Arun Kumar K (12): > exynos5-fimc-is: Add Exynos5 FIMC-IS device tree bindings documentation As agreed during KS, the subsystem maintainers should wait for a documentation review on DT by the DT maintainers, at least for a while. So, I'd like to see either their reviews on this patch: https://patchwork.linuxtv.org/patch/20439/ Or their ack for us to apply it. > exynos5-fimc-is: Add driver core files > exynos5-fimc-is: Add common driver header files > exynos5-fimc-is: Add register definition and context header > exynos5-fimc-is: Add isp subdev > exynos5-fimc-is: Add scaler subdev > exynos5-fimc-is: Add sensor interface > exynos5-fimc-is: Add the hardware pipeline control > exynos5-fimc-is: Add the hardware interface module > exynos5-is: Add Kconfig and Makefile > V4L: Add DT binding doc for s5k4e5 image sensor Same applies to this patch: https://patchwork.linuxtv.org/patch/20448/ Grant, I'd appreciate if you could fast track those, as there are lots of code depending on them. Regards, Mauro > V4L: Add s5k4e5 sensor driver > > Shaik Ameer Basha (1): > exynos5-is: Add media device driver for exynos5 SoCs camera subsystem > > .../devicetree/bindings/media/exynos5-fimc-is.txt | 84 + > .../bindings/media/exynos5250-camera.txt | 126 ++ > .../devicetree/bindings/media/samsung-s5k4e5.txt | 45 + > drivers/media/i2c/Kconfig | 8 + > drivers/media/i2c/Makefile | 1 + > drivers/media/i2c/s5k4e5.c | 344 ++++ > drivers/media/platform/Kconfig | 1 + > drivers/media/platform/Makefile | 1 + > drivers/media/platform/exynos5-is/Kconfig | 20 + > drivers/media/platform/exynos5-is/Makefile | 7 + > drivers/media/platform/exynos5-is/exynos5-mdev.c | 1210 ++++++++++++++ > drivers/media/platform/exynos5-is/exynos5-mdev.h | 126 ++ > drivers/media/platform/exynos5-is/fimc-is-cmd.h | 187 +++ > drivers/media/platform/exynos5-is/fimc-is-core.c | 410 +++++ > drivers/media/platform/exynos5-is/fimc-is-core.h | 132 ++ > drivers/media/platform/exynos5-is/fimc-is-err.h | 257 +++ > .../media/platform/exynos5-is/fimc-is-interface.c | 810 ++++++++++ > .../media/platform/exynos5-is/fimc-is-interface.h | 124 ++ > drivers/media/platform/exynos5-is/fimc-is-isp.c | 534 ++++++ > drivers/media/platform/exynos5-is/fimc-is-isp.h | 90 ++ > .../media/platform/exynos5-is/fimc-is-metadata.h | 767 +++++++++ > drivers/media/platform/exynos5-is/fimc-is-param.h | 1159 +++++++++++++ > .../media/platform/exynos5-is/fimc-is-pipeline.c | 1699 ++++++++++++++++++++ > .../media/platform/exynos5-is/fimc-is-pipeline.h | 129 ++ > drivers/media/platform/exynos5-is/fimc-is-regs.h | 105 ++ > drivers/media/platform/exynos5-is/fimc-is-scaler.c | 476 ++++++ > drivers/media/platform/exynos5-is/fimc-is-scaler.h | 106 ++ > drivers/media/platform/exynos5-is/fimc-is-sensor.c | 45 + > drivers/media/platform/exynos5-is/fimc-is-sensor.h | 65 + > drivers/media/platform/exynos5-is/fimc-is.h | 160 ++ > 30 files changed, 9228 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/exynos5-fimc-is.txt > create mode 100644 Documentation/devicetree/bindings/media/exynos5250-camera.txt > create mode 100644 Documentation/devicetree/bindings/media/samsung-s5k4e5.txt > create mode 100644 drivers/media/i2c/s5k4e5.c > create mode 100644 drivers/media/platform/exynos5-is/Kconfig > create mode 100644 drivers/media/platform/exynos5-is/Makefile > create mode 100644 drivers/media/platform/exynos5-is/exynos5-mdev.c > create mode 100644 drivers/media/platform/exynos5-is/exynos5-mdev.h > create mode 100644 drivers/media/platform/exynos5-is/fimc-is-cmd.h > create mode 100644 drivers/media/platform/exynos5-is/fimc-is-core.c > create mode 100644 drivers/media/platform/exynos5-is/fimc-is-core.h > create mode 100644 drivers/media/platform/exynos5-is/fimc-is-err.h > create mode 100644 drivers/media/platform/exynos5-is/fimc-is-interface.c > create mode 100644 drivers/media/platform/exynos5-is/fimc-is-interface.h > create mode 100644 drivers/media/platform/exynos5-is/fimc-is-isp.c > create mode 100644 drivers/media/platform/exynos5-is/fimc-is-isp.h > create mode 100644 drivers/media/platform/exynos5-is/fimc-is-metadata.h > create mode 100644 drivers/media/platform/exynos5-is/fimc-is-param.h > create mode 100644 drivers/media/platform/exynos5-is/fimc-is-pipeline.c > create mode 100644 drivers/media/platform/exynos5-is/fimc-is-pipeline.h > create mode 100644 drivers/media/platform/exynos5-is/fimc-is-regs.h > create mode 100644 drivers/media/platform/exynos5-is/fimc-is-scaler.c > create mode 100644 drivers/media/platform/exynos5-is/fimc-is-scaler.h > create mode 100644 drivers/media/platform/exynos5-is/fimc-is-sensor.c > create mode 100644 drivers/media/platform/exynos5-is/fimc-is-sensor.h > create mode 100644 drivers/media/platform/exynos5-is/fimc-is.h > > -- > Thanks, > Sylwester > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Mauro, On 10/28/2013 11:11 PM, Mauro Carvalho Chehab wrote: >> The following changes since commit 8ca5d2d8e58df7235b77ed435e63c484e123fede: >> > >> > [media] uvcvideo: Fix data type for pan/tilt control (2013-10-17 06:55:29 -0300) >> > >> > are available in the git repository at: >> > >> > git://linuxtv.org/snawrocki/samsung.git for-v3.13-2 >> > >> > for you to fetch changes up to 6eb89d71b27e6731755ab5722f3cdc0f6e8273f2: >> > >> > V4L: Add s5k4e5 sensor driver (2013-10-18 21:36:42 +0200) >> > >> > ---------------------------------------------------------------- >> > Arun Kumar K (12): >> > exynos5-fimc-is: Add Exynos5 FIMC-IS device tree bindings documentation > > As agreed during KS, the subsystem maintainers should wait for a documentation > review on DT by the DT maintainers, at least for a while. > > So, I'd like to see either their reviews on this patch: > https://patchwork.linuxtv.org/patch/20439/ > > Or their ack for us to apply it. I agree with you on that. Just please note the first version of this patch has been posted *5 months* ago https://patchwork.linuxtv.org/patch/18684 Stephen has reviewed subsequent version about 3 months ago: https://patchwork.linuxtv.org/patch/19521 Then we got no more comments from DT maintainers, I have reviewed this patch multiple times on the mailing lists: https://patchwork.linuxtv.org/patch/19715 https://patchwork.linuxtv.org/patch/19749 And explicitly asked for an Ack: https://patchwork.linuxtv.org/patch/19832 Then those 2 versions passed silently: https://patchwork.linuxtv.org/patch/20055 https://patchwork.linuxtv.org/patch/20225 And...huh...we got another review, I didn't notice it until now: https://patchwork.linuxtv.org/patch/20439 Thanks Mark. Arun, care to address those review comments and send us an updated binding documentation patch ? Hence I think we have waited for a while. ;) >> > exynos5-fimc-is: Add driver core files >> > exynos5-fimc-is: Add common driver header files >> > exynos5-fimc-is: Add register definition and context header >> > exynos5-fimc-is: Add isp subdev >> > exynos5-fimc-is: Add scaler subdev >> > exynos5-fimc-is: Add sensor interface >> > exynos5-fimc-is: Add the hardware pipeline control >> > exynos5-fimc-is: Add the hardware interface module >> > exynos5-is: Add Kconfig and Makefile >> > V4L: Add DT binding doc for s5k4e5 image sensor > > Same applies to this patch: > https://patchwork.linuxtv.org/patch/20448/ This one also have been on the mailing list for quite some time and it uses already standard bindings, so I assumed it is OK to merge it. https://patchwork.linuxtv.org/project/linux-media/list/?state=*&q=s5k4e5 But if there must be an Ack then we shall wait, it will probably won't make a big difference now, if this patch is postponed by 3 more months. -- Thanks, Sylwester -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Em Tue, 29 Oct 2013 01:06:30 +0100 Sylwester Nawrocki <sylvester.nawrocki@gmail.com> escreveu: > Hi Mauro, > > On 10/28/2013 11:11 PM, Mauro Carvalho Chehab wrote: > >> The following changes since commit 8ca5d2d8e58df7235b77ed435e63c484e123fede: > >> > > >> > [media] uvcvideo: Fix data type for pan/tilt control (2013-10-17 06:55:29 -0300) > >> > > >> > are available in the git repository at: > >> > > >> > git://linuxtv.org/snawrocki/samsung.git for-v3.13-2 > >> > > >> > for you to fetch changes up to 6eb89d71b27e6731755ab5722f3cdc0f6e8273f2: > >> > > >> > V4L: Add s5k4e5 sensor driver (2013-10-18 21:36:42 +0200) > >> > > >> > ---------------------------------------------------------------- > >> > Arun Kumar K (12): > >> > exynos5-fimc-is: Add Exynos5 FIMC-IS device tree bindings documentation > > > > As agreed during KS, the subsystem maintainers should wait for a documentation > > review on DT by the DT maintainers, at least for a while. > > > > So, I'd like to see either their reviews on this patch: > > https://patchwork.linuxtv.org/patch/20439/ > > > > Or their ack for us to apply it. > > I agree with you on that. Just please note the first version of this patch > has been posted *5 months* ago https://patchwork.linuxtv.org/patch/18684 > > Stephen has reviewed subsequent version about 3 months ago: > https://patchwork.linuxtv.org/patch/19521 > > Then we got no more comments from DT maintainers, I have reviewed this patch > multiple times on the mailing lists: > https://patchwork.linuxtv.org/patch/19715 > https://patchwork.linuxtv.org/patch/19749 > > And explicitly asked for an Ack: > https://patchwork.linuxtv.org/patch/19832 > > Then those 2 versions passed silently: > https://patchwork.linuxtv.org/patch/20055 > https://patchwork.linuxtv.org/patch/20225 > > And...huh...we got another review, I didn't notice it until now: > https://patchwork.linuxtv.org/patch/20439 Thanks Mark. > > Arun, care to address those review comments and send us an updated > binding documentation patch ? > > Hence I think we have waited for a while. ;) > > >> > exynos5-fimc-is: Add driver core files > >> > exynos5-fimc-is: Add common driver header files > >> > exynos5-fimc-is: Add register definition and context header > >> > exynos5-fimc-is: Add isp subdev > >> > exynos5-fimc-is: Add scaler subdev > >> > exynos5-fimc-is: Add sensor interface > >> > exynos5-fimc-is: Add the hardware pipeline control > >> > exynos5-fimc-is: Add the hardware interface module > >> > exynos5-is: Add Kconfig and Makefile > >> > V4L: Add DT binding doc for s5k4e5 image sensor > > > > Same applies to this patch: > > https://patchwork.linuxtv.org/patch/20448/ > > This one also have been on the mailing list for quite some time and it > uses already standard bindings, so I assumed it is OK to merge it. > > https://patchwork.linuxtv.org/project/linux-media/list/?state=*&q=s5k4e5 > > But if there must be an Ack then we shall wait, it will probably won't > make a big difference now, if this patch is postponed by 3 more months. Yeah, it seems that we've waited for a long time to get an ack there. So, let's do this: Please send a new version with Mark's comments. Also, please split Doc changes from the code changes on the new series. I'll wait for a couple days for DT people to review it. If we don't have any reply, I'll review and apply it for Kernel 3.13, if I don't see anything really weird on it. Regards, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 10/29/2013 01:54 PM, Mauro Carvalho Chehab wrote: [...] > Yeah, it seems that we've waited for a long time to get an ack there. > > So, let's do this: > > Please send a new version with Mark's comments. Also, please split Doc > changes from the code changes on the new series. I'll wait for a couple > days for DT people to review it. If we don't have any reply, I'll review > and apply it for Kernel 3.13, if I don't see anything really weird on it. Ok, I will make sure all DT binding documentation is in separate patches, actually only one patch needs to be reworked. Since Mark already reviewed the FIMC-IS and the S5K4E5 image sensor DT binding patches the only one which may need further review is this one: https://patchwork.linuxtv.org/patch/20237 Arun, could you send us the updated series ? Unfortunately I might not be able to find time to address those comments myself until Friday. -- Thanks, Sylwester -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Sylwester, Sorry for the delayed response as I was on leave. I will address the comments from Mark today itself and post those DT binding patches. Regards Arun On Wed, Oct 30, 2013 at 5:48 AM, Sylwester Nawrocki <sylvester.nawrocki@gmail.com> wrote: > On 10/29/2013 01:54 PM, Mauro Carvalho Chehab wrote: > [...] > >> Yeah, it seems that we've waited for a long time to get an ack there. >> >> So, let's do this: >> >> Please send a new version with Mark's comments. Also, please split Doc >> changes from the code changes on the new series. I'll wait for a couple >> days for DT people to review it. If we don't have any reply, I'll review >> and apply it for Kernel 3.13, if I don't see anything really weird on it. > > > Ok, I will make sure all DT binding documentation is in separate patches, > actually only one patch needs to be reworked. > > Since Mark already reviewed the FIMC-IS and the S5K4E5 image sensor DT > binding patches the only one which may need further review is this one: > https://patchwork.linuxtv.org/patch/20237 > > Arun, could you send us the updated series ? Unfortunately I might not be > able to find time to address those comments myself until Friday. > > -- > Thanks, > Sylwester > > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 05/11/13 05:21, Arun Kumar K wrote: > Hi Sylwester, > > Sorry for the delayed response as I was on leave. > I will address the comments from Mark today itself and post those DT > binding patches. Hi Arun, Thanks, could you also split this patch [1] in two so the DT binding documentation and the driver are separate and resend it ? Regards, Sylwester [1] http://git.linuxtv.org/snawrocki/samsung.git/commit/4e4cf315ebf98f2553f32cbfe21789126c4ec22c -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Sylwester, Ok will resend the media-dev patch after splitting. Thanks Arun On Tue, Nov 5, 2013 at 3:48 PM, Sylwester Nawrocki <s.nawrocki@samsung.com> wrote: > On 05/11/13 05:21, Arun Kumar K wrote: >> Hi Sylwester, >> >> Sorry for the delayed response as I was on leave. >> I will address the comments from Mark today itself and post those DT >> binding patches. > > Hi Arun, > > Thanks, could you also split this patch [1] in two so the DT > binding documentation and the driver are separate and resend it ? > > Regards, > Sylwester > > [1] > http://git.linuxtv.org/snawrocki/samsung.git/commit/4e4cf315ebf98f2553f32cbfe21789126c4ec22c -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html