cx88: increase BUFFER_TIMEOUT to 2 seconds

Message ID 5013801372b14e3d1439.1267028616@roadrunner.athome (mailing list archive)
State Superseded, archived
Headers

Commit Message

Marton Balint Feb. 24, 2010, 4:23 p.m. UTC
  # HG changeset patch
# User Marton Balint <cus@fazekas.hu>
# Date 1267027831 -3600
# Node ID 5013801372b14e3d143955c04108d450323eb2de
# Parent  2e0444bf93a4a93e5e9363d43e6f6e9d451fa9bc
cx88: increase BUFFER_TIMEOUT to 2 seconds

From: Marton Balint <cus@fazekas.hu>

When temporarily there is no video signal, sometimes it takes more than 0.5
secs for the cx88 chip to generate a single frame. If a dma timeout occurs
during recording, it confuses the recording application (at least mencoder) and
the recording stops. Since there is already an ifdefed-out 2 second buffer
timeout in the code, re-enabling that seemed the most simple solution.

Priority: normal

Signed-off-by: Marton Balint <cus@fazekas.hu>

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
  

Patch

diff -r 2e0444bf93a4 -r 5013801372b1 linux/drivers/media/video/cx88/cx88.h
--- a/linux/drivers/media/video/cx88/cx88.h	Mon Feb 22 10:58:43 2010 -0300
+++ b/linux/drivers/media/video/cx88/cx88.h	Wed Feb 24 17:10:31 2010 +0100
@@ -290,10 +290,7 @@ 
 #define RESOURCE_VIDEO         2
 #define RESOURCE_VBI           4
 
-#define BUFFER_TIMEOUT     msecs_to_jiffies(500)  /* 0.5 seconds */
-#if 0
 #define BUFFER_TIMEOUT     msecs_to_jiffies(2000)
-#endif
 
 /* buffer for one video frame */
 struct cx88_buffer {