Message ID | 4d2efa85-5801-092e-f3ca-c6053f612891@xs4all.nl (mailing list archive) |
---|---|
State | Accepted, archived |
Headers |
Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from <linux-media-owner@vger.kernel.org>) id 1mPgbc-008DAW-HF; Mon, 13 Sep 2021 07:42:20 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237653AbhIMHnd (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Mon, 13 Sep 2021 03:43:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36402 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237568AbhIMHnc (ORCPT <rfc822;linux-media@vger.kernel.org>); Mon, 13 Sep 2021 03:43:32 -0400 Received: from lb2-smtp-cloud7.xs4all.net (lb2-smtp-cloud7.xs4all.net [IPv6:2001:888:0:108::2a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D8D4DC061574 for <linux-media@vger.kernel.org>; Mon, 13 Sep 2021 00:42:16 -0700 (PDT) Received: from cust-b5b5937f ([IPv6:fc0c:c16d:66b8:757f:c639:739b:9d66:799d]) by smtp-cloud7.xs4all.net with ESMTPA id PgbSmWawopQdWPgbTm1pK2; Mon, 13 Sep 2021 09:42:13 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xs4all.nl; s=s2; t=1631518933; bh=CYDupfBiELasArrXgz/nUAe5qjVajVV5s9Gjrj6V3BU=; h=To:From:Subject:Message-ID:Date:MIME-Version:Content-Type:From: Subject; b=s8SILm86afmwUm7R/cNcDtfIgdG5eaIvqi4ogm8x66Z3yIn15ulNU1rAbis1KaQWQ c7d9PCpDx5up4ArODX3wwlafuVJGlhB/dEuHlXFgJtJk3W+XJgHJU/HTKwho8C/sSa sGJXXLk8Xq09RekBvC9aITnzl5laMyPqd1QwCqVEtKefjlGHRFK73eIjvl/bpdXId3 tyxZaEcl8vNgSOBzwS2w/RZXNwAMMJvcx5eqf9ss3jlDFM5F2jR3ixo72GLuaAjnfo AKwe60I+mc80G1pt9MNx6kOTM4tmOUm5uryBiZ+IH8HoUGdtQGsydusIevx9g3R+jz hRcc/dM9cQRfQ== To: Linux Media Mailing List <linux-media@vger.kernel.org> Cc: Sergey Senozhatsky <senozhatsky@chromium.org> From: Hans Verkuil <hverkuil@xs4all.nl> Subject: [GIT PULL FOR v5.16] videobuf2: support new noncontiguous DMA API Message-ID: <4d2efa85-5801-092e-f3ca-c6053f612891@xs4all.nl> Date: Mon, 13 Sep 2021 09:42:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4xfDYL3YHAwdMg6bVEnsqSNTGAzhuIOd/+VPZWpm2Xjh6ejWpeQ4EiBos31DBM0c9LnltukMbqXGGmccDN1ddAuWglxQ2tn9ZCq11G3S0iSUikbNtcfew0 HSZeKPUT62lxAooa+LBUnR2DeivTd+UsHLkEQsB34bVFgO6PKmzSEDK10ZsOBhRF5X+520FrAmZ1f9P+zPD0OM72HGdeNOJgIPOIlpDlxnom5q/Tm9b6kXqV DbYG3AmhdthPzL1JdLPvMc/3r0DnES7QLFs57wFE+EjYckCn02c4H3kGsZuSUpo/X8U68XimQwlhdnbACkatLY4TIWwHr8EbAosFtmpoZSM= Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -4.8 (----) X-LSpam-Report: No, score=-4.8 required=5.0 tests=BAYES_00=-1.9,DKIMWL_WL_MED=0.001,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1,RCVD_IN_DNSWL_MED=-2.3 autolearn=ham autolearn_force=no |
Series |
[GIT,PULL,FOR,v5.16] videobuf2: support new noncontiguous DMA API
|
|
Pull-request
git://linuxtv.org/hverkuil/media_tree.git tags/br-v5.16dMessage
Hans Verkuil
Sept. 13, 2021, 7:42 a.m. UTC
Hi Mauro, This patch series that adds support for V4L2_MEMORY_FLAG_NON_COHERENT. Once merged, this patch for v4l2-compliance will be applied as well: https://patchwork.linuxtv.org/project/linux-media/patch/20210913023546.905914-1-senozhatsky@chromium.org/ Regards, Hans The following changes since commit d62cd4d277cc711f781a7bdec4109c6148529b25: media: uvcvideo: Remove unused including <linux/version.h> (2021-08-21 09:11:04 +0200) are available in the Git repository at: git://linuxtv.org/hverkuil/media_tree.git tags/br-v5.16d for you to fetch changes up to fa03153716a3e6bf10d8611515fdcf440673557a: videobuf2: handle non-contiguous DMA allocations (2021-09-10 12:06:25 +0200) ---------------------------------------------------------------- Tag branch ---------------------------------------------------------------- Sergey Senozhatsky (8): videobuf2: rework vb2_mem_ops API videobuf2: inverse buffer cache_hints flags videobuf2: split buffer cache_hints initialisation videobuf2: move cache_hints handling to allocators videobuf2: add V4L2_MEMORY_FLAG_NON_COHERENT flag videobuf2: add queue memory coherency parameter videobuf2: handle V4L2_MEMORY_FLAG_NON_COHERENT flag videobuf2: handle non-contiguous DMA allocations Documentation/userspace-api/media/v4l/buffer.rst | 40 ++++++++- Documentation/userspace-api/media/v4l/vidioc-create-bufs.rst | 7 +- Documentation/userspace-api/media/v4l/vidioc-reqbufs.rst | 16 ++-- drivers/media/common/videobuf2/videobuf2-core.c | 126 +++++++++++++++++---------- drivers/media/common/videobuf2/videobuf2-dma-contig.c | 195 +++++++++++++++++++++++++++++++++--------- drivers/media/common/videobuf2/videobuf2-dma-sg.c | 39 +++++---- drivers/media/common/videobuf2/videobuf2-v4l2.c | 59 ++++++------- drivers/media/common/videobuf2/videobuf2-vmalloc.c | 30 ++++--- drivers/media/dvb-core/dvb_vb2.c | 2 +- drivers/media/v4l2-core/v4l2-compat-ioctl32.c | 9 +- drivers/media/v4l2-core/v4l2-ioctl.c | 4 +- include/media/videobuf2-core.h | 59 +++++++------ include/uapi/linux/videodev2.h | 11 ++- 13 files changed, 411 insertions(+), 186 deletions(-)
Comments
From: builder@linuxtv.org
Pull request: https://patchwork.linuxtv.org/project/linux-media/patch/4d2efa85-5801-092e-f3ca-c6053f612891@xs4all.nl/
Build log: https://builder.linuxtv.org/job/patchwork/138988/
Build time: 00:15:40
Link: https://lore.kernel.org/linux-media/4d2efa85-5801-092e-f3ca-c6053f612891@xs4all.nl
gpg: Signature made Mon 13 Sep 2021 07:32:25 AM UTC
gpg: using RSA key AAA7FFBA4D2D77EF4CAEA1421326E0CD23ABDCE5
gpg: Good signature from "Hans Verkuil <hverkuil-cisco@xs4all.nl>" [unknown]
gpg: aka "Hans Verkuil <hverkuil@xs4all.nl>" [unknown]
gpg: Note: This key has expired!
Primary key fingerprint: 052C DE7B C215 053B 689F 1BCA BD2D 6148 6614 3B4C
Subkey fingerprint: AAA7 FFBA 4D2D 77EF 4CAE A142 1326 E0CD 23AB DCE5
Summary: got 5/8 patches with issues, being 5 at build time, plus one error when buinding PDF document
Error/warnings:
patches/0001-videobuf2-rework-vb2_mem_ops-API.patch:
allyesconfig: return code #0:
../scripts/genksyms/parse.y: warning: 9 shift/reduce conflicts [-Wconflicts-sr]
../scripts/genksyms/parse.y: warning: 5 reduce/reduce conflicts [-Wconflicts-rr]
../scripts/genksyms/parse.y: note: rerun with option '-Wcounterexamples' to generate conflict counterexamples
allyesconfig: return code #0:
../drivers/media/cec/core/cec-adap.c: ../drivers/media/cec/core/cec-adap.c:926 cec_transmit_msg_fh() warn: '&data->list' not removed from list
../drivers/media/rc/meson-ir-tx.c:22: warning: expecting prototype for meson(). Prototype was for DEVICE_NAME() instead
SMATCH:../drivers/media/usb/siano/smsusb.c ../drivers/media/usb/siano/smsusb.c:53:38: :warning: array of flexible structures
SPARSE:../drivers/media/usb/siano/smsusb.c ../drivers/media/usb/siano/smsusb.c:53:38: warning: array of flexible structures
../drivers/media/test-drivers/vivid/vivid-core.c: ../drivers/media/test-drivers/vivid/vivid-core.c:1981 vivid_create_instance() parse error: turning off implications after 60 seconds
../drivers/media/usb/em28xx/em28xx-video.c: ../drivers/media/usb/em28xx/em28xx-video.c:2868 em28xx_v4l2_init() parse error: turning off implications after 60 seconds
checkpatch.pl:
$ cat patches/0001-videobuf2-rework-vb2_mem_ops-API.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict
-:41: CHECK: Macro argument reuse 'op' - possible side-effects?
-:41: CHECK: Macro argument reuse 'vb' - possible side-effects?
-:57: CHECK: Macro argument reuse 'op' - possible side-effects?
-:57: CHECK: Macro argument 'op' may be better as '(op)' to avoid precedence issues
-:57: CHECK: Macro argument reuse 'vb' - possible side-effects?
patches/0002-videobuf2-inverse-buffer-cache_hints-flags.patch:
allyesconfig: return code #0:
../drivers/media/test-drivers/vivid/vivid-core.c: ../drivers/media/test-drivers/vivid/vivid-core.c:1981 vivid_create_instance() parse error: turning off implications after 60 seconds
../drivers/media/usb/em28xx/em28xx-video.c: ../drivers/media/usb/em28xx/em28xx-video.c:2888 em28xx_v4l2_init() parse error: turning off implications after 60 seconds
patches/0005-videobuf2-add-V4L2_MEMORY_FLAG_NON_COHERENT-flag.patch:
allyesconfig: return code #0:
../drivers/media/test-drivers/vivid/vivid-core.c: ../drivers/media/test-drivers/vivid/vivid-core.c:1981 vivid_create_instance() parse error: turning off implications after 60 seconds
../drivers/media/usb/em28xx/em28xx-video.c: ../drivers/media/usb/em28xx/em28xx-video.c:2900 em28xx_v4l2_init() parse error: turning off implications after 60 seconds
patches/0006-videobuf2-add-queue-memory-coherency-parameter.patch:
allyesconfig: return code #0:
../drivers/media/test-drivers/vivid/vivid-core.c: ../drivers/media/test-drivers/vivid/vivid-core.c:1981 vivid_create_instance() parse error: turning off implications after 60 seconds
../drivers/media/usb/em28xx/em28xx-video.c: ../drivers/media/usb/em28xx/em28xx-video.c:2874 em28xx_v4l2_init() parse error: turning off implications after 60 seconds
patches/0007-videobuf2-handle-V4L2_MEMORY_FLAG_NON_COHERENT-flag.patch:
allyesconfig: return code #0:
../drivers/media/usb/em28xx/em28xx-video.c: ../drivers/media/usb/em28xx/em28xx-video.c:2868 em28xx_v4l2_init() parse error: turning off implications after 60 seconds
../drivers/media/test-drivers/vivid/vivid-core.c: ../drivers/media/test-drivers/vivid/vivid-core.c:1981 vivid_create_instance() parse error: turning off implications after 60 seconds
Error #512 when building PDF docs