[GIT,PULL,FOR,v5.16] videobuf2: support new noncontiguous DMA API

Message ID 4d2efa85-5801-092e-f3ca-c6053f612891@xs4all.nl (mailing list archive)
State Accepted, archived
Headers
Series [GIT,PULL,FOR,v5.16] videobuf2: support new noncontiguous DMA API |

Pull-request

git://linuxtv.org/hverkuil/media_tree.git tags/br-v5.16d

Message

Hans Verkuil Sept. 13, 2021, 7:42 a.m. UTC
  Hi Mauro,

This patch series that adds support for V4L2_MEMORY_FLAG_NON_COHERENT.

Once merged, this patch for v4l2-compliance will be applied as well:

https://patchwork.linuxtv.org/project/linux-media/patch/20210913023546.905914-1-senozhatsky@chromium.org/

Regards,

	Hans


The following changes since commit d62cd4d277cc711f781a7bdec4109c6148529b25:

  media: uvcvideo: Remove unused including <linux/version.h> (2021-08-21 09:11:04 +0200)

are available in the Git repository at:

  git://linuxtv.org/hverkuil/media_tree.git tags/br-v5.16d

for you to fetch changes up to fa03153716a3e6bf10d8611515fdcf440673557a:

  videobuf2: handle non-contiguous DMA allocations (2021-09-10 12:06:25 +0200)

----------------------------------------------------------------
Tag branch

----------------------------------------------------------------
Sergey Senozhatsky (8):
      videobuf2: rework vb2_mem_ops API
      videobuf2: inverse buffer cache_hints flags
      videobuf2: split buffer cache_hints initialisation
      videobuf2: move cache_hints handling to allocators
      videobuf2: add V4L2_MEMORY_FLAG_NON_COHERENT flag
      videobuf2: add queue memory coherency parameter
      videobuf2: handle V4L2_MEMORY_FLAG_NON_COHERENT flag
      videobuf2: handle non-contiguous DMA allocations

 Documentation/userspace-api/media/v4l/buffer.rst             |  40 ++++++++-
 Documentation/userspace-api/media/v4l/vidioc-create-bufs.rst |   7 +-
 Documentation/userspace-api/media/v4l/vidioc-reqbufs.rst     |  16 ++--
 drivers/media/common/videobuf2/videobuf2-core.c              | 126 +++++++++++++++++----------
 drivers/media/common/videobuf2/videobuf2-dma-contig.c        | 195 +++++++++++++++++++++++++++++++++---------
 drivers/media/common/videobuf2/videobuf2-dma-sg.c            |  39 +++++----
 drivers/media/common/videobuf2/videobuf2-v4l2.c              |  59 ++++++-------
 drivers/media/common/videobuf2/videobuf2-vmalloc.c           |  30 ++++---
 drivers/media/dvb-core/dvb_vb2.c                             |   2 +-
 drivers/media/v4l2-core/v4l2-compat-ioctl32.c                |   9 +-
 drivers/media/v4l2-core/v4l2-ioctl.c                         |   4 +-
 include/media/videobuf2-core.h                               |  59 +++++++------
 include/uapi/linux/videodev2.h                               |  11 ++-
 13 files changed, 411 insertions(+), 186 deletions(-)
  

Comments

Jenkins Sept. 13, 2021, 9:05 a.m. UTC | #1
From: builder@linuxtv.org

Pull request: https://patchwork.linuxtv.org/project/linux-media/patch/4d2efa85-5801-092e-f3ca-c6053f612891@xs4all.nl/
Build log: https://builder.linuxtv.org/job/patchwork/138988/
Build time: 00:15:40
Link: https://lore.kernel.org/linux-media/4d2efa85-5801-092e-f3ca-c6053f612891@xs4all.nl

gpg: Signature made Mon 13 Sep 2021 07:32:25 AM UTC
gpg:                using RSA key AAA7FFBA4D2D77EF4CAEA1421326E0CD23ABDCE5
gpg: Good signature from "Hans Verkuil <hverkuil-cisco@xs4all.nl>" [unknown]
gpg:                 aka "Hans Verkuil <hverkuil@xs4all.nl>" [unknown]
gpg: Note: This key has expired!
Primary key fingerprint: 052C DE7B C215 053B 689F  1BCA BD2D 6148 6614 3B4C
     Subkey fingerprint: AAA7 FFBA 4D2D 77EF 4CAE  A142 1326 E0CD 23AB DCE5

Summary: got 5/8 patches with issues, being 5 at build time, plus one error when buinding PDF document

Error/warnings:

patches/0001-videobuf2-rework-vb2_mem_ops-API.patch:

    allyesconfig: return code #0:
	../scripts/genksyms/parse.y: warning: 9 shift/reduce conflicts [-Wconflicts-sr]
	../scripts/genksyms/parse.y: warning: 5 reduce/reduce conflicts [-Wconflicts-rr]
	../scripts/genksyms/parse.y: note: rerun with option '-Wcounterexamples' to generate conflict counterexamples

    allyesconfig: return code #0:
	../drivers/media/cec/core/cec-adap.c: ../drivers/media/cec/core/cec-adap.c:926 cec_transmit_msg_fh() warn: '&data->list' not removed from list
	../drivers/media/rc/meson-ir-tx.c:22: warning: expecting prototype for meson(). Prototype was for DEVICE_NAME() instead
	SMATCH:../drivers/media/usb/siano/smsusb.c ../drivers/media/usb/siano/smsusb.c:53:38: :warning: array of flexible structures
	SPARSE:../drivers/media/usb/siano/smsusb.c ../drivers/media/usb/siano/smsusb.c:53:38: warning: array of flexible structures
	../drivers/media/test-drivers/vivid/vivid-core.c: ../drivers/media/test-drivers/vivid/vivid-core.c:1981 vivid_create_instance() parse error: turning off implications after 60 seconds
	../drivers/media/usb/em28xx/em28xx-video.c: ../drivers/media/usb/em28xx/em28xx-video.c:2868 em28xx_v4l2_init() parse error: turning off implications after 60 seconds

   checkpatch.pl:
	$ cat patches/0001-videobuf2-rework-vb2_mem_ops-API.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict
	-:41: CHECK: Macro argument reuse 'op' - possible side-effects?
	-:41: CHECK: Macro argument reuse 'vb' - possible side-effects?
	-:57: CHECK: Macro argument reuse 'op' - possible side-effects?
	-:57: CHECK: Macro argument 'op' may be better as '(op)' to avoid precedence issues
	-:57: CHECK: Macro argument reuse 'vb' - possible side-effects?

patches/0002-videobuf2-inverse-buffer-cache_hints-flags.patch:

    allyesconfig: return code #0:
	../drivers/media/test-drivers/vivid/vivid-core.c: ../drivers/media/test-drivers/vivid/vivid-core.c:1981 vivid_create_instance() parse error: turning off implications after 60 seconds
	../drivers/media/usb/em28xx/em28xx-video.c: ../drivers/media/usb/em28xx/em28xx-video.c:2888 em28xx_v4l2_init() parse error: turning off implications after 60 seconds

patches/0005-videobuf2-add-V4L2_MEMORY_FLAG_NON_COHERENT-flag.patch:

    allyesconfig: return code #0:
	../drivers/media/test-drivers/vivid/vivid-core.c: ../drivers/media/test-drivers/vivid/vivid-core.c:1981 vivid_create_instance() parse error: turning off implications after 60 seconds
	../drivers/media/usb/em28xx/em28xx-video.c: ../drivers/media/usb/em28xx/em28xx-video.c:2900 em28xx_v4l2_init() parse error: turning off implications after 60 seconds

patches/0006-videobuf2-add-queue-memory-coherency-parameter.patch:

    allyesconfig: return code #0:
	../drivers/media/test-drivers/vivid/vivid-core.c: ../drivers/media/test-drivers/vivid/vivid-core.c:1981 vivid_create_instance() parse error: turning off implications after 60 seconds
	../drivers/media/usb/em28xx/em28xx-video.c: ../drivers/media/usb/em28xx/em28xx-video.c:2874 em28xx_v4l2_init() parse error: turning off implications after 60 seconds

patches/0007-videobuf2-handle-V4L2_MEMORY_FLAG_NON_COHERENT-flag.patch:

    allyesconfig: return code #0:
	../drivers/media/usb/em28xx/em28xx-video.c: ../drivers/media/usb/em28xx/em28xx-video.c:2868 em28xx_v4l2_init() parse error: turning off implications after 60 seconds
	../drivers/media/test-drivers/vivid/vivid-core.c: ../drivers/media/test-drivers/vivid/vivid-core.c:1981 vivid_create_instance() parse error: turning off implications after 60 seconds


Error #512 when building PDF docs