Message ID | 4B69D83D.5050809@arcor.de (mailing list archive) |
---|---|
State | Superseded, archived |
Headers |
Return-path: <linux-media-owner@vger.kernel.org> Envelope-to: mchehab@infradead.org Delivery-date: Wed, 03 Feb 2010 20:11:23 +0000 Received: from bombadil.infradead.org [18.85.46.34] by pedra with IMAP (fetchmail-6.3.6) for <mchehab@localhost> (single-drop); Wed, 03 Feb 2010 18:12:25 -0200 (BRST) Received: from vger.kernel.org ([209.132.180.67]) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1NclZL-0005di-Be; Wed, 03 Feb 2010 20:11:23 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757844Ab0BCULN (ORCPT <rfc822; kmpark@infradead.org> + 1 other); Wed, 3 Feb 2010 15:11:13 -0500 Received: from mail-in-11.arcor-online.net ([151.189.21.51]:56517 "EHLO mail-in-11.arcor-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757840Ab0BCULL (ORCPT <rfc822;linux-media@vger.kernel.org>); Wed, 3 Feb 2010 15:11:11 -0500 Received: from mail-in-11-z2.arcor-online.net (mail-in-11-z2.arcor-online.net [151.189.8.28]) by mx.arcor.de (Postfix) with ESMTP id 4B154E3ED5; Wed, 3 Feb 2010 21:11:07 +0100 (CET) Received: from mail-in-06.arcor-online.net (mail-in-06.arcor-online.net [151.189.21.46]) by mail-in-11-z2.arcor-online.net (Postfix) with ESMTP id 2C35B3470C2; Wed, 3 Feb 2010 21:11:07 +0100 (CET) Received: from [192.168.2.102] (dslb-188-103-200-201.pools.arcor-ip.net [188.103.200.201]) (Authenticated sender: stefan.ringel@arcor.de) by mail-in-06.arcor-online.net (Postfix) with ESMTPA id D1DCC39A636; Wed, 3 Feb 2010 21:11:06 +0100 (CET) X-DKIM: Sendmail DKIM Filter v2.8.2 mail-in-06.arcor-online.net D1DCC39A636 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arcor.de; s=mail-in; t=1265227867; bh=KuXDBwHCto2mCFcV6Tc6YI7zz/0rRcZF2M8blRVJbGE=; h=Message-ID:Date:From:MIME-Version:To:CC:Subject:References: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=UrRLNR3VxQjYHnjIfKBOaeUVihJT0nrYM1qNcbLxx5BI6YjFraJc0Ob3DX3bZpUhP Lu3dz33kN3Y5SgK2tllXeLhTsz4zZmR+G5TcT9TQiYWdOS9mPuMKschKj/i0DkUiOO /8hyWeUT8DLsTyAJ5WvWEDg3L3xM08pVDi8Nv+qo= Message-ID: <4B69D83D.5050809@arcor.de> Date: Wed, 03 Feb 2010 21:10:37 +0100 From: Stefan Ringel <stefan.ringel@arcor.de> User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; de; rv:1.9.1.5) Gecko/20091130 SUSE/3.0.0-1.1.1 Thunderbird/3.0 MIME-Version: 1.0 To: Mauro Carvalho Chehab <mchehab@redhat.com> CC: linux-media@vger.kernel.org, Devin Heitmueller <dheitmueller@kernellabs.com> Subject: Re: [PATCH 1/15] - tm6000 build hunk References: <4B673790.3030706@arcor.de> <4B673B2D.6040507@arcor.de> <4B675B19.3080705@redhat.com> <4B685FB9.1010805@arcor.de> <4B688507.606@redhat.com> <4B688E41.2050806@arcor.de> <4B689094.2070204@redhat.com> <4B6894FE.6010202@arcor.de> In-Reply-To: <4B6894FE.6010202@arcor.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org |
Commit Message
Stefan Ringel
Feb. 3, 2010, 8:10 p.m. UTC
Comments
Stefan Ringel wrote: OK, patch is correct, but you should: - Use the email subject to summarize what the patch does - Add more detailed patch description; - Add your Signed-off-by. In this specific case, you could have: Subject: Fix compilation breakage Signed-off-by: your name <your@email> (this is a really trivial patch - so, you don't need a detailed description) > --- a/drivers/staging/tm6000/tm6000-cards.c > +++ b/drivers/staging/tm6000/tm6000-cards.c > @@ -32,7 +32,7 @@ > #include "tm6000.h" > #include "tm6000-regs.h" > #include "tuner-xc2028.h" > -#include "tuner-xc5000.h" > +#include "xc5000.h" > > #define TM6000_BOARD_UNKNOWN 0 > #define TM5600_BOARD_GENERIC 1 >
On Wed, Feb 3, 2010 at 3:10 PM, Stefan Ringel <stefan.ringel@arcor.de> wrote: > --- a/drivers/staging/tm6000/tm6000-cards.c > +++ b/drivers/staging/tm6000/tm6000-cards.c Before you send too many of these, I should point out that there is a well-defined format expected for patches. Look here: http://linuxtv.org/wiki/index.php/Development:_How_to_submit_patches And you can see an example here: http://kernellabs.com/hg/~dheitmueller/em28xx-test/rev/42272c1dd883 Devin
--- a/drivers/staging/tm6000/tm6000-cards.c +++ b/drivers/staging/tm6000/tm6000-cards.c @@ -32,7 +32,7 @@ #include "tm6000.h" #include "tm6000-regs.h" #include "tuner-xc2028.h" -#include "tuner-xc5000.h" +#include "xc5000.h" #define TM6000_BOARD_UNKNOWN 0 #define TM5600_BOARD_GENERIC 1