diff mbox

hdpvr-video: cleanup signedness

Message ID 4B5AFD42.6080001@freemail.hu (mailing list archive)
State Superseded, archived
Headers

Commit Message

Németh Márton Jan. 23, 2010, 1:44 p.m. UTC 
  From: Márton Németh <nm127@freemail.hu>

The fifth parameter of usb_bulk_msg() is a pointer to signed
(see <linux/usb.h>) so also call this function with pointer to signed.

This will remove the following sparse warning (see "make C=1"):
 * warning: incorrect type in argument 5 (different signedness)
       expected int *actual_length
       got unsigned int *<noident>

Signed-off-by: Márton Németh <nm127@freemail.hu>
---

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Janne Grunau Feb. 3, 2010, 2:31 p.m. UTC | #1 
On Sat, Jan 23, 2010 at 02:44:34PM +0100, Németh Márton wrote:
> From: Márton Németh <nm127@freemail.hu>
> 
> The fifth parameter of usb_bulk_msg() is a pointer to signed
> (see <linux/usb.h>) so also call this function with pointer to signed.
> 
> This will remove the following sparse warning (see "make C=1"):
>  * warning: incorrect type in argument 5 (different signedness)
>        expected int *actual_length
>        got unsigned int *<noident>
> 
> Signed-off-by: Márton Németh <nm127@freemail.hu>

Thanks, I'll send a git pull request including the second patch for Mauro
later today.

cheers Janne
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff -r 2a50a0a1c951 linux/drivers/media/video/hdpvr/hdpvr-video.c
--- a/linux/drivers/media/video/hdpvr/hdpvr-video.c	Sat Jan 23 00:14:32 2010 -0200
+++ b/linux/drivers/media/video/hdpvr/hdpvr-video.c	Sat Jan 23 11:43:17 2010 +0100
@@ -302,7 +302,8 @@ 
 /* function expects dev->io_mutex to be hold by caller */
 static int hdpvr_stop_streaming(struct hdpvr_device *dev)
 {
-	uint actual_length, c = 0;
+	int actual_length;
+	uint c = 0;
 	u8 *buf;

 	if (dev->status == STATUS_IDLE)