disable building cx23885 before 2.6.33

Message ID 4B51E313.4060102@freemail.hu (mailing list archive)
State Superseded, archived
Headers

Commit Message

Németh Márton Jan. 16, 2010, 4:02 p.m. UTC
  From: Márton Németh <nm127@freemail.hu>

The cx23885 driver does not compile before Linux kernel 2.6.33 because of
incompatible fifo API changes. Disable this driver being built before
2.6.33.

Signed-off-by: Márton Németh <nm127@freemail.hu>
---

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
  

Comments

Andy Walls Jan. 16, 2010, 6:49 p.m. UTC | #1
On Sat, 2010-01-16 at 17:02 +0100, Németh Márton wrote:
> From: Márton Németh <nm127@freemail.hu>
> 
> The cx23885 driver does not compile before Linux kernel 2.6.33 because of
> incompatible fifo API changes. Disable this driver being built before
> 2.6.33.
> 
> Signed-off-by: Márton Németh <nm127@freemail.hu>

Nak.

1. You forgot meye - it's broken as well in the same way.
2. Douglas has issuesd a PULL request for a back port fix that will
resolve the issue.

Regards,
Andy

> ---
> diff -r 5bcdcc072b6d v4l/versions.txt
> --- a/v4l/versions.txt	Sat Jan 16 07:25:43 2010 +0100
> +++ b/v4l/versions.txt	Sat Jan 16 16:56:28 2010 +0100
> @@ -1,6 +1,10 @@
>  # Use this for stuff for drivers that don't compile
>  [2.6.99]
> 
> +[2.6.33]
> +# Incompatible fifo API changes, see <linux/kfifo.h>
> +VIDEO_CX23885
> +
>  [2.6.32]
>  # These rely on arch support that wasn't available until 2.6.32
>  VIDEO_SH_MOBILE_CEU
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
  

Patch

diff -r 5bcdcc072b6d v4l/versions.txt
--- a/v4l/versions.txt	Sat Jan 16 07:25:43 2010 +0100
+++ b/v4l/versions.txt	Sat Jan 16 16:56:28 2010 +0100
@@ -1,6 +1,10 @@ 
 # Use this for stuff for drivers that don't compile
 [2.6.99]

+[2.6.33]
+# Incompatible fifo API changes, see <linux/kfifo.h>
+VIDEO_CX23885
+
 [2.6.32]
 # These rely on arch support that wasn't available until 2.6.32
 VIDEO_SH_MOBILE_CEU