diff mbox

lgdt3305: make one-bit bitfields unsigned

Message ID 4B27F6F3.5000300@freemail.hu (mailing list archive)
State Superseded, archived
Headers

Commit Message

Németh Márton Dec. 15, 2009, 8:52 p.m. UTC 
  From: Márton Németh <nm127@freemail.hu>

Make one-bit bitfields unsigned which will remove the following
sparse warning messages (see "make C=1"):
 * lgdt3305.h:57:21: error: dubious one-bit signed bitfield
 * lgdt3305.h:60:26: error: dubious one-bit signed bitfield
 * lgdt3305.h:63:19: error: dubious one-bit signed bitfield

Signed-off-by: Márton Németh <nm127@freemail.hu>
---
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Michael Ira Krufky Dec. 15, 2009, 10:23 p.m. UTC | #1 
Thanks -- I'll push this in through the lgdt3305 repository... I'll send 
in a pull request to Mauro shortly.

-Mike

Németh Márton wrote:
> From: Márton Németh <nm127@freemail.hu>
>
> Make one-bit bitfields unsigned which will remove the following
> sparse warning messages (see "make C=1"):
>  * lgdt3305.h:57:21: error: dubious one-bit signed bitfield
>  * lgdt3305.h:60:26: error: dubious one-bit signed bitfield
>  * lgdt3305.h:63:19: error: dubious one-bit signed bitfield
>
> Signed-off-by: Márton Németh <nm127@freemail.hu>
> ---
> diff -r ba8d6bf077aa linux/drivers/media/dvb/frontends/lgdt3305.h
> --- a/linux/drivers/media/dvb/frontends/lgdt3305.h	Tue Dec 15 17:40:44 2009 +0100
> +++ b/linux/drivers/media/dvb/frontends/lgdt3305.h	Tue Dec 15 21:47:53 2009 +0100
> @@ -54,13 +54,13 @@
>  	u16 usref_qam256; /* default: 0x2a80 */
>
>  	/* disable i2c repeater - 0:repeater enabled 1:repeater disabled */
> -	int deny_i2c_rptr:1;
> +	unsigned int deny_i2c_rptr:1;
>
>  	/* spectral inversion - 0:disabled 1:enabled */
> -	int spectral_inversion:1;
> +	unsigned int spectral_inversion:1;
>
>  	/* use RF AGC loop - 0:disabled 1:enabled */
> -	int rf_agc_loop:1;
> +	unsigned int rf_agc_loop:1;
>
>  	enum lgdt3305_mpeg_mode mpeg_mode;
>  	enum lgdt3305_tp_clock_edge tpclk_edge;
>   

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff -r ba8d6bf077aa linux/drivers/media/dvb/frontends/lgdt3305.h
--- a/linux/drivers/media/dvb/frontends/lgdt3305.h	Tue Dec 15 17:40:44 2009 +0100
+++ b/linux/drivers/media/dvb/frontends/lgdt3305.h	Tue Dec 15 21:47:53 2009 +0100
@@ -54,13 +54,13 @@ 
 	u16 usref_qam256; /* default: 0x2a80 */

 	/* disable i2c repeater - 0:repeater enabled 1:repeater disabled */
-	int deny_i2c_rptr:1;
+	unsigned int deny_i2c_rptr:1;

 	/* spectral inversion - 0:disabled 1:enabled */
-	int spectral_inversion:1;
+	unsigned int spectral_inversion:1;

 	/* use RF AGC loop - 0:disabled 1:enabled */
-	int rf_agc_loop:1;
+	unsigned int rf_agc_loop:1;

 	enum lgdt3305_mpeg_mode mpeg_mode;
 	enum lgdt3305_tp_clock_edge tpclk_edge;