gspca m5602: eliminate sparse warnings

Message ID	4B22BAB0.5070604@freemail.hu (mailing list archive)
State	Superseded, archived
Headers	Envelope-to: mchehab@infradead.org Delivery-date: Fri, 11 Dec 2009 21:33:44 +0000 Message-ID: <4B22BAB0.5070604@freemail.hu> Date: Fri, 11 Dec 2009 22:33:36 +0100 From: =?UTF-8?B?TsOpbWV0aCBNw6FydG9u?= <nm127@freemail.hu> User-Agent: Mozilla/5.0 (X11; U; Linux i686; hu-HU; rv:1.8.1.21) Gecko/20090402 SeaMonkey/1.1.16 MIME-Version: 1.0 To: Jean-Francois Moine <moinejf@free.fr>, V4L Mailing List <linux-media@vger.kernel.org> Subject: [PATCH] gspca m5602: eliminate sparse warnings Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-DCC-mail.t-online.hu-Metrics: mail01a.mail.t-online.hu 32721; Body=2 Fuz1=2 Fuz2=2 Sender: linux-media-owner@vger.kernel.org Precedence: bulk

Message ID

4B22BAB0.5070604@freemail.hu (mailing list archive)

State

Superseded, archived

Headers

Envelope-to: mchehab@infradead.org
Delivery-date: Fri, 11 Dec 2009 21:33:44 +0000
Message-ID: <4B22BAB0.5070604@freemail.hu>
Date: Fri, 11 Dec 2009 22:33:36 +0100
From: =?UTF-8?B?TsOpbWV0aCBNw6FydG9u?= <nm127@freemail.hu>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; hu-HU;
	rv:1.8.1.21) Gecko/20090402 SeaMonkey/1.1.16
MIME-Version: 1.0
To: Jean-Francois Moine <moinejf@free.fr>,
	V4L Mailing List <linux-media@vger.kernel.org>
Subject: [PATCH] gspca m5602: eliminate sparse warnings
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-DCC-mail.t-online.hu-Metrics: mail01a.mail.t-online.hu 32721; Body=2 Fuz1=2
	Fuz2=2
Sender: linux-media-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-media.vger.kernel.org>
X-Mailing-List: linux-media@vger.kernel.org

Commit Message

Németh Márton Dec. 11, 2009, 9:33 p.m. UTC

  From: Márton Németh <nm127@freemail.hu>

Eliminate the following sparse warnings (see "make C=1"):
 * v4l/m5602_s5k4aa.c:530:23: warning: dubious: x | !y
 * v4l/m5602_s5k4aa.c:575:23: warning: dubious: x | !y

Signed-off-by: Márton Németh <nm127@freemail.hu>
---
../../m5602_s5k4aa_dubious.patch
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Jean-Francois Moine Dec. 12, 2009, 10:21 a.m. UTC | #1

On Fri, 11 Dec 2009 22:33:36 +0100
Németh Márton <nm127@freemail.hu> wrote:

> From: Márton Németh <nm127@freemail.hu>
> 
> Eliminate the following sparse warnings (see "make C=1"):
>  * v4l/m5602_s5k4aa.c:530:23: warning: dubious: x | !y
>  * v4l/m5602_s5k4aa.c:575:23: warning: dubious: x | !y
> 
> Signed-off-by: Márton Németh <nm127@freemail.hu>
> ---
> ../../m5602_s5k4aa_dubious.patch
> diff -r f5662ce08663
> linux/drivers/media/video/gspca/m5602/m5602_s5k4aa.c ---
> a/linux/drivers/media/video/gspca/m5602/m5602_s5k4aa.c	Fri Dec
> 11 09:53:41 2009 +0100 +++
> b/linux/drivers/media/video/gspca/m5602/m5602_s5k4aa.c	Fri Dec
> 11 22:25:50 2009 +0100 @@ -527,7 +527,7 @@ err =
> m5602_read_sensor(sd, S5K4AA_ROWSTART_LO, &data, 1); if (err < 0)
> return err;
> -	data = (data & 0xfe) | !val;
> +	data = (data & 0xfe) | (val ? 0 : 1);
>  	err = m5602_write_sensor(sd, S5K4AA_ROWSTART_LO, &data, 1);
>  	return err;
>  }
> @@ -572,7 +572,7 @@
>  	err = m5602_read_sensor(sd, S5K4AA_COLSTART_LO, &data, 1);
>  	if (err < 0)
>  		return err;
> -	data = (data & 0xfe) | !val;
> +	data = (data & 0xfe) | (val ? 0 : 1);
>  	err = m5602_write_sensor(sd, S5K4AA_COLSTART_LO, &data, 1);
>  	return err;
>  }

Thanks, but I fixed it in an other way.

Regards.

Németh Márton Dec. 12, 2009, 11:15 a.m. UTC | #2

Jean-Francois Moine wrote:
> On Fri, 11 Dec 2009 22:33:36 +0100
> Németh Márton <nm127@freemail.hu> wrote:
> 
>> From: Márton Németh <nm127@freemail.hu>
>>
>> Eliminate the following sparse warnings (see "make C=1"):
>>  * v4l/m5602_s5k4aa.c:530:23: warning: dubious: x | !y
>>  * v4l/m5602_s5k4aa.c:575:23: warning: dubious: x | !y
>>
>> Signed-off-by: Márton Németh <nm127@freemail.hu>
>> ---
>> ../../m5602_s5k4aa_dubious.patch
>> diff -r f5662ce08663
>> linux/drivers/media/video/gspca/m5602/m5602_s5k4aa.c ---
>> a/linux/drivers/media/video/gspca/m5602/m5602_s5k4aa.c	Fri Dec
>> 11 09:53:41 2009 +0100 +++
>> b/linux/drivers/media/video/gspca/m5602/m5602_s5k4aa.c	Fri Dec
>> 11 22:25:50 2009 +0100 @@ -527,7 +527,7 @@ err =
>> m5602_read_sensor(sd, S5K4AA_ROWSTART_LO, &data, 1); if (err < 0)
>> return err;
>> -	data = (data & 0xfe) | !val;
>> +	data = (data & 0xfe) | (val ? 0 : 1);
>>  	err = m5602_write_sensor(sd, S5K4AA_ROWSTART_LO, &data, 1);
>>  	return err;
>>  }
>> @@ -572,7 +572,7 @@
>>  	err = m5602_read_sensor(sd, S5K4AA_COLSTART_LO, &data, 1);
>>  	if (err < 0)
>>  		return err;
>> -	data = (data & 0xfe) | !val;
>> +	data = (data & 0xfe) | (val ? 0 : 1);
>>  	err = m5602_write_sensor(sd, S5K4AA_COLSTART_LO, &data, 1);
>>  	return err;
>>  }
> 
> Thanks, but I fixed it in an other way.

No problem as long as the warning message is removed.

Regards,

	Márton Németh
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

diff mbox

Patch

diff -r f5662ce08663 linux/drivers/media/video/gspca/m5602/m5602_s5k4aa.c
--- a/linux/drivers/media/video/gspca/m5602/m5602_s5k4aa.c	Fri Dec 11 09:53:41 2009 +0100
+++ b/linux/drivers/media/video/gspca/m5602/m5602_s5k4aa.c	Fri Dec 11 22:25:50 2009 +0100
@@ -527,7 +527,7 @@ 
 	err = m5602_read_sensor(sd, S5K4AA_ROWSTART_LO, &data, 1);
 	if (err < 0)
 		return err;
-	data = (data & 0xfe) | !val;
+	data = (data & 0xfe) | (val ? 0 : 1);
 	err = m5602_write_sensor(sd, S5K4AA_ROWSTART_LO, &data, 1);
 	return err;
 }
@@ -572,7 +572,7 @@ 
 	err = m5602_read_sensor(sd, S5K4AA_COLSTART_LO, &data, 1);
 	if (err < 0)
 		return err;
-	data = (data & 0xfe) | !val;
+	data = (data & 0xfe) | (val ? 0 : 1);
 	err = m5602_write_sensor(sd, S5K4AA_COLSTART_LO, &data, 1);
 	return err;
 }