Message ID | 49DB7861.5050606@oracle.com (mailing list archive) |
---|---|
State | Superseded, archived |
Headers |
Return-path: <linux-media-owner@vger.kernel.org> Envelope-to: mchehab@infradead.org Delivery-date: Tue, 07 Apr 2009 15:59:42 +0000 Received: from vger.kernel.org ([209.132.176.167]) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1LrDi9-0003Km-VV; Tue, 07 Apr 2009 15:59:42 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757999AbZDGP7j (ORCPT <rfc822; kmpark@infradead.org> + 1 other); Tue, 7 Apr 2009 11:59:39 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757912AbZDGP7j (ORCPT <rfc822;linux-media-outgoing>); Tue, 7 Apr 2009 11:59:39 -0400 Received: from acsinet12.oracle.com ([141.146.126.234]:34897 "EHLO acsinet12.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757701AbZDGP7i (ORCPT <rfc822; linux-media@vger.kernel.org>); Tue, 7 Apr 2009 11:59:38 -0400 Received: from acsinet13.oracle.com (acsinet13.oracle.com [141.146.126.235]) by acsinet12.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n37FwtQC003556 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 7 Apr 2009 15:58:56 GMT Received: from acsmt707.oracle.com (acsmt707.oracle.com [141.146.40.85]) by acsinet13.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n37Fxl8W015871; Tue, 7 Apr 2009 15:59:49 GMT Received: from [141.144.90.86] (/141.144.90.86) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 07 Apr 2009 15:59:19 +0000 Message-ID: <49DB7861.5050606@oracle.com> Date: Tue, 07 Apr 2009 08:59:29 -0700 From: Randy Dunlap <randy.dunlap@oracle.com> Organization: Oracle Linux Engineering User-Agent: Thunderbird 2.0.0.6 (X11/20070801) MIME-Version: 1.0 To: Stephen Rothwell <sfr@canb.auug.org.au> CC: linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>, linux-media@vger.kernel.org, Mauro Carvalho Chehab <mchehab@infradead.org> Subject: [PATCH -next] cx231xx: fix SND dependency build error References: <20090407140717.a7f0b07c.sfr@canb.auug.org.au> In-Reply-To: <20090407140717.a7f0b07c.sfr@canb.auug.org.au> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Source-IP: acsmt707.oracle.com [141.146.40.85] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A010205.49DB785A.0223:SCFMA4539814,ss=1,fgs=0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org |
Commit Message
Randy Dunlap
April 7, 2009, 3:59 p.m. UTC
From: Randy Dunlap <randy.dunlap@oracle.com> Don't select VIDEO_CX231XX_ALSA when SND is not enabled since selecting it won't cause SND to be enabled. ERROR: "snd_pcm_period_elapsed" [drivers/media/video/cx231xx/cx231xx-alsa.ko] undefined! ERROR: "snd_card_create" [drivers/media/video/cx231xx/cx231xx-alsa.ko] undefined! ERROR: "snd_pcm_hw_constraint_integer" [drivers/media/video/cx231xx/cx231xx-alsa.ko] undefined! ERROR: "snd_pcm_set_ops" [drivers/media/video/cx231xx/cx231xx-alsa.ko] undefined! ERROR: "snd_pcm_lib_ioctl" [drivers/media/video/cx231xx/cx231xx-alsa.ko] undefined! ERROR: "snd_card_free" [drivers/media/video/cx231xx/cx231xx-alsa.ko] undefined! ERROR: "snd_card_register" [drivers/media/video/cx231xx/cx231xx-alsa.ko] undefined! ERROR: "snd_pcm_new" [drivers/media/video/cx231xx/cx231xx-alsa.ko] undefined! Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> --- drivers/media/video/cx231xx/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Comments
On Tue, 07 Apr 2009 08:59:29 -0700 Randy Dunlap <randy.dunlap@oracle.com> wrote: > From: Randy Dunlap <randy.dunlap@oracle.com> > > Don't select VIDEO_CX231XX_ALSA when SND is not enabled since selecting it > won't cause SND to be enabled. Sorry for being late with this issue. I was fixing some upstream scripts, and we had a few holydays. The better is just to trop the select for -alsa module. I have already a fix on my tree. I'll push it later today to my linux-next git repository. > > ERROR: "snd_pcm_period_elapsed" [drivers/media/video/cx231xx/cx231xx-alsa.ko] undefined! > ERROR: "snd_card_create" [drivers/media/video/cx231xx/cx231xx-alsa.ko] undefined! > ERROR: "snd_pcm_hw_constraint_integer" [drivers/media/video/cx231xx/cx231xx-alsa.ko] undefined! > ERROR: "snd_pcm_set_ops" [drivers/media/video/cx231xx/cx231xx-alsa.ko] undefined! > ERROR: "snd_pcm_lib_ioctl" [drivers/media/video/cx231xx/cx231xx-alsa.ko] undefined! > ERROR: "snd_card_free" [drivers/media/video/cx231xx/cx231xx-alsa.ko] undefined! > ERROR: "snd_card_register" [drivers/media/video/cx231xx/cx231xx-alsa.ko] undefined! > ERROR: "snd_pcm_new" [drivers/media/video/cx231xx/cx231xx-alsa.ko] undefined! > > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> > --- > drivers/media/video/cx231xx/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- linux-next-20090407.orig/drivers/media/video/cx231xx/Kconfig > +++ linux-next-20090407/drivers/media/video/cx231xx/Kconfig > @@ -6,7 +6,7 @@ config VIDEO_CX231XX > select VIDEO_IR > select VIDEOBUF_VMALLOC > select VIDEO_CX25840 > - select VIDEO_CX231XX_ALSA > + select VIDEO_CX231XX_ALSA if SND > > ---help--- > This is a video4linux driver for Conexant 231xx USB based TV cards. > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html Cheers, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
--- linux-next-20090407.orig/drivers/media/video/cx231xx/Kconfig +++ linux-next-20090407/drivers/media/video/cx231xx/Kconfig @@ -6,7 +6,7 @@ config VIDEO_CX231XX select VIDEO_IR select VIDEOBUF_VMALLOC select VIDEO_CX25840 - select VIDEO_CX231XX_ALSA + select VIDEO_CX231XX_ALSA if SND ---help--- This is a video4linux driver for Conexant 231xx USB based TV cards.