mbox series

[GIT,PULL,FOR,v6.12] Venus updates

Message ID 20240823090438.130446-1-stanimir.k.varbanov@gmail.com (mailing list archive)
State Accepted
Delegated to: Hans Verkuil
Headers
Series [GIT,PULL,FOR,v6.12] Venus updates |

Pull-request

git://linuxtv.org/svarbanov/media_tree.git tags/tag-venus-for-v6.12

Message

Stanimir Varbanov Aug. 23, 2024, 9:04 a.m. UTC 
  Hi Hans, Mauro,

The pull request includes:
 - cocci warning/errors (Ricardo Ribalda).
 - Constify structs (Christophe JAILLET).
 - A fix for use-after-free when removing venus core module.
 - Use iommu_paging_domain_alloc() when loading firmware through IOMMU.
 - Change min iommu items in dt-binding for SC7280.

Please, pull.

regards,
~Stan

The following changes since commit 31aaa7d95e09892c81df0d7c49ae85640fa4e202:

  media: cec: cec-adap.c: improve CEC_MSG_FL_REPLY_VENDOR_ID check (2024-08-08 15:24:03 +0200)

are available in the Git repository at:

  git://linuxtv.org/svarbanov/media_tree.git tags/tag-venus-for-v6.12

for you to fetch changes up to 5c6fd86dd3b3d6f37b0d07175ce24945134856fd:

  media: dt-bindings: qcom,sc7280-venus: Allow one IOMMU entry (2024-08-23 10:46:31 +0300)

----------------------------------------------------------------
Venus updates for v6.12

----------------------------------------------------------------
Christophe JAILLET (1):
      media: venus: Constify struct dec_bufsize_ops and enc_bufsize_ops

Lu Baolu (1):
      media: venus: firmware: Use iommu_paging_domain_alloc()

Luca Weiss (1):
      media: dt-bindings: qcom,sc7280-venus: Allow one IOMMU entry

Ricardo Ribalda (9):
      media: venus: Refactor struct hfi_uncompressed_plane_info
      media: venus: Refactor struct hfi_session_get_property_pkt
      media: venus: Refactor struct hfi_uncompressed_format_supported
      media: venus: Refactor hfi_session_empty_buffer_uncompressed_plane0_pkt
      media: venus: Refactor hfi_session_empty_buffer_compressed_pkt
      media: venus: Refactor hfi_sys_get_property_pkt
      media: venus: Refactor hfi_session_fill_buffer_pkt
      media: venus: Refactor hfi_buffer_alloc_mode_supported
      media: venus: Convert one-element-arrays to flex-arrays

Zheng Wang (1):
      media: venus: fix use after free bug in venus_remove due to race condition

 .../devicetree/bindings/media/qcom,sc7280-venus.yaml |  1 +
 drivers/media/platform/qcom/venus/core.c             |  1 +
 drivers/media/platform/qcom/venus/firmware.c         |  6 +++---
 drivers/media/platform/qcom/venus/hfi_cmds.c         |  8 ++++----
 drivers/media/platform/qcom/venus/hfi_cmds.h         | 16 ++++++++--------
 drivers/media/platform/qcom/venus/hfi_helper.h       | 20 ++++++++++----------
 drivers/media/platform/qcom/venus/hfi_parser.c       |  2 +-
 drivers/media/platform/qcom/venus/hfi_plat_bufs_v6.c | 20 ++++++++++----------
 8 files changed, 38 insertions(+), 36 deletions(-)

Comments

Hans Verkuil Aug. 25, 2024, 6:29 a.m. UTC | #1 
Hi Stan,

On 23/08/2024 11:04, Stanimir Varbanov wrote:
> Hi Hans, Mauro,
> 
> The pull request includes:
>  - cocci warning/errors (Ricardo Ribalda).

Any reason why the first patch of this cocci series is missing in the PR?

https://patchwork.linuxtv.org/project/linux-media/patch/20240814-cocci-flexarray-v7-1-8a1cc09ae6c4@chromium.org/

If it is just a mistake, then I can add it.

Regards,

	Hans

>  - Constify structs (Christophe JAILLET).
>  - A fix for use-after-free when removing venus core module.
>  - Use iommu_paging_domain_alloc() when loading firmware through IOMMU.
>  - Change min iommu items in dt-binding for SC7280.
> 
> Please, pull.
> 
> regards,
> ~Stan
> 
> The following changes since commit 31aaa7d95e09892c81df0d7c49ae85640fa4e202:
> 
>   media: cec: cec-adap.c: improve CEC_MSG_FL_REPLY_VENDOR_ID check (2024-08-08 15:24:03 +0200)
> 
> are available in the Git repository at:
> 
>   git://linuxtv.org/svarbanov/media_tree.git tags/tag-venus-for-v6.12
> 
> for you to fetch changes up to 5c6fd86dd3b3d6f37b0d07175ce24945134856fd:
> 
>   media: dt-bindings: qcom,sc7280-venus: Allow one IOMMU entry (2024-08-23 10:46:31 +0300)
> 
> ----------------------------------------------------------------
> Venus updates for v6.12
> 
> ----------------------------------------------------------------
> Christophe JAILLET (1):
>       media: venus: Constify struct dec_bufsize_ops and enc_bufsize_ops
> 
> Lu Baolu (1):
>       media: venus: firmware: Use iommu_paging_domain_alloc()
> 
> Luca Weiss (1):
>       media: dt-bindings: qcom,sc7280-venus: Allow one IOMMU entry
> 
> Ricardo Ribalda (9):
>       media: venus: Refactor struct hfi_uncompressed_plane_info
>       media: venus: Refactor struct hfi_session_get_property_pkt
>       media: venus: Refactor struct hfi_uncompressed_format_supported
>       media: venus: Refactor hfi_session_empty_buffer_uncompressed_plane0_pkt
>       media: venus: Refactor hfi_session_empty_buffer_compressed_pkt
>       media: venus: Refactor hfi_sys_get_property_pkt
>       media: venus: Refactor hfi_session_fill_buffer_pkt
>       media: venus: Refactor hfi_buffer_alloc_mode_supported
>       media: venus: Convert one-element-arrays to flex-arrays
> 
> Zheng Wang (1):
>       media: venus: fix use after free bug in venus_remove due to race condition
> 
>  .../devicetree/bindings/media/qcom,sc7280-venus.yaml |  1 +
>  drivers/media/platform/qcom/venus/core.c             |  1 +
>  drivers/media/platform/qcom/venus/firmware.c         |  6 +++---
>  drivers/media/platform/qcom/venus/hfi_cmds.c         |  8 ++++----
>  drivers/media/platform/qcom/venus/hfi_cmds.h         | 16 ++++++++--------
>  drivers/media/platform/qcom/venus/hfi_helper.h       | 20 ++++++++++----------
>  drivers/media/platform/qcom/venus/hfi_parser.c       |  2 +-
>  drivers/media/platform/qcom/venus/hfi_plat_bufs_v6.c | 20 ++++++++++----------
>  8 files changed, 38 insertions(+), 36 deletions(-)
>
Stanimir Varbanov Aug. 25, 2024, 5:53 p.m. UTC | #2 
Hi Hans,

On 25.08.24 г. 9:29 ч., Hans Verkuil wrote:
> Hi Stan,
> 
> On 23/08/2024 11:04, Stanimir Varbanov wrote:
>> Hi Hans, Mauro,
>>
>> The pull request includes:
>>   - cocci warning/errors (Ricardo Ribalda).
> 
> Any reason why the first patch of this cocci series is missing in the PR?
> 
> https://patchwork.linuxtv.org/project/linux-media/patch/20240814-cocci-flexarray-v7-1-8a1cc09ae6c4@chromium.org/
> 
> If it is just a mistake, then I can add it.

It is not a mistake. Kees Cook already applied similar patch [1] and I 
have to drop it to avoid conflicts.

[1] 
https://lore.kernel.org/lkml/5a9939d7-dd05-4ce8-9231-5ae7af32b09f@linaro.org/T/