[4/4] media: cedrus: Don't require requests for all codecs

Message ID 20240731164422.206503-5-linkmauve@linkmauve.fr (mailing list archive)
State New
Delegated to: Sebastian Fricke
Headers
Series media: cedrus: Add a JPEG decoder |

Commit Message

Emmanuel Gil Peyrot July 31, 2024, 4:44 p.m. UTC
  From: Jernej Skrabec <jernej.skrabec@gmail.com>

JPEG decoding doesn’t need it currently.

Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>
---
 drivers/staging/media/sunxi/cedrus/cedrus_video.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Dan Carpenter July 31, 2024, 4:56 p.m. UTC | #1
On Wed, Jul 31, 2024 at 06:44:14PM +0200, Emmanuel Gil Peyrot wrote:
> From: Jernej Skrabec <jernej.skrabec@gmail.com>
> 
> JPEG decoding doesn’t need it currently.
> 
> Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>
> ---

Does this change have an effect on runtime?

regards,
dan carpenter
  

Patch

diff --git a/drivers/staging/media/sunxi/cedrus/cedrus_video.c b/drivers/staging/media/sunxi/cedrus/cedrus_video.c
index 7205c2315bc5..30821d81d0db 100644
--- a/drivers/staging/media/sunxi/cedrus/cedrus_video.c
+++ b/drivers/staging/media/sunxi/cedrus/cedrus_video.c
@@ -599,7 +599,7 @@  int cedrus_queue_init(void *priv, struct vb2_queue *src_vq,
 	src_vq->lock = &ctx->dev->dev_mutex;
 	src_vq->dev = ctx->dev->dev;
 	src_vq->supports_requests = true;
-	src_vq->requires_requests = true;
+	src_vq->requires_requests = false;
 
 	ret = vb2_queue_init(src_vq);
 	if (ret)