usb: uvc: add missing MODULE_DESCRIPTION() macro

Message ID 20240612-md-drivers-media-common-v1-1-b5603c85f629@quicinc.com (mailing list archive)
State Accepted
Delegated to: Hans Verkuil
Headers
Series usb: uvc: add missing MODULE_DESCRIPTION() macro |

Commit Message

Jeff Johnson June 12, 2024, 11:58 p.m. UTC
  With ARCH=arm64, make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/common/uvc.o

Add the missing invocation of the MODULE_DESCRIPTION() macro.

Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
 drivers/media/common/uvc.c | 1 +
 1 file changed, 1 insertion(+)


---
base-commit: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670
change-id: 20240612-md-drivers-media-common-01f67d64768a
  

Comments

Kieran Bingham June 13, 2024, 1:04 a.m. UTC | #1
Quoting Jeff Johnson (2024-06-13 00:58:59)
> With ARCH=arm64, make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/common/uvc.o
> 
> Add the missing invocation of the MODULE_DESCRIPTION() macro.
> 
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> ---
>  drivers/media/common/uvc.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/common/uvc.c b/drivers/media/common/uvc.c
> index 9c0ba7a6c185..c54c2268fee6 100644
> --- a/drivers/media/common/uvc.c
> +++ b/drivers/media/common/uvc.c
> @@ -180,4 +180,5 @@ const struct uvc_format_desc *uvc_format_by_guid(const u8 guid[16])
>  }
>  EXPORT_SYMBOL_GPL(uvc_format_by_guid);
>  
> +MODULE_DESCRIPTION("USB Video Class common code");
>  MODULE_LICENSE("GPL");
> 
> ---
> base-commit: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670
> change-id: 20240612-md-drivers-media-common-01f67d64768a
>
  
Jeff Johnson June 26, 2024, 4:48 p.m. UTC | #2
On 6/12/2024 6:04 PM, Kieran Bingham wrote:
> Quoting Jeff Johnson (2024-06-13 00:58:59)
>> With ARCH=arm64, make allmodconfig && make W=1 C=1 reports:
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/common/uvc.o
>>
>> Add the missing invocation of the MODULE_DESCRIPTION() macro.
>>
>> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> 
> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

Following up to see if anything else is needed from me. Hoping to see this in
linux-next so I can remove it from my tracking spreadsheet :)

/jeff

> 
>> ---
>>  drivers/media/common/uvc.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/media/common/uvc.c b/drivers/media/common/uvc.c
>> index 9c0ba7a6c185..c54c2268fee6 100644
>> --- a/drivers/media/common/uvc.c
>> +++ b/drivers/media/common/uvc.c
>> @@ -180,4 +180,5 @@ const struct uvc_format_desc *uvc_format_by_guid(const u8 guid[16])
>>  }
>>  EXPORT_SYMBOL_GPL(uvc_format_by_guid);
>>  
>> +MODULE_DESCRIPTION("USB Video Class common code");
>>  MODULE_LICENSE("GPL");
>>
>> ---
>> base-commit: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670
>> change-id: 20240612-md-drivers-media-common-01f67d64768a
>>
  

Patch

diff --git a/drivers/media/common/uvc.c b/drivers/media/common/uvc.c
index 9c0ba7a6c185..c54c2268fee6 100644
--- a/drivers/media/common/uvc.c
+++ b/drivers/media/common/uvc.c
@@ -180,4 +180,5 @@  const struct uvc_format_desc *uvc_format_by_guid(const u8 guid[16])
 }
 EXPORT_SYMBOL_GPL(uvc_format_by_guid);
 
+MODULE_DESCRIPTION("USB Video Class common code");
 MODULE_LICENSE("GPL");