[v2,2/2] media: rcar-vin: Add support for R-Car V4M

Message ID 20240610113124.2396688-3-niklas.soderlund+renesas@ragnatech.se (mailing list archive)
State New
Headers
Series rcar-vin: Add support for R-Car V4M |

Commit Message

Niklas Söderlund June 10, 2024, 11:31 a.m. UTC
  Add support for R-Car V4M. The V4M is similar to V4H and uses the ISP
Channel Selector as its only possible video input source. Reuse and
rename the info structure from V4H to cover all current Gen4 SoCs.

Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
---
* Changes since v1
- Create a shared Gen4 info strucutre.
---
 drivers/media/platform/renesas/rcar-vin/rcar-core.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
  

Comments

Geert Uytterhoeven June 10, 2024, 12:14 p.m. UTC | #1
Hi Niklas,

On Mon, Jun 10, 2024 at 1:32 PM Niklas Söderlund
<niklas.soderlund+renesas@ragnatech.se> wrote:
> Add support for R-Car V4M. The V4M is similar to V4H and uses the ISP
> Channel Selector as its only possible video input source. Reuse and
> rename the info structure from V4H to cover all current Gen4 SoCs.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> * Changes since v1
> - Create a shared Gen4 info strucutre.

Thanks for the update!

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

> --- a/drivers/media/platform/renesas/rcar-vin/rcar-core.c
> +++ b/drivers/media/platform/renesas/rcar-vin/rcar-core.c
> @@ -1283,7 +1283,7 @@ static const struct rvin_info rcar_info_r8a779a0 = {
>         .max_height = 4096,
>  };
>
> -static const struct rvin_info rcar_info_r8a779g0 = {
> +static const struct rvin_info rcar_info_gen4 = {
>         .model = RCAR_GEN3,
>         .use_mc = true,
>         .use_isp = true,

FTR, rcar_info_gen4 is (still) identical to rcar_info_r8a779a0.

Gr{oetje,eeting}s,

                        Geert
  
Laurent Pinchart June 19, 2024, 1:35 a.m. UTC | #2
Hi Niklas,

Thank you for the patch.

On Mon, Jun 10, 2024 at 01:31:24PM +0200, Niklas Söderlund wrote:
> Add support for R-Car V4M. The V4M is similar to V4H and uses the ISP
> Channel Selector as its only possible video input source. Reuse and
> rename the info structure from V4H to cover all current Gen4 SoCs.
> 
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>

I would normally take this in my tree and send a pull request, but a
decision on the DT bindings is needed first. I may miss the outcome if I
don't get CC'ed on v2, but I'm sure Hans or Sakari can also take the
patches.

> ---
> * Changes since v1
> - Create a shared Gen4 info strucutre.
> ---
>  drivers/media/platform/renesas/rcar-vin/rcar-core.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/platform/renesas/rcar-vin/rcar-core.c b/drivers/media/platform/renesas/rcar-vin/rcar-core.c
> index 809c3a38cc4a..6992b61f0d48 100644
> --- a/drivers/media/platform/renesas/rcar-vin/rcar-core.c
> +++ b/drivers/media/platform/renesas/rcar-vin/rcar-core.c
> @@ -1283,7 +1283,7 @@ static const struct rvin_info rcar_info_r8a779a0 = {
>  	.max_height = 4096,
>  };
>  
> -static const struct rvin_info rcar_info_r8a779g0 = {
> +static const struct rvin_info rcar_info_gen4 = {
>  	.model = RCAR_GEN3,
>  	.use_mc = true,
>  	.use_isp = true,
> @@ -1359,7 +1359,11 @@ static const struct of_device_id rvin_of_id_table[] = {
>  	},
>  	{
>  		.compatible = "renesas,vin-r8a779g0",
> -		.data = &rcar_info_r8a779g0,
> +		.data = &rcar_info_gen4,
> +	},
> +	{
> +		.compatible = "renesas,vin-r8a779h0",
> +		.data = &rcar_info_gen4,
>  	},
>  	{ /* Sentinel */ },
>  };
  

Patch

diff --git a/drivers/media/platform/renesas/rcar-vin/rcar-core.c b/drivers/media/platform/renesas/rcar-vin/rcar-core.c
index 809c3a38cc4a..6992b61f0d48 100644
--- a/drivers/media/platform/renesas/rcar-vin/rcar-core.c
+++ b/drivers/media/platform/renesas/rcar-vin/rcar-core.c
@@ -1283,7 +1283,7 @@  static const struct rvin_info rcar_info_r8a779a0 = {
 	.max_height = 4096,
 };
 
-static const struct rvin_info rcar_info_r8a779g0 = {
+static const struct rvin_info rcar_info_gen4 = {
 	.model = RCAR_GEN3,
 	.use_mc = true,
 	.use_isp = true,
@@ -1359,7 +1359,11 @@  static const struct of_device_id rvin_of_id_table[] = {
 	},
 	{
 		.compatible = "renesas,vin-r8a779g0",
-		.data = &rcar_info_r8a779g0,
+		.data = &rcar_info_gen4,
+	},
+	{
+		.compatible = "renesas,vin-r8a779h0",
+		.data = &rcar_info_gen4,
 	},
 	{ /* Sentinel */ },
 };