[1/5] media: atomisp: Remove unused mipicsi_flag module parameter

Message ID 20240603132057.255917-1-hdegoede@redhat.com (mailing list archive)
State New
Headers
Series [1/5] media: atomisp: Remove unused mipicsi_flag module parameter |

Commit Message

Hans de Goede June 3, 2024, 1:20 p.m. UTC
  The mipicsi_flag int is completely unused, remove it.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/staging/media/atomisp/pci/atomisp_common.h | 1 -
 drivers/staging/media/atomisp/pci/atomisp_v4l2.c   | 4 ----
 2 files changed, 5 deletions(-)
  

Comments

Andy Shevchenko June 3, 2024, 7:38 p.m. UTC | #1
On Mon, Jun 03, 2024 at 03:20:53PM +0200, Hans de Goede wrote:
> The mipicsi_flag int is completely unused, remove it.

Reviewed-by: Andy Shevchenko <andy@kernel.org>

(One nit in patch 3, though. I think it's worth to address)
  

Patch

diff --git a/drivers/staging/media/atomisp/pci/atomisp_common.h b/drivers/staging/media/atomisp/pci/atomisp_common.h
index 9d23a6ccfc33..2d0a77df6c88 100644
--- a/drivers/staging/media/atomisp/pci/atomisp_common.h
+++ b/drivers/staging/media/atomisp/pci/atomisp_common.h
@@ -33,7 +33,6 @@ 
 
 extern int dbg_level;
 extern int dbg_func;
-extern int mipicsi_flag;
 extern int pad_w;
 extern int pad_h;
 
diff --git a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
index 9df0eb7044b7..8b522baf2e66 100644
--- a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
+++ b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
@@ -66,10 +66,6 @@  module_param(dbg_func, int, 0644);
 MODULE_PARM_DESC(dbg_func,
 		 "log function switch non/printk (default:printk)");
 
-int mipicsi_flag;
-module_param(mipicsi_flag, int, 0644);
-MODULE_PARM_DESC(mipicsi_flag, "mipi csi compression predictor algorithm");
-
 static char firmware_name[256];
 module_param_string(firmware_name, firmware_name, sizeof(firmware_name), 0);
 MODULE_PARM_DESC(firmware_name, "Firmware file name. Allows overriding the default firmware name.");