diff mbox series

media: verisilicon: Use fourcc format string

Message ID 20240528130314.464867-1-m.tretter@pengutronix.de (mailing list archive)
State Accepted
Delegated to: Hans Verkuil
Headers
Series media: verisilicon: Use fourcc format string |

Commit Message

Michael Tretter May 28, 2024, 1:03 p.m. UTC 
  There is a fourcc format string for printing formats. Use it instead of
open coding the conversion.

Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
---
 drivers/media/platform/verisilicon/hantro_v4l2.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

Comments

Nicolas Dufresne June 4, 2024, 2:25 p.m. UTC | #1 
Le mardi 28 mai 2024 à 15:03 +0200, Michael Tretter a écrit :
> There is a fourcc format string for printing formats. Use it instead of
> open coding the conversion.
> 
> Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>

Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>

> ---
>  drivers/media/platform/verisilicon/hantro_v4l2.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/media/platform/verisilicon/hantro_v4l2.c b/drivers/media/platform/verisilicon/hantro_v4l2.c
> index df6f2536263b..62d3962c18d9 100644
> --- a/drivers/media/platform/verisilicon/hantro_v4l2.c
> +++ b/drivers/media/platform/verisilicon/hantro_v4l2.c
> @@ -303,11 +303,7 @@ static int hantro_try_fmt(const struct hantro_ctx *ctx,
>  
>  	coded = capture == ctx->is_encoder;
>  
> -	vpu_debug(4, "trying format %c%c%c%c\n",
> -		  (pix_mp->pixelformat & 0x7f),
> -		  (pix_mp->pixelformat >> 8) & 0x7f,
> -		  (pix_mp->pixelformat >> 16) & 0x7f,
> -		  (pix_mp->pixelformat >> 24) & 0x7f);
> +	vpu_debug(4, "trying format %p4cc\n", &pix_mp->pixelformat);
>  
>  	fmt = hantro_find_format(ctx, pix_mp->pixelformat);
>  	if (!fmt) {
diff mbox series

Patch

diff --git a/drivers/media/platform/verisilicon/hantro_v4l2.c b/drivers/media/platform/verisilicon/hantro_v4l2.c
index df6f2536263b..62d3962c18d9 100644
--- a/drivers/media/platform/verisilicon/hantro_v4l2.c
+++ b/drivers/media/platform/verisilicon/hantro_v4l2.c
@@ -303,11 +303,7 @@  static int hantro_try_fmt(const struct hantro_ctx *ctx,
 
 	coded = capture == ctx->is_encoder;
 
-	vpu_debug(4, "trying format %c%c%c%c\n",
-		  (pix_mp->pixelformat & 0x7f),
-		  (pix_mp->pixelformat >> 8) & 0x7f,
-		  (pix_mp->pixelformat >> 16) & 0x7f,
-		  (pix_mp->pixelformat >> 24) & 0x7f);
+	vpu_debug(4, "trying format %p4cc\n", &pix_mp->pixelformat);
 
 	fmt = hantro_find_format(ctx, pix_mp->pixelformat);
 	if (!fmt) {