[v3,1/2] dt-bindings: media: i2c: add galaxycore,gc2145 DVP bus support
Commit Message
Signed-off-by: Andrey Skvortsov <andrej.skvortzov@gmail.com>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../bindings/media/i2c/galaxycore,gc2145.yaml | 65 ++++++++++++++++++-
1 file changed, 64 insertions(+), 1 deletion(-)
Comments
On 04/05/2024 18:41, Andrey Skvortsov wrote:
> Signed-off-by: Andrey Skvortsov <andrej.skvortzov@gmail.com>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Not true. I never acked patch with empty commit and such content.
Drop fake tag and send new version with proper commit msg and proper
changelog under ---.
Best regards,
Krzysztof
On 05/05/2024 10:20, Krzysztof Kozlowski wrote:
> On 04/05/2024 18:41, Andrey Skvortsov wrote:
>> Signed-off-by: Andrey Skvortsov <andrej.skvortzov@gmail.com>
>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> Not true. I never acked patch with empty commit and such content.
>
> Drop fake tag and send new version with proper commit msg and proper
> changelog under ---.
>
I just noticed that such tag was added to v2 as well, so you added it to
something entirely else and keep going.
Best regards,
Krzysztof
Hi Krzysztof,
On 24-05-05 10:20, Krzysztof Kozlowski wrote:
> On 04/05/2024 18:41, Andrey Skvortsov wrote:
> > Signed-off-by: Andrey Skvortsov <andrej.skvortzov@gmail.com>
> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> Not true. I never acked patch with empty commit and such content.
>
Sorry about that. You've acked v1, so I've kept it. I'll remove it in
v4.
> Drop fake tag and send new version with proper commit msg and proper
> changelog under ---.
There is changelog in cover letter. Should I include corresponding changelog in each
patch as well?
On 05/05/2024 11:04, Andrey Skvortsov wrote:
> Hi Krzysztof,
>
> On 24-05-05 10:20, Krzysztof Kozlowski wrote:
>> On 04/05/2024 18:41, Andrey Skvortsov wrote:
>>> Signed-off-by: Andrey Skvortsov <andrej.skvortzov@gmail.com>
>>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>> Not true. I never acked patch with empty commit and such content.
>>
> Sorry about that. You've acked v1, so I've kept it. I'll remove it in
> v4.
I acked entirely different version. It had even commit msg. Empty commit
would have never been acked.
>
>> Drop fake tag and send new version with proper commit msg and proper
>> changelog under ---.
> There is changelog in cover letter. Should I include corresponding changelog in each
> patch as well?
It's fine there although nothing explains why you did these changes or
why commit msg is gone.
Best regards,
Krzysztof
@@ -61,8 +61,38 @@ properties:
properties:
link-frequencies: true
+ bus-type:
+ enum:
+ - 4 # CSI-2 D-PHY
+ - 5 # Parallel
+ default: 4
+
+ bus-width:
+ const: 8
+
+ hsync-active:
+ enum: [0, 1]
+ default: 1
+
+ vsync-active:
+ enum: [0, 1]
+ default: 1
+
+ pclk-sample:
+ enum: [0, 1]
+ default: 1
+
required:
- - link-frequencies
+ - bus-type
+
+ allOf:
+ - if:
+ properties:
+ bus-type:
+ const: 4
+ then:
+ required:
+ - link-frequencies
required:
- endpoint
@@ -84,6 +114,7 @@ additionalProperties: false
examples:
- |
+ #include <dt-bindings/media/video-interfaces.h>
#include <dt-bindings/gpio/gpio.h>
i2c {
@@ -103,6 +134,7 @@ examples:
port {
endpoint {
remote-endpoint = <&mipid02_0>;
+ bus-type = <MEDIA_BUS_TYPE_CSI2_DPHY>;
data-lanes = <1 2>;
link-frequencies = /bits/ 64 <120000000 192000000 240000000>;
};
@@ -110,4 +142,35 @@ examples:
};
};
+ - |
+ #include <dt-bindings/media/video-interfaces.h>
+ #include <dt-bindings/gpio/gpio.h>
+
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ camera@3c {
+ compatible = "galaxycore,gc2145";
+ reg = <0x3c>;
+ clocks = <&clk_ext_camera>;
+ iovdd-supply = <&scmi_v3v3_sw>;
+ avdd-supply = <&scmi_v3v3_sw>;
+ dvdd-supply = <&scmi_v3v3_sw>;
+ powerdown-gpios = <&mcp23017 3 (GPIO_ACTIVE_LOW | GPIO_PUSH_PULL)>;
+ reset-gpios = <&mcp23017 4 (GPIO_ACTIVE_LOW | GPIO_PUSH_PULL)>;
+
+ port {
+ endpoint {
+ remote-endpoint = <¶llel_from_gc2145>;
+ bus-type = <MEDIA_BUS_TYPE_PARALLEL>;
+ bus-width = <8>;
+ hsync-active = <1>;
+ vsync-active = <1>;
+ pclk-sample = <1>;
+ };
+ };
+ };
+ };
+
...