diff mbox series

Add "Quanta ACER HD User Facing" devices.

Message ID 20240425132334.18546-2-localevil3@gmail.com (mailing list archive)
State New
Delegated to: Laurent Pinchart
Headers
Series Add "Quanta ACER HD User Facing" devices. |

Commit Message

Ilyas Erezhepov April 25, 2024, 1:23 p.m. UTC 
  This patch adds two built-in video cameras for Acer laptops.

Signed-off-by: Ilyas Erezhepov <localevil3@gmail.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

---
 drivers/media/usb/uvc/uvc_driver.c | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

Comments

Ricardo Ribalda May 29, 2024, 12:08 p.m. UTC | #1 
Hi Ilyas

On Thu, 25 Apr 2024 at 15:27, Ilyas Erezhepov <localevil3@gmail.com> wrote:
>
> This patch adds two built-in video cameras for Acer laptops.
>
> Signed-off-by: Ilyas Erezhepov <localevil3@gmail.com>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
May I ask where Laurent reviewed the patch?

I am trying to find it in linux-media and I am not able to find it


>
> ---
>  drivers/media/usb/uvc/uvc_driver.c | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>
> diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
> index 08fcd2ffa727..502c03b6dabe 100644
> --- a/drivers/media/usb/uvc/uvc_driver.c
> +++ b/drivers/media/usb/uvc/uvc_driver.c
> @@ -2454,6 +2454,29 @@ static const struct usb_device_id uvc_ids[] = {
>           .bInterfaceSubClass   = 1,
>           .bInterfaceProtocol   = UVC_PC_PROTOCOL_15,
>           .driver_info          = (kernel_ulong_t)&uvc_ctrl_power_line_limited },
> +       /* Quanta ACER HD User Facing  0x4035 */
> +       { .match_flags          = USB_DEVICE_ID_MATCH_DEVICE
> +                               | USB_DEVICE_ID_MATCH_INT_INFO,
> +         .idVendor             = 0x0408,
> +         .idProduct            = 0x4035,
> +         .bInterfaceClass      = USB_CLASS_VIDEO,
> +         .bInterfaceSubClass   = 1,
> +         .bInterfaceProtocol   = UVC_PC_PROTOCOL_15,
> +         .driver_info          = (kernel_ulong_t) &(const struct uvc_device_info ) {
> +               .uvc_version = 0x010a,
> +         }
> +       },
> +       /* Quanta ACER HD User Facing 4033 */
> +       { .match_flags          = USB_DEVICE_ID_MATCH_DEVICE
> +                               | USB_DEVICE_ID_MATCH_INT_INFO,
> +         .idVendor             = 0x0408,
> +         .idProduct            = 0x4033,
> +         .bInterfaceClass      = USB_CLASS_VIDEO,
> +         .bInterfaceSubClass   = 1,
> +         .bInterfaceProtocol   = UVC_PC_PROTOCOL_15,
> +         .driver_info          = (kernel_ulong_t) &(const struct uvc_device_info ) {
> +               .uvc_version = 0x010a, }
> +       },
>         /* LogiLink Wireless Webcam */
>         { .match_flags          = USB_DEVICE_ID_MATCH_DEVICE
>                                 | USB_DEVICE_ID_MATCH_INT_INFO,
> --
> 2.44.0
>
>
Ricardo Ribalda June 3, 2024, 1:34 p.m. UTC | #2 
Hi Ильяс

On Wed, 29 May 2024 at 23:05, Ильяс Эреджепов <localevil3@gmail.com> wrote:
>
> Hi Ricardo
>
> I thought he was on the list of people who should see this patch.

Adding him as CC: ot To: should be enough.

Signed-off-by: means that the person has reviewed and approved the
patch, it can only be added by the actual person who did the review

>
> I asked Laurent how to send a patch correctly.
>
> Do I need to send a new letter that is signed only by me?

Yes please, and I think that you should only add 0x4033, there is a
patch already under review for 0x4035.
https://lore.kernel.org/linux-media/20230115205210.20077-1-laurent.pinchart@ideasonboard.com/


When you send the patch, please add the output of lsusb -v of the device.

Thanks!


>
> On 5/29/24 14:08, Ricardo Ribalda wrote:
> > Hi Ilyas
> >
> > On Thu, 25 Apr 2024 at 15:27, Ilyas Erezhepov <localevil3@gmail.com> wrote:
> >> This patch adds two built-in video cameras for Acer laptops.
> >>
> >> Signed-off-by: Ilyas Erezhepov <localevil3@gmail.com>
> >> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > May I ask where Laurent reviewed the patch?
> >
> > I am trying to find it in linux-media and I am not able to find it
> >
> >
> >> ---
> >>   drivers/media/usb/uvc/uvc_driver.c | 23 +++++++++++++++++++++++
> >>   1 file changed, 23 insertions(+)
> >>
> >> diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
> >> index 08fcd2ffa727..502c03b6dabe 100644
> >> --- a/drivers/media/usb/uvc/uvc_driver.c
> >> +++ b/drivers/media/usb/uvc/uvc_driver.c
> >> @@ -2454,6 +2454,29 @@ static const struct usb_device_id uvc_ids[] = {
> >>            .bInterfaceSubClass   = 1,
> >>            .bInterfaceProtocol   = UVC_PC_PROTOCOL_15,
> >>            .driver_info          = (kernel_ulong_t)&uvc_ctrl_power_line_limited },
> >> +       /* Quanta ACER HD User Facing  0x4035 */
> >> +       { .match_flags          = USB_DEVICE_ID_MATCH_DEVICE
> >> +                               | USB_DEVICE_ID_MATCH_INT_INFO,
> >> +         .idVendor             = 0x0408,
> >> +         .idProduct            = 0x4035,
> >> +         .bInterfaceClass      = USB_CLASS_VIDEO,
> >> +         .bInterfaceSubClass   = 1,
> >> +         .bInterfaceProtocol   = UVC_PC_PROTOCOL_15,
> >> +         .driver_info          = (kernel_ulong_t) &(const struct uvc_device_info ) {
> >> +               .uvc_version = 0x010a,
> >> +         }
> >> +       },
> >> +       /* Quanta ACER HD User Facing 4033 */
> >> +       { .match_flags          = USB_DEVICE_ID_MATCH_DEVICE
> >> +                               | USB_DEVICE_ID_MATCH_INT_INFO,
> >> +         .idVendor             = 0x0408,
> >> +         .idProduct            = 0x4033,
> >> +         .bInterfaceClass      = USB_CLASS_VIDEO,
> >> +         .bInterfaceSubClass   = 1,
> >> +         .bInterfaceProtocol   = UVC_PC_PROTOCOL_15,
> >> +         .driver_info          = (kernel_ulong_t) &(const struct uvc_device_info ) {
> >> +               .uvc_version = 0x010a, }
> >> +       },
> >>          /* LogiLink Wireless Webcam */
> >>          { .match_flags          = USB_DEVICE_ID_MATCH_DEVICE
> >>                                  | USB_DEVICE_ID_MATCH_INT_INFO,
> >> --
> >> 2.44.0
> >>
> >>
> >
diff mbox series

Patch

diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
index 08fcd2ffa727..502c03b6dabe 100644
--- a/drivers/media/usb/uvc/uvc_driver.c
+++ b/drivers/media/usb/uvc/uvc_driver.c
@@ -2454,6 +2454,29 @@  static const struct usb_device_id uvc_ids[] = {
 	  .bInterfaceSubClass	= 1,
 	  .bInterfaceProtocol	= UVC_PC_PROTOCOL_15,
 	  .driver_info		= (kernel_ulong_t)&uvc_ctrl_power_line_limited },
+	/* Quanta ACER HD User Facing  0x4035 */
+	{ .match_flags		= USB_DEVICE_ID_MATCH_DEVICE
+				| USB_DEVICE_ID_MATCH_INT_INFO,
+	  .idVendor 		= 0x0408,
+	  .idProduct 		= 0x4035,
+	  .bInterfaceClass 	= USB_CLASS_VIDEO,
+	  .bInterfaceSubClass 	= 1,
+	  .bInterfaceProtocol 	= UVC_PC_PROTOCOL_15,
+	  .driver_info 		= (kernel_ulong_t) &(const struct uvc_device_info ) {
+		.uvc_version = 0x010a, 
+	  } 
+	},									
+	/* Quanta ACER HD User Facing 4033 */
+	{ .match_flags		= USB_DEVICE_ID_MATCH_DEVICE
+				| USB_DEVICE_ID_MATCH_INT_INFO,
+	  .idVendor 		= 0x0408,
+	  .idProduct 		= 0x4033,
+	  .bInterfaceClass 	= USB_CLASS_VIDEO,
+	  .bInterfaceSubClass 	= 1,
+	  .bInterfaceProtocol 	= UVC_PC_PROTOCOL_15,
+	  .driver_info 		= (kernel_ulong_t) &(const struct uvc_device_info ) {
+		.uvc_version = 0x010a, } 
+	},
 	/* LogiLink Wireless Webcam */
 	{ .match_flags		= USB_DEVICE_ID_MATCH_DEVICE
 				| USB_DEVICE_ID_MATCH_INT_INFO,