Message ID | 20240412151515.837824-2-linkmauve@linkmauve.fr (mailing list archive) |
---|---|
State | Superseded |
Delegated to: | Sebastian Fricke |
Headers |
Received: from sv.mirrors.kernel.org ([139.178.88.99]) by linuxtv.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from <linux-media+bounces-9197-patchwork=linuxtv.org@vger.kernel.org>) id 1rvIh7-0004Eo-1k for patchwork@linuxtv.org; Fri, 12 Apr 2024 15:20:02 +0000 Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id D7E10283746 for <patchwork@linuxtv.org>; Fri, 12 Apr 2024 15:20:00 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1F77614F9F3; Fri, 12 Apr 2024 15:15:21 +0000 (UTC) X-Original-To: linux-media@vger.kernel.org Received: from luna.linkmauve.fr (luna.linkmauve.fr [82.65.109.163]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E230C149C4D; Fri, 12 Apr 2024 15:15:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=82.65.109.163 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712934920; cv=none; b=b5AwX/3XHmClXtFs0K1CniBitO6TnQU56KLUPCU2jtkgttsk7Z542QT65nCVTyxtDm+fhrPDDx2FC41otthBmfqXU2qtTxc3KalvB2bcY4M5w7IowIbwrQoBT2qxHN3L02BIXWXktvyvTP/FqMzPVLE7F1XG6yLTkY0/01gpUuQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712934920; c=relaxed/simple; bh=J1jG4kj0aYZKcUmMvtYUKNLJlJWsegdKYmIoMD1fTS8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=p2pXpr/SW6mpEG2VEroTsCyc877Vw+cbXi4KMOhkq2M2XrYMaYNAE8U3QM7czNkb09Ky0MkuAecLe/x90nNkdW+S4x05nq91JxcRJ10YRtOlNJjAAn6KY7PhUMobQFjpSb+No1WIPvHz274jmk8Z3+FkahXOz4sLAkF/gGjy6gg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linkmauve.fr; spf=pass smtp.mailfrom=linkmauve.fr; arc=none smtp.client-ip=82.65.109.163 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linkmauve.fr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linkmauve.fr Received: by luna.linkmauve.fr (Postfix, from userid 1000) id 73A2C10A2675; Fri, 12 Apr 2024 17:15:17 +0200 (CEST) From: Emmanuel Gil Peyrot <linkmauve@linkmauve.fr> To: linux-kernel@vger.kernel.org Cc: Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>, Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>, Philipp Zabel <p.zabel@pengutronix.de>, Mauro Carvalho Chehab <mchehab@kernel.org>, Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Heiko Stuebner <heiko@sntech.de>, Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>, Robin Murphy <robin.murphy@arm.com>, Sebastian Reichel <sebastian.reichel@collabora.com>, Cristian Ciocaltea <cristian.ciocaltea@collabora.com>, Dragan Simic <dsimic@manjaro.org>, Shreeya Patel <shreeya.patel@collabora.com>, Chris Morgan <macromorgan@hotmail.com>, Andy Yan <andy.yan@rock-chips.com>, Nicolas Frattaroli <frattaroli.nicolas@gmail.com>, linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev Subject: [PATCH v3 1/2] =?utf-8?q?media=3A_dt-binding=3A_media=3A_Document_r?= =?utf-8?q?k3588=E2=80=99s_VEPU121?= Date: Fri, 12 Apr 2024 17:15:10 +0200 Message-ID: <20240412151515.837824-2-linkmauve@linkmauve.fr> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240412151515.837824-1-linkmauve@linkmauve.fr> References: <20240412151515.837824-1-linkmauve@linkmauve.fr> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: <linux-media.vger.kernel.org> List-Subscribe: <mailto:linux-media+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-media+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-LSpam-Score: -4.8 (----) X-LSpam-Report: No, score=-4.8 required=5.0 tests=ARC_SIGNED=0.001,ARC_VALID=-0.1,BAYES_00=-1.9,DMARC_MISSING=0.001,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1,RCVD_IN_DNSWL_MED=-2.3,SPF_HELO_NONE=0.001,SPF_PASS=-0.001 autolearn=ham autolearn_force=no |
Series |
Enable JPEG encoding on rk3588
|
|
Commit Message
Emmanuel Gil Peyrot
April 12, 2024, 3:15 p.m. UTC
This encoder-only device is present four times on this SoC, and should
support everything the rk3568 vepu supports (so JPEG, H.264 and VP8
encoding).
According to the TRM[1], there is also the VEPU580 encoder which
supports H.264 and H.265, and various VDPU* decoders, of which only the
VDPU981 is currently supported. This patch describes only the VEPU121.
[1] https://github.com/FanX-Tek/rk3588-TRM-and-Datasheet
Signed-off-by: Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>
---
.../devicetree/bindings/media/rockchip,rk3568-vepu.yaml | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
Comments
On 12/04/2024 17:15, Emmanuel Gil Peyrot wrote: > This encoder-only device is present four times on this SoC, and should > support everything the rk3568 vepu supports (so JPEG, H.264 and VP8 > encoding). > > According to the TRM[1], there is also the VEPU580 encoder which > supports H.264 and H.265, and various VDPU* decoders, of which only the > VDPU981 is currently supported. This patch describes only the VEPU121. > > [1] https://github.com/FanX-Tek/rk3588-TRM-and-Datasheet > > Signed-off-by: Emmanuel Gil Peyrot <linkmauve@linkmauve.fr> So you ignored all the tags? No one will pick up your patch if you are going to keep ignoring them... Subject: drop the second, redundant "media". Best regards, Krzysztof
On Sat, Apr 13, 2024 at 11:22:51PM +0200, Krzysztof Kozlowski wrote: > On 12/04/2024 17:15, Emmanuel Gil Peyrot wrote: > > This encoder-only device is present four times on this SoC, and should > > support everything the rk3568 vepu supports (so JPEG, H.264 and VP8 > > encoding). > > > > According to the TRM[1], there is also the VEPU580 encoder which > > supports H.264 and H.265, and various VDPU* decoders, of which only the > > VDPU981 is currently supported. This patch describes only the VEPU121. > > > > [1] https://github.com/FanX-Tek/rk3588-TRM-and-Datasheet > > > > Signed-off-by: Emmanuel Gil Peyrot <linkmauve@linkmauve.fr> > > So you ignored all the tags? No one will pick up your patch if you are > going to keep ignoring them... If Nicolas's concern about breakage due to exposing multiple video devices was addressed: Acked-by: Conor Dooley <conor.dooley@microchip.com> Thanks, Conor.
diff --git a/Documentation/devicetree/bindings/media/rockchip,rk3568-vepu.yaml b/Documentation/devicetree/bindings/media/rockchip,rk3568-vepu.yaml index 9d90d8d0565a..4c6cb21da041 100644 --- a/Documentation/devicetree/bindings/media/rockchip,rk3568-vepu.yaml +++ b/Documentation/devicetree/bindings/media/rockchip,rk3568-vepu.yaml @@ -15,8 +15,12 @@ description: properties: compatible: - enum: - - rockchip,rk3568-vepu + oneOf: + - const: rockchip,rk3568-vepu + - items: + - enum: + - rockchip,rk3588-vepu121 + - const: rockchip,rk3568-vepu reg: maxItems: 1