Message ID | 20240327134115.424846-2-linkmauve@linkmauve.fr (mailing list archive) |
---|---|
State | Superseded |
Delegated to: | Sebastian Fricke |
Headers |
Received: from am.mirrors.kernel.org ([147.75.80.249]) by linuxtv.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from <linux-media+bounces-7945-patchwork=linuxtv.org@vger.kernel.org>) id 1rpUbd-0007e7-1G for patchwork@linuxtv.org; Wed, 27 Mar 2024 14:50:23 +0000 Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 443F61F23787 for <patchwork@linuxtv.org>; Wed, 27 Mar 2024 14:50:19 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8565C15ADBA; Wed, 27 Mar 2024 13:41:22 +0000 (UTC) X-Original-To: linux-media@vger.kernel.org Received: from luna.linkmauve.fr (luna.linkmauve.fr [82.65.109.163]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A202E13AA5D; Wed, 27 Mar 2024 13:41:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=82.65.109.163 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711546882; cv=none; b=XMXCZFXFEuHQj+vMdaI/o/ix3cyJBj3J81lsKHcs5yOdEwERlLFm/DTlhdpujO4zjlIlC35zdhf0v6ycLFdWpKooQDIrCAN7YAmia6e2fFRqpWs5hSiXAtT5BXw4j5bkb23sdgyQzCtdezDgM/2Y7NDbpnbI2gSJbOEw55wiwzQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711546882; c=relaxed/simple; bh=J1jG4kj0aYZKcUmMvtYUKNLJlJWsegdKYmIoMD1fTS8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=TK+ANPiGvTN8JtWW+H7LDW5BtzlvhIamgt2jOqhuEb+41PG4HlF9vXPKB8H8wFFFnX4FnjQHexyellTcteJuTwkB3UuBtilYyFUne352hX+UdRULGXdHTfipRuag6EdsOie5N25w84A8T3iuZqKt+UxIMMaBEAKgK/HexwW6vhw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linkmauve.fr; spf=pass smtp.mailfrom=linkmauve.fr; arc=none smtp.client-ip=82.65.109.163 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linkmauve.fr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linkmauve.fr Received: by luna.linkmauve.fr (Postfix, from userid 1000) id 086F6101AF36; Wed, 27 Mar 2024 14:41:18 +0100 (CET) From: Emmanuel Gil Peyrot <linkmauve@linkmauve.fr> To: linux-kernel@vger.kernel.org Cc: Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>, Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>, Philipp Zabel <p.zabel@pengutronix.de>, Mauro Carvalho Chehab <mchehab@kernel.org>, Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Heiko Stuebner <heiko@sntech.de>, Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>, Robin Murphy <robin.murphy@arm.com>, Sebastian Reichel <sebastian.reichel@collabora.com>, Cristian Ciocaltea <cristian.ciocaltea@collabora.com>, Dragan Simic <dsimic@manjaro.org>, Shreeya Patel <shreeya.patel@collabora.com>, Chris Morgan <macromorgan@hotmail.com>, Andy Yan <andy.yan@rock-chips.com>, Nicolas Frattaroli <frattaroli.nicolas@gmail.com>, linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev Subject: [PATCH v2 1/2] =?utf-8?q?media=3A_dt-binding=3A_media=3A_Document_r?= =?utf-8?q?k3588=E2=80=99s_VEPU121?= Date: Wed, 27 Mar 2024 14:41:11 +0100 Message-ID: <20240327134115.424846-2-linkmauve@linkmauve.fr> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240327134115.424846-1-linkmauve@linkmauve.fr> References: <20240327134115.424846-1-linkmauve@linkmauve.fr> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: <linux-media.vger.kernel.org> List-Subscribe: <mailto:linux-media+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-media+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-LSpam-Score: -2.5 (--) X-LSpam-Report: No, score=-2.5 required=5.0 tests=ARC_SIGNED=0.001,ARC_VALID=-0.1,BAYES_00=-1.9,DMARC_MISSING=0.001,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1,RCVD_IN_DNSWL_NONE=-0.0001,SPF_HELO_NONE=0.001,SPF_PASS=-0.001 autolearn=ham autolearn_force=no |
Series |
Enable JPEG encoding on rk3588
|
|
Commit Message
Emmanuel Gil Peyrot
March 27, 2024, 1:41 p.m. UTC
This encoder-only device is present four times on this SoC, and should
support everything the rk3568 vepu supports (so JPEG, H.264 and VP8
encoding).
According to the TRM[1], there is also the VEPU580 encoder which
supports H.264 and H.265, and various VDPU* decoders, of which only the
VDPU981 is currently supported. This patch describes only the VEPU121.
[1] https://github.com/FanX-Tek/rk3588-TRM-and-Datasheet
Signed-off-by: Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>
---
.../devicetree/bindings/media/rockchip,rk3568-vepu.yaml | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
Comments
On Wed, Mar 27, 2024 at 02:41:11PM +0100, Emmanuel Gil Peyrot wrote: > This encoder-only device is present four times on this SoC, and should > support everything the rk3568 vepu supports (so JPEG, H.264 and VP8 > encoding). > > According to the TRM[1], there is also the VEPU580 encoder which > supports H.264 and H.265, and various VDPU* decoders, of which only the > VDPU981 is currently supported. This patch describes only the VEPU121. > > [1] https://github.com/FanX-Tek/rk3588-TRM-and-Datasheet > > Signed-off-by: Emmanuel Gil Peyrot <linkmauve@linkmauve.fr> Acked-by: Conor Dooley <conor.dooley@microchip.com> Thanks, Conor. > --- > .../devicetree/bindings/media/rockchip,rk3568-vepu.yaml | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/rockchip,rk3568-vepu.yaml b/Documentation/devicetree/bindings/media/rockchip,rk3568-vepu.yaml > index 9d90d8d0565a..4c6cb21da041 100644 > --- a/Documentation/devicetree/bindings/media/rockchip,rk3568-vepu.yaml > +++ b/Documentation/devicetree/bindings/media/rockchip,rk3568-vepu.yaml > @@ -15,8 +15,12 @@ description: > > properties: > compatible: > - enum: > - - rockchip,rk3568-vepu > + oneOf: > + - const: rockchip,rk3568-vepu > + - items: > + - enum: > + - rockchip,rk3588-vepu121 > + - const: rockchip,rk3568-vepu > > reg: > maxItems: 1 > -- > 2.44.0 >
Hi, On Wed, Mar 27, 2024 at 02:41:11PM +0100, Emmanuel Gil Peyrot wrote: > This encoder-only device is present four times on this SoC, and should > support everything the rk3568 vepu supports (so JPEG, H.264 and VP8 > encoding). > > According to the TRM[1], there is also the VEPU580 encoder which > supports H.264 and H.265, and various VDPU* decoders, of which only the > VDPU981 is currently supported. This patch describes only the VEPU121. > > [1] https://github.com/FanX-Tek/rk3588-TRM-and-Datasheet > > Signed-off-by: Emmanuel Gil Peyrot <linkmauve@linkmauve.fr> > --- Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com> -- Sebastian > .../devicetree/bindings/media/rockchip,rk3568-vepu.yaml | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/rockchip,rk3568-vepu.yaml b/Documentation/devicetree/bindings/media/rockchip,rk3568-vepu.yaml > index 9d90d8d0565a..4c6cb21da041 100644 > --- a/Documentation/devicetree/bindings/media/rockchip,rk3568-vepu.yaml > +++ b/Documentation/devicetree/bindings/media/rockchip,rk3568-vepu.yaml > @@ -15,8 +15,12 @@ description: > > properties: > compatible: > - enum: > - - rockchip,rk3568-vepu > + oneOf: > + - const: rockchip,rk3568-vepu > + - items: > + - enum: > + - rockchip,rk3588-vepu121 > + - const: rockchip,rk3568-vepu > > reg: > maxItems: 1 > -- > 2.44.0 >
Le mercredi 27 mars 2024 à 17:23 +0000, Conor Dooley a écrit : > On Wed, Mar 27, 2024 at 02:41:11PM +0100, Emmanuel Gil Peyrot wrote: > > This encoder-only device is present four times on this SoC, and should > > support everything the rk3568 vepu supports (so JPEG, H.264 and VP8 > > encoding). > > > > According to the TRM[1], there is also the VEPU580 encoder which > > supports H.264 and H.265, and various VDPU* decoders, of which only the > > VDPU981 is currently supported. This patch describes only the VEPU121. > > > > [1] https://github.com/FanX-Tek/rk3588-TRM-and-Datasheet > > > > Signed-off-by: Emmanuel Gil Peyrot <linkmauve@linkmauve.fr> > > Acked-by: Conor Dooley <conor.dooley@microchip.com> I'd like to prevent this change until we fix the driver. It should not expose 1 video device per core, it should instead do schedule around these cores. Nicolas > > Thanks, > Conor. > > > --- > > .../devicetree/bindings/media/rockchip,rk3568-vepu.yaml | 8 ++++++-- > > 1 file changed, 6 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/media/rockchip,rk3568-vepu.yaml b/Documentation/devicetree/bindings/media/rockchip,rk3568-vepu.yaml > > index 9d90d8d0565a..4c6cb21da041 100644 > > --- a/Documentation/devicetree/bindings/media/rockchip,rk3568-vepu.yaml > > +++ b/Documentation/devicetree/bindings/media/rockchip,rk3568-vepu.yaml > > @@ -15,8 +15,12 @@ description: > > > > properties: > > compatible: > > - enum: > > - - rockchip,rk3568-vepu > > + oneOf: > > + - const: rockchip,rk3568-vepu > > + - items: > > + - enum: > > + - rockchip,rk3588-vepu121 > > + - const: rockchip,rk3568-vepu > > > > reg: > > maxItems: 1 > > -- > > 2.44.0 > >
diff --git a/Documentation/devicetree/bindings/media/rockchip,rk3568-vepu.yaml b/Documentation/devicetree/bindings/media/rockchip,rk3568-vepu.yaml index 9d90d8d0565a..4c6cb21da041 100644 --- a/Documentation/devicetree/bindings/media/rockchip,rk3568-vepu.yaml +++ b/Documentation/devicetree/bindings/media/rockchip,rk3568-vepu.yaml @@ -15,8 +15,12 @@ description: properties: compatible: - enum: - - rockchip,rk3568-vepu + oneOf: + - const: rockchip,rk3568-vepu + - items: + - enum: + - rockchip,rk3588-vepu121 + - const: rockchip,rk3568-vepu reg: maxItems: 1