Message ID | 20240325142611.15550-1-oleksandr@natalenko.name (mailing list archive) |
---|---|
State | Accepted |
Delegated to: | Laurent Pinchart |
Headers |
Received: from am.mirrors.kernel.org ([147.75.80.249]) by linuxtv.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from <linux-media+bounces-7763-patchwork=linuxtv.org@vger.kernel.org>) id 1ron9b-0001h1-0D for patchwork@linuxtv.org; Mon, 25 Mar 2024 16:26:34 +0000 Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 3086F1F3EF93 for <patchwork@linuxtv.org>; Mon, 25 Mar 2024 16:26:29 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3785B158A0A; Mon, 25 Mar 2024 14:26:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=natalenko.name header.i=@natalenko.name header.b="Ah0jZfdW" X-Original-To: linux-media@vger.kernel.org Received: from prime.voidband.net (prime.voidband.net [199.247.17.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7E1D136E26; Mon, 25 Mar 2024 14:26:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=199.247.17.104 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711376788; cv=none; b=k0B3tnZpVSP8H5i4hidU8xwRoPvUGWyB1VPIgFJ2wYhkjhHyrjQ+W9ydGnSImepDVYfudR/2fUW7J+OqEpX+b/lVY787BlQWyfAqOfyo3UN56pQGvwwK7rpO7w6dtxlKy/11NHH+qtumAjqYUlO3gXtLAINDNmgcECn6PCRidOM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711376788; c=relaxed/simple; bh=lTMJavNIWrnUZ0bbbF3Rx8TEQ/VmlXUb1B8yQuTFSDQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=kZmQJNUKGoLyGhPciKl8MiBTfT19+vzEiu/+za4Ls3OabPKJZHKYYKJEx2OMg18COYKlWDQFp7hpGlzbGcG7TIlx/qhMDoLAAIfy7VDLY+cZn1kd/M2DbIk2CcKC42WqWGnWNlEN6/XOxaFWd0IoT/UrHYx86YRfta/F3DTap+s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=natalenko.name; spf=pass smtp.mailfrom=natalenko.name; dkim=pass (1024-bit key) header.d=natalenko.name header.i=@natalenko.name header.b=Ah0jZfdW; arc=none smtp.client-ip=199.247.17.104 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=natalenko.name Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=natalenko.name Received: from localhost (unknown [94.142.239.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by prime.voidband.net (Postfix) with ESMTPSA id 670026346550; Mon, 25 Mar 2024 15:26:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=natalenko.name; s=dkim-20170712; t=1711376781; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=EWL9RPJbotHTugKp2e3hpY0GlUbdFdPRzf1HTQgWuFQ=; b=Ah0jZfdWa3W1ky5rNcCskxmzk4SobiXprUKDrzvMyuHY1U0ZERN+4Ht1vhB9+5Opp6t7ix sHo3HlM9x29jte6t/h9P4jGfW6vt1a57BNEUSduf8BHuWYzbOTAbfSFyIJmbX6mi+7JTuG kho2CwCuYCKFCHaEUzxIoLjGgBqLIHs= From: Oleksandr Natalenko <oleksandr@natalenko.name> To: linux-kernel@vger.kernel.org Cc: linux-media@vger.kernel.org, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Ricardo Ribalda <ribalda@chromium.org>, Mauro Carvalho Chehab <mchehab@kernel.org>, "hn.chen" <hn.chen@sunplusit.com>, Hans Verkuil <hverkuil@xs4all.nl>, Sergey Senozhatsky <senozhatsky@chromium.org> Subject: [PATCH] media/uvcvideo: add quirk for invalid dev_sof in Logitech C920 Date: Mon, 25 Mar 2024 15:26:11 +0100 Message-ID: <20240325142611.15550-1-oleksandr@natalenko.name> X-Mailer: git-send-email 2.44.0 Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: <linux-media.vger.kernel.org> List-Subscribe: <mailto:linux-media+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-media+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-LSpam-Score: 0.7 (/) X-LSpam-Report: No, score=0.7 required=5.0 tests=ARC_SIGNED=0.001,ARC_VALID=-0.1,BAYES_00=-1.9,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,DMARC_PASS=-0.001,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1,RCVD_IN_DNSWL_NONE=-0.0001,RCVD_IN_SBL_CSS=3.335,SPF_HELO_NONE=0.001,SPF_PASS=-0.001 autolearn=no autolearn_force=no |
Series |
media/uvcvideo: add quirk for invalid dev_sof in Logitech C920
|
|
Commit Message
Oleksandr Natalenko
March 25, 2024, 2:26 p.m. UTC
Similarly to Logitech C922, C920 seems to also suffer from a firmware bug that breaks hardware timestamping. Add a quirk for this camera model too. Before applying the quirk: ``` 100 (4) [-] none 100 200717 B 212.919114 213.079004 33.727 fps ts mono/SoE 101 (5) [-] none 101 200889 B 213.003703 213.114996 11.822 fps ts mono/SoE 102 (6) [-] none 102 200926 B 213.035571 213.146999 31.379 fps ts mono/SoE 103 (7) [-] none 103 200839 B 213.067424 213.179003 31.394 fps ts mono/SoE 104 (0) [-] none 104 200692 B 213.293180 213.214991 4.430 fps ts mono/SoE 105 (1) [-] none 105 200937 B 213.322374 213.247001 34.254 fps ts mono/SoE 106 (2) [-] none 106 201013 B 213.352228 213.279005 33.496 fps ts mono/SoE … ``` After applying the quirk: ``` 154 (2) [-] none 154 192417 B 42.199823 42.207788 27.779 fps ts mono/SoE 155 (3) [-] none 155 192040 B 42.231834 42.239791 31.239 fps ts mono/SoE 156 (4) [-] none 156 192213 B 42.263823 42.271822 31.261 fps ts mono/SoE 157 (5) [-] none 157 191981 B 42.299824 42.303827 27.777 fps ts mono/SoE 158 (6) [-] none 158 191953 B 42.331835 42.339811 31.239 fps ts mono/SoE 159 (7) [-] none 159 191904 B 42.363824 42.371813 31.261 fps ts mono/SoE 160 (0) [-] none 160 192210 B 42.399834 42.407801 27.770 fps ts mono/SoE ``` Link: https://lore.kernel.org/lkml/5764213.DvuYhMxLoT@natalenko.name/ Reviewed-by: Ricardo Ribalda <ribalda@chromium.org> Signed-off-by: Oleksandr Natalenko <oleksandr@natalenko.name> --- drivers/media/usb/uvc/uvc_driver.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Comments
On pondělí 25. března 2024 15:26:11, CEST Oleksandr Natalenko wrote: > Similarly to Logitech C922, C920 seems to also suffer from a firmware > bug that breaks hardware timestamping. > > Add a quirk for this camera model too. > > Before applying the quirk: > > ``` > 100 (4) [-] none 100 200717 B 212.919114 213.079004 33.727 fps ts mono/SoE > 101 (5) [-] none 101 200889 B 213.003703 213.114996 11.822 fps ts mono/SoE > 102 (6) [-] none 102 200926 B 213.035571 213.146999 31.379 fps ts mono/SoE > 103 (7) [-] none 103 200839 B 213.067424 213.179003 31.394 fps ts mono/SoE > 104 (0) [-] none 104 200692 B 213.293180 213.214991 4.430 fps ts mono/SoE > 105 (1) [-] none 105 200937 B 213.322374 213.247001 34.254 fps ts mono/SoE > 106 (2) [-] none 106 201013 B 213.352228 213.279005 33.496 fps ts mono/SoE > … > ``` > > After applying the quirk: > > ``` > 154 (2) [-] none 154 192417 B 42.199823 42.207788 27.779 fps ts mono/SoE > 155 (3) [-] none 155 192040 B 42.231834 42.239791 31.239 fps ts mono/SoE > 156 (4) [-] none 156 192213 B 42.263823 42.271822 31.261 fps ts mono/SoE > 157 (5) [-] none 157 191981 B 42.299824 42.303827 27.777 fps ts mono/SoE > 158 (6) [-] none 158 191953 B 42.331835 42.339811 31.239 fps ts mono/SoE > 159 (7) [-] none 159 191904 B 42.363824 42.371813 31.261 fps ts mono/SoE > 160 (0) [-] none 160 192210 B 42.399834 42.407801 27.770 fps ts mono/SoE > ``` > > Link: https://lore.kernel.org/lkml/5764213.DvuYhMxLoT@natalenko.name/ > Reviewed-by: Ricardo Ribalda <ribalda@chromium.org> > Signed-off-by: Oleksandr Natalenko <oleksandr@natalenko.name> > --- > drivers/media/usb/uvc/uvc_driver.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c > index 723e6d5680c2e..444d7089885ea 100644 > --- a/drivers/media/usb/uvc/uvc_driver.c > +++ b/drivers/media/usb/uvc/uvc_driver.c > @@ -2573,7 +2573,8 @@ static const struct usb_device_id uvc_ids[] = { > .bInterfaceClass = USB_CLASS_VIDEO, > .bInterfaceSubClass = 1, > .bInterfaceProtocol = 0, > - .driver_info = UVC_INFO_QUIRK(UVC_QUIRK_RESTORE_CTRLS_ON_INIT) }, > + .driver_info = UVC_INFO_QUIRK(UVC_QUIRK_RESTORE_CTRLS_ON_INIT > + | UVC_QUIRK_INVALID_DEVICE_SOF) }, > /* Logitech HD Pro Webcam C922 */ > { .match_flags = USB_DEVICE_ID_MATCH_DEVICE > | USB_DEVICE_ID_MATCH_INT_INFO, > Gentle ping on this one. Also, should I have added: Fixes: 5d0fd3c806b9 ("[media] uvcvideo: Disable hardware timestamps by default") ? (it's not that this change re-enables HW timestamping, but 5d0fd3c806b9 explicitly mentions C920 as affected)
Hi Oleksandr, On Mon, Apr 01, 2024 at 06:45:16PM +0200, Oleksandr Natalenko wrote: > On pondělí 25. března 2024 15:26:11, CEST Oleksandr Natalenko wrote: > > Similarly to Logitech C922, C920 seems to also suffer from a firmware > > bug that breaks hardware timestamping. > > > > Add a quirk for this camera model too. > > > > Before applying the quirk: > > > > ``` > > 100 (4) [-] none 100 200717 B 212.919114 213.079004 33.727 fps ts mono/SoE > > 101 (5) [-] none 101 200889 B 213.003703 213.114996 11.822 fps ts mono/SoE > > 102 (6) [-] none 102 200926 B 213.035571 213.146999 31.379 fps ts mono/SoE > > 103 (7) [-] none 103 200839 B 213.067424 213.179003 31.394 fps ts mono/SoE > > 104 (0) [-] none 104 200692 B 213.293180 213.214991 4.430 fps ts mono/SoE > > 105 (1) [-] none 105 200937 B 213.322374 213.247001 34.254 fps ts mono/SoE > > 106 (2) [-] none 106 201013 B 213.352228 213.279005 33.496 fps ts mono/SoE > > … > > ``` > > > > After applying the quirk: > > > > ``` > > 154 (2) [-] none 154 192417 B 42.199823 42.207788 27.779 fps ts mono/SoE > > 155 (3) [-] none 155 192040 B 42.231834 42.239791 31.239 fps ts mono/SoE > > 156 (4) [-] none 156 192213 B 42.263823 42.271822 31.261 fps ts mono/SoE > > 157 (5) [-] none 157 191981 B 42.299824 42.303827 27.777 fps ts mono/SoE > > 158 (6) [-] none 158 191953 B 42.331835 42.339811 31.239 fps ts mono/SoE > > 159 (7) [-] none 159 191904 B 42.363824 42.371813 31.261 fps ts mono/SoE > > 160 (0) [-] none 160 192210 B 42.399834 42.407801 27.770 fps ts mono/SoE > > ``` > > > > Link: https://lore.kernel.org/lkml/5764213.DvuYhMxLoT@natalenko.name/ > > Reviewed-by: Ricardo Ribalda <ribalda@chromium.org> > > Signed-off-by: Oleksandr Natalenko <oleksandr@natalenko.name> > > --- > > drivers/media/usb/uvc/uvc_driver.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c > > index 723e6d5680c2e..444d7089885ea 100644 > > --- a/drivers/media/usb/uvc/uvc_driver.c > > +++ b/drivers/media/usb/uvc/uvc_driver.c > > @@ -2573,7 +2573,8 @@ static const struct usb_device_id uvc_ids[] = { > > .bInterfaceClass = USB_CLASS_VIDEO, > > .bInterfaceSubClass = 1, > > .bInterfaceProtocol = 0, > > - .driver_info = UVC_INFO_QUIRK(UVC_QUIRK_RESTORE_CTRLS_ON_INIT) }, > > + .driver_info = UVC_INFO_QUIRK(UVC_QUIRK_RESTORE_CTRLS_ON_INIT > > + | UVC_QUIRK_INVALID_DEVICE_SOF) }, > > /* Logitech HD Pro Webcam C922 */ > > { .match_flags = USB_DEVICE_ID_MATCH_DEVICE > > | USB_DEVICE_ID_MATCH_INT_INFO, > > > > Gentle ping on this one. Ricardo, could you include this in the next version of your hw timestamp series ? > Also, should I have added: > > Fixes: 5d0fd3c806b9 ("[media] uvcvideo: Disable hardware timestamps by default") > > ? I don't think that's needed, no. > (it's not that this change re-enables HW timestamping, but > 5d0fd3c806b9 explicitly mentions C920 as affected)
Hi Laurent On Thu, 4 Apr 2024 at 03:11, Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote: > > Hi Oleksandr, > > On Mon, Apr 01, 2024 at 06:45:16PM +0200, Oleksandr Natalenko wrote: > > On pondělí 25. března 2024 15:26:11, CEST Oleksandr Natalenko wrote: > > > Similarly to Logitech C922, C920 seems to also suffer from a firmware > > > bug that breaks hardware timestamping. > > > > > > Add a quirk for this camera model too. > > > > > > Before applying the quirk: > > > > > > ``` > > > 100 (4) [-] none 100 200717 B 212.919114 213.079004 33.727 fps ts mono/SoE > > > 101 (5) [-] none 101 200889 B 213.003703 213.114996 11.822 fps ts mono/SoE > > > 102 (6) [-] none 102 200926 B 213.035571 213.146999 31.379 fps ts mono/SoE > > > 103 (7) [-] none 103 200839 B 213.067424 213.179003 31.394 fps ts mono/SoE > > > 104 (0) [-] none 104 200692 B 213.293180 213.214991 4.430 fps ts mono/SoE > > > 105 (1) [-] none 105 200937 B 213.322374 213.247001 34.254 fps ts mono/SoE > > > 106 (2) [-] none 106 201013 B 213.352228 213.279005 33.496 fps ts mono/SoE > > > … > > > ``` > > > > > > After applying the quirk: > > > > > > ``` > > > 154 (2) [-] none 154 192417 B 42.199823 42.207788 27.779 fps ts mono/SoE > > > 155 (3) [-] none 155 192040 B 42.231834 42.239791 31.239 fps ts mono/SoE > > > 156 (4) [-] none 156 192213 B 42.263823 42.271822 31.261 fps ts mono/SoE > > > 157 (5) [-] none 157 191981 B 42.299824 42.303827 27.777 fps ts mono/SoE > > > 158 (6) [-] none 158 191953 B 42.331835 42.339811 31.239 fps ts mono/SoE > > > 159 (7) [-] none 159 191904 B 42.363824 42.371813 31.261 fps ts mono/SoE > > > 160 (0) [-] none 160 192210 B 42.399834 42.407801 27.770 fps ts mono/SoE > > > ``` > > > > > > Link: https://lore.kernel.org/lkml/5764213.DvuYhMxLoT@natalenko.name/ > > > Reviewed-by: Ricardo Ribalda <ribalda@chromium.org> > > > Signed-off-by: Oleksandr Natalenko <oleksandr@natalenko.name> > > > --- > > > drivers/media/usb/uvc/uvc_driver.c | 3 ++- > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c > > > index 723e6d5680c2e..444d7089885ea 100644 > > > --- a/drivers/media/usb/uvc/uvc_driver.c > > > +++ b/drivers/media/usb/uvc/uvc_driver.c > > > @@ -2573,7 +2573,8 @@ static const struct usb_device_id uvc_ids[] = { > > > .bInterfaceClass = USB_CLASS_VIDEO, > > > .bInterfaceSubClass = 1, > > > .bInterfaceProtocol = 0, > > > - .driver_info = UVC_INFO_QUIRK(UVC_QUIRK_RESTORE_CTRLS_ON_INIT) }, > > > + .driver_info = UVC_INFO_QUIRK(UVC_QUIRK_RESTORE_CTRLS_ON_INIT > > > + | UVC_QUIRK_INVALID_DEVICE_SOF) }, > > > /* Logitech HD Pro Webcam C922 */ > > > { .match_flags = USB_DEVICE_ID_MATCH_DEVICE > > > | USB_DEVICE_ID_MATCH_INT_INFO, > > > > > > > Gentle ping on this one. > > Ricardo, could you include this in the next version of your hw timestamp > series ? There are no outstanding comments on the series https://patchwork.linuxtv.org/project/linux-media/list/?series=12485 Do you need me to send a v11 with this patch? or you can take that directly from your tree? Thanks! > > > Also, should I have added: > > > > Fixes: 5d0fd3c806b9 ("[media] uvcvideo: Disable hardware timestamps by default") > > > > ? > > I don't think that's needed, no. > > > (it's not that this change re-enables HW timestamping, but > > 5d0fd3c806b9 explicitly mentions C920 as affected) > > -- > Regards, > > Laurent Pinchart
On Thu, Apr 04, 2024 at 08:35:14AM +0200, Ricardo Ribalda wrote: > On Thu, 4 Apr 2024 at 03:11, Laurent Pinchart wrote: > > On Mon, Apr 01, 2024 at 06:45:16PM +0200, Oleksandr Natalenko wrote: > > > On pondělí 25. března 2024 15:26:11, CEST Oleksandr Natalenko wrote: > > > > Similarly to Logitech C922, C920 seems to also suffer from a firmware > > > > bug that breaks hardware timestamping. > > > > > > > > Add a quirk for this camera model too. > > > > > > > > Before applying the quirk: > > > > > > > > ``` > > > > 100 (4) [-] none 100 200717 B 212.919114 213.079004 33.727 fps ts mono/SoE > > > > 101 (5) [-] none 101 200889 B 213.003703 213.114996 11.822 fps ts mono/SoE > > > > 102 (6) [-] none 102 200926 B 213.035571 213.146999 31.379 fps ts mono/SoE > > > > 103 (7) [-] none 103 200839 B 213.067424 213.179003 31.394 fps ts mono/SoE > > > > 104 (0) [-] none 104 200692 B 213.293180 213.214991 4.430 fps ts mono/SoE > > > > 105 (1) [-] none 105 200937 B 213.322374 213.247001 34.254 fps ts mono/SoE > > > > 106 (2) [-] none 106 201013 B 213.352228 213.279005 33.496 fps ts mono/SoE > > > > … > > > > ``` > > > > > > > > After applying the quirk: > > > > > > > > ``` > > > > 154 (2) [-] none 154 192417 B 42.199823 42.207788 27.779 fps ts mono/SoE > > > > 155 (3) [-] none 155 192040 B 42.231834 42.239791 31.239 fps ts mono/SoE > > > > 156 (4) [-] none 156 192213 B 42.263823 42.271822 31.261 fps ts mono/SoE > > > > 157 (5) [-] none 157 191981 B 42.299824 42.303827 27.777 fps ts mono/SoE > > > > 158 (6) [-] none 158 191953 B 42.331835 42.339811 31.239 fps ts mono/SoE > > > > 159 (7) [-] none 159 191904 B 42.363824 42.371813 31.261 fps ts mono/SoE > > > > 160 (0) [-] none 160 192210 B 42.399834 42.407801 27.770 fps ts mono/SoE > > > > ``` > > > > > > > > Link: https://lore.kernel.org/lkml/5764213.DvuYhMxLoT@natalenko.name/ > > > > Reviewed-by: Ricardo Ribalda <ribalda@chromium.org> > > > > Signed-off-by: Oleksandr Natalenko <oleksandr@natalenko.name> > > > > --- > > > > drivers/media/usb/uvc/uvc_driver.c | 3 ++- > > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c > > > > index 723e6d5680c2e..444d7089885ea 100644 > > > > --- a/drivers/media/usb/uvc/uvc_driver.c > > > > +++ b/drivers/media/usb/uvc/uvc_driver.c > > > > @@ -2573,7 +2573,8 @@ static const struct usb_device_id uvc_ids[] = { > > > > .bInterfaceClass = USB_CLASS_VIDEO, > > > > .bInterfaceSubClass = 1, > > > > .bInterfaceProtocol = 0, > > > > - .driver_info = UVC_INFO_QUIRK(UVC_QUIRK_RESTORE_CTRLS_ON_INIT) }, > > > > + .driver_info = UVC_INFO_QUIRK(UVC_QUIRK_RESTORE_CTRLS_ON_INIT > > > > + | UVC_QUIRK_INVALID_DEVICE_SOF) }, > > > > /* Logitech HD Pro Webcam C922 */ > > > > { .match_flags = USB_DEVICE_ID_MATCH_DEVICE > > > > | USB_DEVICE_ID_MATCH_INT_INFO, > > > > > > > > > > Gentle ping on this one. > > > > Ricardo, could you include this in the next version of your hw timestamp > > series ? > > There are no outstanding comments on the series > https://patchwork.linuxtv.org/project/linux-media/list/?series=12485 > > Do you need me to send a v11 with this patch? or you can take that > directly from your tree? Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> and taken in my tree. > > > Also, should I have added: > > > > > > Fixes: 5d0fd3c806b9 ("[media] uvcvideo: Disable hardware timestamps by default") > > > > > > ? > > > > I don't think that's needed, no. > > > > > (it's not that this change re-enables HW timestamping, but > > > 5d0fd3c806b9 explicitly mentions C920 as affected)
diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c index 723e6d5680c2e..444d7089885ea 100644 --- a/drivers/media/usb/uvc/uvc_driver.c +++ b/drivers/media/usb/uvc/uvc_driver.c @@ -2573,7 +2573,8 @@ static const struct usb_device_id uvc_ids[] = { .bInterfaceClass = USB_CLASS_VIDEO, .bInterfaceSubClass = 1, .bInterfaceProtocol = 0, - .driver_info = UVC_INFO_QUIRK(UVC_QUIRK_RESTORE_CTRLS_ON_INIT) }, + .driver_info = UVC_INFO_QUIRK(UVC_QUIRK_RESTORE_CTRLS_ON_INIT + | UVC_QUIRK_INVALID_DEVICE_SOF) }, /* Logitech HD Pro Webcam C922 */ { .match_flags = USB_DEVICE_ID_MATCH_DEVICE | USB_DEVICE_ID_MATCH_INT_INFO,