diff mbox series

[3/3] arm64: dts: imx8mn: Use single port for ISI

Message ID 20240223140445.1885083-4-alexander.stein@ew.tq-group.com (mailing list archive)
State Not Applicable
Headers
Series i.MX8M Nano ISI single port support |

Commit Message

Alexander Stein Feb. 23, 2024, 2:04 p.m. UTC 
  The ISI on i.MX8M Nano only has one port/channel, so use the single port
node. Fixes the DTBS_CHECK warning:
/soc@0/bus@32c00000/isi@32e20000/ports: graph node has single child node
'port@0', #address-cells/#size-cells are not necessary

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 arch/arm64/boot/dts/freescale/imx8mn.dtsi | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

Comments

Krzysztof Kozlowski Feb. 29, 2024, 6:15 p.m. UTC | #1 
On 23/02/2024 16:29, Adam Ford wrote:
> On Fri, Feb 23, 2024 at 8:09 AM Alexander Stein <
> alexander.stein@ew.tq-group.com> wrote:
> 
>> The ISI on i.MX8M Nano only has one port/channel, so use the single port
>> node. Fixes the DTBS_CHECK warning:
>> /soc@0/bus@32c00000/isi@32e20000/ports: graph node has single child node
>> 'port@0', #address-cells/#size-cells are not necessary
>>
>>
> Should we add  fixes tags to both the bindings and the dts?
> 
> adam

No, because original code is correct and we are just choosing here one
style over another. "style" fixes should not be backported.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/freescale/imx8mn.dtsi b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
index 136e75c51251a..de7704aafbc1a 100644
--- a/arch/arm64/boot/dts/freescale/imx8mn.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
@@ -1118,15 +1118,9 @@  isi: isi@32e20000 {
 				power-domains = <&disp_blk_ctrl IMX8MN_DISPBLK_PD_ISI>;
 				status = "disabled";
 
-				ports {
-					#address-cells = <1>;
-					#size-cells = <0>;
-
-					port@0 {
-						reg = <0>;
-						isi_in: endpoint {
-							remote-endpoint = <&mipi_csi_out>;
-						};
+				port {
+					isi_in: endpoint {
+						remote-endpoint = <&mipi_csi_out>;
 					};
 				};
 			};