diff mbox series

v4l2-compliance: Fix building against libc++

Message ID 20240207225732.22970-1-chewi@gentoo.org (mailing list archive)
State Obsoleted
Headers
Series v4l2-compliance: Fix building against libc++ |

Commit Message

James Le Cuirot Feb. 7, 2024, 10:57 p.m. UTC 
  v4l2-test-time32-64.cpp included compiler.h, which checks
_LIBCPP_VERSION. This only works against libc++ when a C++ header has
already been included, which wasn't the case here.

v4l2-test-time32-64.cpp doesn't need to include compiler.h anyway, so
just drop the include.

Signed-off-by: James Le Cuirot <chewi@gentoo.org>
---
 utils/v4l2-compliance/v4l2-test-time32-64.cpp | 1 -
 1 file changed, 1 deletion(-)

Comments

James Le Cuirot Feb. 7, 2024, 11:20 p.m. UTC | #1 
On Wed, 2024-02-07 at 22:57 +0000, James Le Cuirot wrote:
> v4l2-test-time32-64.cpp included compiler.h, which checks
> _LIBCPP_VERSION. This only works against libc++ when a C++ header has
> already been included, which wasn't the case here.
> 
> v4l2-test-time32-64.cpp doesn't need to include compiler.h anyway, so
> just drop the include.
> 
> Signed-off-by: James Le Cuirot <chewi@gentoo.org>
> ---
>  utils/v4l2-compliance/v4l2-test-time32-64.cpp | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/utils/v4l2-compliance/v4l2-test-time32-64.cpp b/utils/v4l2-compliance/v4l2-test-time32-64.cpp
> index e175c055..810fd5e4 100644
> --- a/utils/v4l2-compliance/v4l2-test-time32-64.cpp
> +++ b/utils/v4l2-compliance/v4l2-test-time32-64.cpp
> @@ -16,7 +16,6 @@
>  
>  #include <sys/types.h>
>  
> -#include "compiler.h"
>  #include "v4l2-compliance.h"
>  
>  typedef __s32		old_time32_t;

Sorry, ignore this patch. I'll write a better one soon.
diff mbox series

Patch

diff --git a/utils/v4l2-compliance/v4l2-test-time32-64.cpp b/utils/v4l2-compliance/v4l2-test-time32-64.cpp
index e175c055..810fd5e4 100644
--- a/utils/v4l2-compliance/v4l2-test-time32-64.cpp
+++ b/utils/v4l2-compliance/v4l2-test-time32-64.cpp
@@ -16,7 +16,6 @@ 
 
 #include <sys/types.h>
 
-#include "compiler.h"
 #include "v4l2-compliance.h"
 
 typedef __s32		old_time32_t;