diff mbox series

media: rcar-isp: Disallow unbind of devices

Message ID 20240131180452.844863-1-niklas.soderlund+renesas@ragnatech.se (mailing list archive)
State Accepted
Delegated to: Hans Verkuil
Headers
Series media: rcar-isp: Disallow unbind of devices |

Commit Message

Niklas Söderlund Jan. 31, 2024, 6:04 p.m. UTC 
  It is not safe to unbind and then rebind a subdevice in the rcar-vin
pipeline. Depending on what subdevice and in what order a device is
rebound the rcar-vin driver can misbehave.

Until this can be solved suppress the files in sysfs which allows for
this. This is in line with what is done for other subdevices exclusively
use with the rcar-vin pipeline, e.g. rcar-csi2.

Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
---
 drivers/media/platform/renesas/rcar-isp.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Sakari Ailus March 5, 2024, 11:29 a.m. UTC | #1 
On Wed, Jan 31, 2024 at 07:04:52PM +0100, Niklas Söderlund wrote:
> It is not safe to unbind and then rebind a subdevice in the rcar-vin
> pipeline. Depending on what subdevice and in what order a device is
> rebound the rcar-vin driver can misbehave.
> 
> Until this can be solved suppress the files in sysfs which allows for
> this. This is in line with what is done for other subdevices exclusively
> use with the rcar-vin pipeline, e.g. rcar-csi2.
> 
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>
diff mbox series

Patch

diff --git a/drivers/media/platform/renesas/rcar-isp.c b/drivers/media/platform/renesas/rcar-isp.c
index 530d65fc546b..4512ac338ca5 100644
--- a/drivers/media/platform/renesas/rcar-isp.c
+++ b/drivers/media/platform/renesas/rcar-isp.c
@@ -518,6 +518,7 @@  static void risp_remove(struct platform_device *pdev)
 static struct platform_driver rcar_isp_driver = {
 	.driver = {
 		.name = "rcar-isp",
+		.suppress_bind_attrs = true,
 		.of_match_table = risp_of_id_table,
 	},
 	.probe = risp_probe,