Message ID | 20231204091134.28481-2-ps.report@gmx.net (mailing list archive) |
---|---|
State | Accepted |
Delegated to: | Hans Verkuil |
Headers |
Received: from am.mirrors.kernel.org ([147.75.80.249]) by www.linuxtv.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <linux-media+bounces-1529-patchwork=linuxtv.org@vger.kernel.org>) id 1rA4zf-00AHsY-BP for patchwork@linuxtv.org; Mon, 04 Dec 2023 09:11:59 +0000 Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 626751F211C9 for <patchwork@linuxtv.org>; Mon, 4 Dec 2023 09:11:57 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E41E012E7B; Mon, 4 Dec 2023 09:11:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.net header.i=ps.report@gmx.net header.b="F2ASURiG" X-Original-To: linux-media@vger.kernel.org Received: from mout.gmx.net (mout.gmx.net [212.227.15.15]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6001BD2 for <linux-media@vger.kernel.org>; Mon, 4 Dec 2023 01:11:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1701681102; x=1702285902; i=ps.report@gmx.net; bh=eHIDEU5qXtGT4kE1U3W5nlemyQOFp6glu1xD5RxoNhg=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To: References; b=F2ASURiGQHhrx5SUfd4nYM/HGarcAR3U8DK6raBWKN8I0d3n7T1/Pv0Fbf9udDju kwZoe9YeRjGzVzeJxQw7VlouClu6BLcmcsvmvhVZNBZUyir2CVb3n3gUepEb8hH70 kDAzaJtBpgYO54X5i0yMi/x0UcDNFucURV9M40oLsJyJHwOYT+SOE3YedaJjC3Xo4 kSugzW3nNTBHidd8aHW3ZRHXUzWr+RTY31MnkogGt+4DAHBHYizA99U1OkGDIlkNk JL4h48icDT4qLKTkL8TFYYRp5B+P1rjvlRp3rie2S04i70z9z+2flS42KaA+YN5pt xEauK27CITDjVmzbsA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from localhost.fritz.box ([62.216.209.4]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1Mzyya-1rVR1s1vjK-00x0gn; Mon, 04 Dec 2023 10:11:42 +0100 From: Peter Seiderer <ps.report@gmx.net> To: linux-media@vger.kernel.org Cc: Peter Seiderer <ps.report@gmx.net> Subject: [PATCH v4l-utils v1 2/2] meson: v4l2grab needs libv4lconvert with fork support enabled Date: Mon, 4 Dec 2023 10:11:34 +0100 Message-ID: <20231204091134.28481-2-ps.report@gmx.net> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231204091134.28481-1-ps.report@gmx.net> References: <20231204091134.28481-1-ps.report@gmx.net> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: <linux-media.vger.kernel.org> List-Subscribe: <mailto:linux-media+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-media+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: base64 X-Provags-ID: V03:K1:jrgZ3+gcCI5AB450X8tsXOkuWsaEQTQsYHEjUddY0hrKS/6wSf1 IG+gn2sxQLDHgeLyHgyWFQ/N21qOxVkg8Ut1jpz2FdnfjRl+Mmlbu+CZrj3ae33buQEWCks qpSc50NJ9t+5ptR2xvDndOlt/OVyi76+p3mvA8mL3UW+fHwDBrZoaj/J0EafHDgX0zu/0IR OnPPzQNHID0elunBjCSDg== UI-OutboundReport: notjunk:1;M01:P0:SMSPPX14cT4=;FywpkTYZM4mGSVHqJp+qMGpPzS0 MeOhX7FLnNrSCSbYMMAFCqj0gyLaLeKxg6UICACnuM5Tp1WrzXo0QImIdK1FdCSANuGYzvwzD 3ms4sn5ZEGnE4rM0qa+0Kj86AXjhATkbc1XiYtUB+QHAHhQjlh8iGl7NaMk3d795eBQD37HOd jCzA4Y7nfoXSC6aPMQy/OQKfC9VTrPED2Ug1m4Q8tWiEJCQlht9l7DCLswEDEh5kj9wL1Zzvt PYUqP/u2vv+98WMpmNIdRZfHoClmbmZlzWPbOZJ7WZAnLhoyXxYCrfp3YE0y+eSiLh4kbbU4+ Sbq2JwqIa7j7udu/nxlpjp2q548L2l/XErfqwXlf7u1ZQTtE629pBhDv2cuV/swBTTCp7Puah QYEs5TORLFzoVNJqii78UicOr/X2EFc+C4rzJCBvnMd48rrwJu6BuS1zfv+aY/T9Ikp8lbtSC aXDHZloOQnEsgFF6flnrT/OXpI177IzlsmUpe1CVdMsOZ+cc9MQRu519UoBUFE817NGgb9BVS rVMrAT3oD2AGlhily5qXVMO/JgmmM7eVqhqeL8iKHVMx66bvxOHG/eL+gZF23umSM5YR8peNt HXQn0c4fPI5OpvYvynOxKQRtnAqJ2Bj7vRA+bwrVyZelhHZ+HRIayKTCf74ThrNrajQEU02/E KhPbtq+BQu38XCBTEKCTflDHlu+1I3DwqRYp9NhHrxSB3GVBU5rBDLKXNCk3cAFwRBppft0qC Xk1mHR11uGRs+tr3WLP++UbuDqGZBQ83zz10OTmVxyQ0VQx1ISbmxmx1cJUM9of4vC5f38/Jz M5TrLtCNi6wNBLqukBJgangEVwWNq1BCwlVQokhBFBhI89HO5Z1G/jpT6LpU5iq1OvgYX9a5V 3DPhlE7oUVuYsIftLb87itjrqdM6MV9t7TjCxQ3UZyC2fILZvw3Vcwbf7aTRltaqRkCPcwfh8 xNAWZg== X-LSpam-Score: -3.1 (---) X-LSpam-Report: No, score=-3.1 required=5.0 tests=BAYES_00=-1.9,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,FREEMAIL_FORGED_FROMDOMAIN=0.001,FREEMAIL_FROM=0.001,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1,MIME_BASE64_TEXT=1.741,RCVD_IN_DNSWL_MED=-2.3 autolearn=unavailable autolearn_force=no |
Series |
[v4l-utils,v1,1/2] meson: fix has_function fork detection (needs suitable include)
|
|
Commit Message
Peter Seiderer
Dec. 4, 2023, 9:11 a.m. UTC
- v4l2grab needs libv4lconvert with fork support enabled
Fixes:
FAILED: contrib/test/v4l2grab
.../bootlin-armv7m-uclibc/host/bin/arm-linux-gcc -o contrib/test/v4l2grab contrib/test/v4l2grab.p/v4l2grab.c.o -Wl,--as-needed -Wl,--no-undefined -Wl,-O1 -Wl,-elf2flt=-r -static -Wl,--start-group lib/libv4l2/libv4l2.a lib/libv4lconvert/libv4lconvert.a -largp -pthread -ldl -lm -lrt -Wl,--end-group
.../bootlin-armv7m-uclibc/host/opt/ext-toolchain/arm-buildroot-uclinux-uclibcgnueabi/bin/ld.real: lib/libv4lconvert/libv4lconvert.a(libv4lconvert.c.o): in function `v4lconvert_destroy':
libv4lconvert.c:(.text+0x5c0): undefined reference to `v4lconvert_helper_cleanup'
.../bootlin-armv7m-uclibc/host/opt/ext-toolchain/arm-buildroot-uclinux-uclibcgnueabi/bin/ld.real: lib/libv4lconvert/libv4lconvert.a(libv4lconvert.c.o): in function `v4lconvert_convert_pixfmt':
libv4lconvert.c:(.text+0x1450): undefined reference to `v4lconvert_helper_decompress'
collect2: error: ld returned 1 exit status
Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
Notes:
- patch is more or less a quick work around, maybe an better handling
of the no-fork-case in libv4lconvert (without v4lconvert_helper_cleanup,
v4lconvert_helper_decompress, etc. as they depend on have_fork, see
lib/libv4lconvert/meson.build and conditional helper.c compile)
is possible???
---
contrib/test/meson.build | 2 ++
1 file changed, 2 insertions(+)
Comments
Hello *, On Mon, 4 Dec 2023 10:11:34 +0100, Peter Seiderer <ps.report@gmx.net> wrote: > - v4l2grab needs libv4lconvert with fork support enabled > > Fixes: > > FAILED: contrib/test/v4l2grab > .../bootlin-armv7m-uclibc/host/bin/arm-linux-gcc -o contrib/test/v4l2grab contrib/test/v4l2grab.p/v4l2grab.c.o -Wl,--as-needed -Wl,--no-undefined -Wl,-O1 -Wl,-elf2flt=-r -static -Wl,--start-group lib/libv4l2/libv4l2.a lib/libv4lconvert/libv4lconvert.a -largp -pthread -ldl -lm -lrt -Wl,--end-group > .../bootlin-armv7m-uclibc/host/opt/ext-toolchain/arm-buildroot-uclinux-uclibcgnueabi/bin/ld.real: lib/libv4lconvert/libv4lconvert.a(libv4lconvert.c.o): in function `v4lconvert_destroy': > libv4lconvert.c:(.text+0x5c0): undefined reference to `v4lconvert_helper_cleanup' > .../bootlin-armv7m-uclibc/host/opt/ext-toolchain/arm-buildroot-uclinux-uclibcgnueabi/bin/ld.real: lib/libv4lconvert/libv4lconvert.a(libv4lconvert.c.o): in function `v4lconvert_convert_pixfmt': > libv4lconvert.c:(.text+0x1450): undefined reference to `v4lconvert_helper_decompress' > collect2: error: ld returned 1 exit status > > Signed-off-by: Peter Seiderer <ps.report@gmx.net> > --- > Notes: > - patch is more or less a quick work around, maybe an better handling > of the no-fork-case in libv4lconvert (without v4lconvert_helper_cleanup, > v4lconvert_helper_decompress, etc. as they depend on have_fork, see > lib/libv4lconvert/meson.build and conditional helper.c compile) > is possible??? Did find a more suitable solution (?): diff --git a/lib/libv4lconvert/meson.build b/lib/libv4lconvert/meson.build index 38740755..4bda5671 100644 --- a/lib/libv4lconvert/meson.build +++ b/lib/libv4lconvert/meson.build @@ -91,7 +91,7 @@ if have_fork include_directories : v4l2_utils_incdir) endif -if have_visibility +if have_visibility and have_fork libv4lconvert_c_args += [ '-fvisibility=hidden', '-DHAVE_LIBV4LCONVERT_HELPERS', Will provide an updated patch (or follow up patch as this one is already applied to git master) soon... Regards, Peter > --- > contrib/test/meson.build | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/contrib/test/meson.build b/contrib/test/meson.build > index 29b51df6..c1f40354 100644 > --- a/contrib/test/meson.build > +++ b/contrib/test/meson.build > @@ -25,6 +25,7 @@ sliced_vbi_detect = executable('sliced-vbi-detect', > sliced_vbi_detect_sources, > include_directories : v4l2_utils_incdir) > > +if have_fork > v4l2grab_sources = files( > 'v4l2grab.c', > > @@ -41,6 +42,7 @@ v4l2grab = executable('v4l2grab', > v4l2grab_sources, > dependencies : v4l2grab_deps, > include_directories : v4l2_utils_incdir) > +endif > > driver_test_sources = files( > 'driver-test.c',
diff --git a/contrib/test/meson.build b/contrib/test/meson.build index 29b51df6..c1f40354 100644 --- a/contrib/test/meson.build +++ b/contrib/test/meson.build @@ -25,6 +25,7 @@ sliced_vbi_detect = executable('sliced-vbi-detect', sliced_vbi_detect_sources, include_directories : v4l2_utils_incdir) +if have_fork v4l2grab_sources = files( 'v4l2grab.c', @@ -41,6 +42,7 @@ v4l2grab = executable('v4l2grab', v4l2grab_sources, dependencies : v4l2grab_deps, include_directories : v4l2_utils_incdir) +endif driver_test_sources = files( 'driver-test.c',