[-next] media: cx231xx: Switch to use kmemdup() helper
Commit Message
Use kmemdup() helper instead of open-coding to
simplify the code.
Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
---
drivers/media/usb/cx231xx/cx231xx-core.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
Comments
Hi,
W dniu 15.08.2023 o 13:46, Ruan Jinjie pisze:
> Use kmemdup() helper instead of open-coding to
> simplify the code.
>
> Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
You could consider replacing the magic constant "4096" with some #defined value.
However, to keep a small granularity of changes this could be done in a
separate patch.
If you prefer to leave this patch as-is you can add
Reviewed-by: Andrzej Pietrasiewicz <andrzej.p@collabora.com>
> ---
> drivers/media/usb/cx231xx/cx231xx-core.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/media/usb/cx231xx/cx231xx-core.c b/drivers/media/usb/cx231xx/cx231xx-core.c
> index 727e6268567f..746727ea1a4c 100644
> --- a/drivers/media/usb/cx231xx/cx231xx-core.c
> +++ b/drivers/media/usb/cx231xx/cx231xx-core.c
> @@ -751,10 +751,9 @@ int cx231xx_ep5_bulkout(struct cx231xx *dev, u8 *firmware, u16 size)
> int ret = -ENOMEM;
> u32 *buffer;
>
> - buffer = kzalloc(4096, GFP_KERNEL);
> + buffer = kmemdup(firmware, 4096, GFP_KERNEL);
> if (buffer == NULL)
> return -ENOMEM;
> - memcpy(&buffer[0], firmware, 4096);
>
> ret = usb_bulk_msg(dev->udev, usb_sndbulkpipe(dev->udev, 5),
> buffer, 4096, &actlen, 2000);
@@ -751,10 +751,9 @@ int cx231xx_ep5_bulkout(struct cx231xx *dev, u8 *firmware, u16 size)
int ret = -ENOMEM;
u32 *buffer;
- buffer = kzalloc(4096, GFP_KERNEL);
+ buffer = kmemdup(firmware, 4096, GFP_KERNEL);
if (buffer == NULL)
return -ENOMEM;
- memcpy(&buffer[0], firmware, 4096);
ret = usb_bulk_msg(dev->udev, usb_sndbulkpipe(dev->udev, 5),
buffer, 4096, &actlen, 2000);