[-next,2/2] media: staging: media: sunxi: cedrus: Remove redundant of_match_ptr()

Message ID 20230811024945.2256437-3-ruanjinjie@huawei.com (mailing list archive)
State Accepted
Delegated to: Hans Verkuil
Headers
Series staging: Remove redundant of_match_ptr() macro |

Commit Message

Jinjie Ruan Aug. 11, 2023, 2:49 a.m. UTC
  The driver depends on CONFIG_OF, it is not necessary to use
of_match_ptr() here.

Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
---
 drivers/staging/media/sunxi/cedrus/cedrus.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Jernej Škrabec Aug. 13, 2023, 3:22 p.m. UTC | #1
Dne petek, 11. avgust 2023 ob 04:49:45 CEST je Ruan Jinjie napisal(a):
> The driver depends on CONFIG_OF, it is not necessary to use
> of_match_ptr() here.
> 
> Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>

Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>

Best regards,
Jernej

> ---
>  drivers/staging/media/sunxi/cedrus/cedrus.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/media/sunxi/cedrus/cedrus.c
> b/drivers/staging/media/sunxi/cedrus/cedrus.c index
> 8e248d4a0aec..f52df6836045 100644
> --- a/drivers/staging/media/sunxi/cedrus/cedrus.c
> +++ b/drivers/staging/media/sunxi/cedrus/cedrus.c
> @@ -708,7 +708,7 @@ static struct platform_driver cedrus_driver = {
>  	.remove_new	= cedrus_remove,
>  	.driver		= {
>  		.name		= CEDRUS_NAME,
> -		.of_match_table	= of_match_ptr(cedrus_dt_match),
> +		.of_match_table	= cedrus_dt_match,
>  		.pm		= &cedrus_dev_pm_ops,
>  	},
>  };
  
Paul Kocialkowski Aug. 16, 2023, 10:09 a.m. UTC | #2
Hi,

On Fri 11 Aug 23, 10:49, Ruan Jinjie wrote:
> The driver depends on CONFIG_OF, it is not necessary to use
> of_match_ptr() here.
> 
> Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>

Acked-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>

Thanks for the patch!

Paul

> ---
>  drivers/staging/media/sunxi/cedrus/cedrus.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/media/sunxi/cedrus/cedrus.c b/drivers/staging/media/sunxi/cedrus/cedrus.c
> index 8e248d4a0aec..f52df6836045 100644
> --- a/drivers/staging/media/sunxi/cedrus/cedrus.c
> +++ b/drivers/staging/media/sunxi/cedrus/cedrus.c
> @@ -708,7 +708,7 @@ static struct platform_driver cedrus_driver = {
>  	.remove_new	= cedrus_remove,
>  	.driver		= {
>  		.name		= CEDRUS_NAME,
> -		.of_match_table	= of_match_ptr(cedrus_dt_match),
> +		.of_match_table	= cedrus_dt_match,
>  		.pm		= &cedrus_dev_pm_ops,
>  	},
>  };
> -- 
> 2.34.1
>
  

Patch

diff --git a/drivers/staging/media/sunxi/cedrus/cedrus.c b/drivers/staging/media/sunxi/cedrus/cedrus.c
index 8e248d4a0aec..f52df6836045 100644
--- a/drivers/staging/media/sunxi/cedrus/cedrus.c
+++ b/drivers/staging/media/sunxi/cedrus/cedrus.c
@@ -708,7 +708,7 @@  static struct platform_driver cedrus_driver = {
 	.remove_new	= cedrus_remove,
 	.driver		= {
 		.name		= CEDRUS_NAME,
-		.of_match_table	= of_match_ptr(cedrus_dt_match),
+		.of_match_table	= cedrus_dt_match,
 		.pm		= &cedrus_dev_pm_ops,
 	},
 };