diff mbox series

media: rc: ir-spi: Correct regulator name

Message ID 20230805-ir-spi-v1-1-33af4a556139@gmail.com (mailing list archive)
State New
Delegated to: Sean Young
Headers
Series media: rc: ir-spi: Correct regulator name |

Commit Message

Xilin Wu via B4 Relay Aug. 5, 2023, 11:23 a.m. UTC 
  From: Xilin Wu <wuxilin123@gmail.com>

The driver wrongly assumes regulator is called "irda_regulator"
instead of "power".

Change it to "power" to match device tree binding.

Signed-off-by: Xilin Wu <wuxilin123@gmail.com>
---
 drivers/media/rc/ir-spi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


---
base-commit: 024ff300db33968c133435a146d51ac22db27374
change-id: 20230805-ir-spi-3473c5f34764

Best regards,

Comments

Sean Young Aug. 11, 2023, 9:57 a.m. UTC | #1 
On Sat, Aug 05, 2023 at 07:23:35PM +0800, Xilin Wu via B4 Relay wrote:
> From: Xilin Wu <wuxilin123@gmail.com>
> 
> The driver wrongly assumes regulator is called "irda_regulator"
> instead of "power".
> 
> Change it to "power" to match device tree binding.
> 
> Signed-off-by: Xilin Wu <wuxilin123@gmail.com>
> ---
>  drivers/media/rc/ir-spi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/rc/ir-spi.c b/drivers/media/rc/ir-spi.c
> index bbc81bed4f90..a447bb36100d 100644
> --- a/drivers/media/rc/ir-spi.c
> +++ b/drivers/media/rc/ir-spi.c
> @@ -119,7 +119,7 @@ static int ir_spi_probe(struct spi_device *spi)
>  	if (!idata)
>  		return -ENOMEM;
>  
> -	idata->regulator = devm_regulator_get(&spi->dev, "irda_regulator");
> +	idata->regulator = devm_regulator_get(&spi->dev, "power");

I agree that irda_regulator is not a great name and it probably should have
been picked up in review. However, is it safe to change without breaking
backwards compatibility?

Rob, what do you think?

Thanks
Sean

>  	if (IS_ERR(idata->regulator))
>  		return PTR_ERR(idata->regulator);
>  
> 
> ---
> base-commit: 024ff300db33968c133435a146d51ac22db27374
> change-id: 20230805-ir-spi-3473c5f34764
> 
> Best regards,
> -- 
> Xilin Wu <wuxilin123@gmail.com>
diff mbox series

Patch

diff --git a/drivers/media/rc/ir-spi.c b/drivers/media/rc/ir-spi.c
index bbc81bed4f90..a447bb36100d 100644
--- a/drivers/media/rc/ir-spi.c
+++ b/drivers/media/rc/ir-spi.c
@@ -119,7 +119,7 @@  static int ir_spi_probe(struct spi_device *spi)
 	if (!idata)
 		return -ENOMEM;
 
-	idata->regulator = devm_regulator_get(&spi->dev, "irda_regulator");
+	idata->regulator = devm_regulator_get(&spi->dev, "power");
 	if (IS_ERR(idata->regulator))
 		return PTR_ERR(idata->regulator);