[v4,1/3] media: dt-bindings: nxp,imx8-isi: add i.MX93 ISI compatible string

Message ID 20230628064251.1774296-2-guoniu.zhou@oss.nxp.com (mailing list archive)
State Superseded
Headers
Series add ISI support for iMX93 |

Commit Message

G.N. Zhou (OSS) June 28, 2023, 6:42 a.m. UTC
  From: "Guoniu.zhou" <guoniu.zhou@nxp.com>

Add the compatible string support for i.MX93 ISI.

Signed-off-by: Guoniu.zhou <guoniu.zhou@nxp.com>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Tommaso Merciai <tomm.merciai@gmail.com>
---
 Documentation/devicetree/bindings/media/nxp,imx8-isi.yaml | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
  

Comments

Rob Herring June 28, 2023, 9:18 a.m. UTC | #1
On Wed, 28 Jun 2023 14:42:49 +0800, guoniu.zhou@oss.nxp.com wrote:
> From: "Guoniu.zhou" <guoniu.zhou@nxp.com>
> 
> Add the compatible string support for i.MX93 ISI.
> 
> Signed-off-by: Guoniu.zhou <guoniu.zhou@nxp.com>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Reviewed-by: Tommaso Merciai <tomm.merciai@gmail.com>
> ---
>  Documentation/devicetree/bindings/media/nxp,imx8-isi.yaml | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/clock/milbeaut-clock.example.dtb: /example-2/serial@1e700010: failed to match any schema with compatible: ['socionext,milbeaut-usio-uart']
Documentation/devicetree/bindings/clock/sprd,sc9863a-clk.example.dtb: /example-1/syscon@20e00000: failed to match any schema with compatible: ['sprd,sc9863a-glbregs', 'syscon', 'simple-mfd']
Documentation/devicetree/bindings/leds/common.example.dtb: /example-2/i2c/led-controller@30: failed to match any schema with compatible: ['panasonic,an30259a']
Documentation/devicetree/bindings/sound/audio-graph-card2.example.dtb: /example-0/cpu: failed to match any schema with compatible: ['cpu-driver']
Documentation/devicetree/bindings/sound/audio-graph-card2.example.dtb: /example-0/codec: failed to match any schema with compatible: ['codec-driver']
Documentation/devicetree/bindings/thermal/brcm,avs-ro-thermal.example.dtb: /example-0/avs-monitor@7d5d2000: failed to match any schema with compatible: ['brcm,bcm2711-avs-monitor', 'syscon', 'simple-mfd']
Documentation/devicetree/bindings/thermal/imx-thermal.example.dtb: /example-0/anatop@20c8000: failed to match any schema with compatible: ['fsl,imx6q-anatop', 'syscon', 'simple-mfd']
Documentation/devicetree/bindings/i2c/qcom,i2c-cci.example.dtb: /example-0/cci@ac4a000/i2c-bus@1/camera@60: failed to match any schema with compatible: ['ovti,ov7251']
Documentation/devicetree/bindings/iio/adc/ti,palmas-gpadc.example.dtb: /example-0/pmic: failed to match any schema with compatible: ['ti,twl6035-pmic', 'ti,palmas-pmic']
Documentation/devicetree/bindings/iio/adc/ti,palmas-gpadc.example.dtb: /example-0/pmic: failed to match any schema with compatible: ['ti,twl6035-pmic', 'ti,palmas-pmic']
Documentation/devicetree/bindings/input/mediatek,pmic-keys.example.dtb: /example-0/pmic: failed to match any schema with compatible: ['mediatek,mt6397']
Documentation/devicetree/bindings/input/sprd,sc27xx-vibrator.example.dtb: /example-0/pmic@0: failed to match any schema with compatible: ['sprd,sc2731']
Documentation/devicetree/bindings/dma/dma-controller.example.dtb: /example-0/dma-controller@48000000: failed to match any schema with compatible: ['ti,omap-sdma']
Documentation/devicetree/bindings/dma/dma-router.example.dtb: /example-0/dma-router@4a002b78: failed to match any schema with compatible: ['ti,dra7-dma-crossbar']
Documentation/devicetree/bindings/memory-controllers/ingenic,nemc.example.dtb: /example-0/memory-controller@13410000/ethernet@6: failed to match any schema with compatible: ['davicom,dm9000']
Documentation/devicetree/bindings/arm/hisilicon/controller/sysctrl.example.dtb: /example-0/system-controller@802000/clock@0: failed to match any schema with compatible: ['hisilicon,hi3620-clock']
Documentation/devicetree/bindings/arm/hisilicon/controller/cpuctrl.example.dtb: /example-0/cpuctrl@a22000/clock@0: failed to match any schema with compatible: ['hisilicon,hix5hd2-clock']
Documentation/devicetree/bindings/arm/hisilicon/controller/hi3798cv200-perictrl.example.dtb: /example-0/peripheral-controller@8a20000/phy@850: failed to match any schema with compatible: ['hisilicon,hi3798cv200-combphy']
Documentation/devicetree/bindings/media/rockchip-isp1.example.dtb: /example-0/parent/i2c/camera@36: failed to match any schema with compatible: ['ovti,ov5695']
Documentation/devicetree/bindings/net/marvell,mvusb.example.dtb: /example-0/usb/mdio@1/switch@0: failed to match any schema with compatible: ['marvell,mv88e6190']
Documentation/devicetree/bindings/net/qca,ar71xx.example.dtb: /example-0/ethernet@1a000000/mdio/switch@10: failed to match any schema with compatible: ['qca,ar9331-switch']
Documentation/devicetree/bindings/reset/hisilicon,hi3660-reset.example.dtb: /example-0/iomcu@ffd7e000: failed to match any schema with compatible: ['hisilicon,hi3660-iomcu', 'syscon']

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230628064251.1774296-2-guoniu.zhou@oss.nxp.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
  
G.N. Zhou (OSS) June 28, 2023, 11:56 a.m. UTC | #2
Hi Rob,

Thanks for your report.

As you said, I have ran " make dt_binding_check DT_SCHEMA_FIELS=../../nxp,imx8-isi.yaml" before sending the patch and don't see errors. 
I try to reproduce the issue you said and update dtschema, yamllint, but can't only check nxp,imx8-isi.yaml. But I can reproduce the issue
no matter whether include my patches or not when enable all test examples. So seems these errors are not introduced by my patches. I'm
not sure if I miss something?

My test command:
# no error or warning found
make DT_CHECKER_FLAGS=-y dt_binding_check -j8 DT_SCHEMA_FILES=Documentation/devicetree/bindings/media/nxp,imx8-isi.yaml

# found errors as you reported no matter whether include my patches or not
make DT_CHECKER_FLAGS=-m dt_binding_check

Kernel version:
V6.4_rc1

dtschema version: 2023.6.1
yamllint version: 1.32.0

Best Regards
G.N Zhou

> -----Original Message-----
> From: Rob Herring <robh@kernel.org>
> Sent: 2023年6月28日 17:18
> To: G.N. Zhou (OSS) <guoniu.zhou@oss.nxp.com>
> Cc: krzysztof.kozlowski+dt@linaro.org; sakari.ailus@linux.intel.com;
> laurent.pinchart@ideasonboard.com; mchehab@kernel.org;
> robh+dt@kernel.org; Xavier Roumegue (OSS) <xavier.roumegue@oss.nxp.com>;
> conor+dt@kernel.org; linux-media@vger.kernel.org; dl-linux-imx
> <linux-imx@nxp.com>; kernel@pengutronix.de; devicetree@vger.kernel.org;
> jacopo.mondi@ideasonboard.com
> Subject: Re: [PATCH v4 1/3] media: dt-bindings: nxp,imx8-isi: add i.MX93 ISI
> compatible string
> 
> Caution: This is an external email. Please take care when clicking links or opening
> attachments. When in doubt, report the message using the 'Report this email'
> button
> 
> 
> On Wed, 28 Jun 2023 14:42:49 +0800, guoniu.zhou@oss.nxp.com wrote:
> > From: "Guoniu.zhou" <guoniu.zhou@nxp.com>
> >
> > Add the compatible string support for i.MX93 ISI.
> >
> > Signed-off-by: Guoniu.zhou <guoniu.zhou@nxp.com>
> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > Reviewed-by: Tommaso Merciai <tomm.merciai@gmail.com>
> > ---
> >  Documentation/devicetree/bindings/media/nxp,imx8-isi.yaml | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> >
> 
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> Documentation/devicetree/bindings/clock/milbeaut-clock.example.dtb:
> /example-2/serial@1e700010: failed to match any schema with compatible:
> ['socionext,milbeaut-usio-uart']
> Documentation/devicetree/bindings/clock/sprd,sc9863a-clk.example.dtb:
> /example-1/syscon@20e00000: failed to match any schema with compatible:
> ['sprd,sc9863a-glbregs', 'syscon', 'simple-mfd']
> Documentation/devicetree/bindings/leds/common.example.dtb:
> /example-2/i2c/led-controller@30: failed to match any schema with compatible:
> ['panasonic,an30259a']
> Documentation/devicetree/bindings/sound/audio-graph-card2.example.dtb:
> /example-0/cpu: failed to match any schema with compatible: ['cpu-driver']
> Documentation/devicetree/bindings/sound/audio-graph-card2.example.dtb:
> /example-0/codec: failed to match any schema with compatible: ['codec-driver']
> Documentation/devicetree/bindings/thermal/brcm,avs-ro-thermal.example.dtb:
> /example-0/avs-monitor@7d5d2000: failed to match any schema with
> compatible: ['brcm,bcm2711-avs-monitor', 'syscon', 'simple-mfd']
> Documentation/devicetree/bindings/thermal/imx-thermal.example.dtb:
> /example-0/anatop@20c8000: failed to match any schema with compatible:
> ['fsl,imx6q-anatop', 'syscon', 'simple-mfd']
> Documentation/devicetree/bindings/i2c/qcom,i2c-cci.example.dtb:
> /example-0/cci@ac4a000/i2c-bus@1/camera@60: failed to match any schema
> with compatible: ['ovti,ov7251']
> Documentation/devicetree/bindings/iio/adc/ti,palmas-gpadc.example.dtb:
> /example-0/pmic: failed to match any schema with compatible:
> ['ti,twl6035-pmic', 'ti,palmas-pmic']
> Documentation/devicetree/bindings/iio/adc/ti,palmas-gpadc.example.dtb:
> /example-0/pmic: failed to match any schema with compatible:
> ['ti,twl6035-pmic', 'ti,palmas-pmic']
> Documentation/devicetree/bindings/input/mediatek,pmic-keys.example.dtb:
> /example-0/pmic: failed to match any schema with compatible:
> ['mediatek,mt6397']
> Documentation/devicetree/bindings/input/sprd,sc27xx-vibrator.example.dtb:
> /example-0/pmic@0: failed to match any schema with compatible:
> ['sprd,sc2731']
> Documentation/devicetree/bindings/dma/dma-controller.example.dtb:
> /example-0/dma-controller@48000000: failed to match any schema with
> compatible: ['ti,omap-sdma']
> Documentation/devicetree/bindings/dma/dma-router.example.dtb:
> /example-0/dma-router@4a002b78: failed to match any schema with
> compatible: ['ti,dra7-dma-crossbar']
> Documentation/devicetree/bindings/memory-controllers/ingenic,nemc.example
> .dtb: /example-0/memory-controller@13410000/ethernet@6: failed to match
> any schema with compatible: ['davicom,dm9000']
> Documentation/devicetree/bindings/arm/hisilicon/controller/sysctrl.example.dt
> b: /example-0/system-controller@802000/clock@0: failed to match any schema
> with compatible: ['hisilicon,hi3620-clock']
> Documentation/devicetree/bindings/arm/hisilicon/controller/cpuctrl.example.dt
> b: /example-0/cpuctrl@a22000/clock@0: failed to match any schema with
> compatible: ['hisilicon,hix5hd2-clock']
> Documentation/devicetree/bindings/arm/hisilicon/controller/hi3798cv200-peric
> trl.example.dtb: /example-0/peripheral-controller@8a20000/phy@850: failed
> to match any schema with compatible: ['hisilicon,hi3798cv200-combphy']
> Documentation/devicetree/bindings/media/rockchip-isp1.example.dtb:
> /example-0/parent/i2c/camera@36: failed to match any schema with
> compatible: ['ovti,ov5695']
> Documentation/devicetree/bindings/net/marvell,mvusb.example.dtb:
> /example-0/usb/mdio@1/switch@0: failed to match any schema with
> compatible: ['marvell,mv88e6190']
> Documentation/devicetree/bindings/net/qca,ar71xx.example.dtb:
> /example-0/ethernet@1a000000/mdio/switch@10: failed to match any schema
> with compatible: ['qca,ar9331-switch']
> Documentation/devicetree/bindings/reset/hisilicon,hi3660-reset.example.dtb:
> /example-0/iomcu@ffd7e000: failed to match any schema with compatible:
> ['hisilicon,hi3660-iomcu', 'syscon']
> 
> doc reference errors (make refcheckdocs):
> 
> See
> https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230628064
> 251.1774296-2-guoniu.zhou@oss.nxp.com
> 
> The base for the series is generally the latest rc1. A different dependency should
> be noted in *this* patch.
> 
> If you already ran 'make dt_binding_check' and didn't see the above error(s),
> then make sure 'yamllint' is installed and dt-schema is up to
> date:
> 
> pip3 install dtschema --upgrade
> 
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking your
> schema. However, it must be unset to test all examples with your schema.
  
Rob Herring June 28, 2023, 3:35 p.m. UTC | #3
On Wed, Jun 28, 2023 at 11:56:13AM +0000, G.N. Zhou (OSS) wrote:
> Hi Rob,
> 
> Thanks for your report.
> 
> As you said, I have ran " make dt_binding_check DT_SCHEMA_FIELS=../../nxp,imx8-isi.yaml" before sending the patch and don't see errors. 
> I try to reproduce the issue you said and update dtschema, yamllint, but can't only check nxp,imx8-isi.yaml. But I can reproduce the issue
> no matter whether include my patches or not when enable all test examples. So seems these errors are not introduced by my patches. I'm
> not sure if I miss something?

You can ignore this.
  

Patch

diff --git a/Documentation/devicetree/bindings/media/nxp,imx8-isi.yaml b/Documentation/devicetree/bindings/media/nxp,imx8-isi.yaml
index 6038b9b5ab36..e4665469a86c 100644
--- a/Documentation/devicetree/bindings/media/nxp,imx8-isi.yaml
+++ b/Documentation/devicetree/bindings/media/nxp,imx8-isi.yaml
@@ -21,6 +21,7 @@  properties:
     enum:
       - fsl,imx8mn-isi
       - fsl,imx8mp-isi
+      - fsl,imx93-isi
 
   reg:
     maxItems: 1
@@ -72,7 +73,9 @@  allOf:
       properties:
         compatible:
           contains:
-            const: fsl,imx8mn-isi
+            enum:
+              - fsl,imx8mn-isi
+              - fsl,imx93-isi
     then:
       properties:
         interrupts: