| Message ID | 20230124013014.23578-1-rdunlap@infradead.org (mailing list archive) |
|---|---|
| State | Obsoleted |
| Headers |
Received: from vger.kernel.org ([23.128.96.18])
by www.linuxtv.org with esmtp (Exim 4.92)
(envelope-from <linux-media-owner@vger.kernel.org>)
id 1pK88j-007uVP-PS; Tue, 24 Jan 2023 01:30:24 +0000
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S232250AbjAXBaT (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other);
Mon, 23 Jan 2023 20:30:19 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54724 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S231760AbjAXBaS (ORCPT
<rfc822;linux-media@vger.kernel.org>);
Mon, 23 Jan 2023 20:30:18 -0500
Received: from bombadil.infradead.org (bombadil.infradead.org
[IPv6:2607:7c80:54:3::133])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 206D312869;
Mon, 23 Jan 2023 17:30:17 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:
Content-ID:Content-Description:In-Reply-To:References;
bh=nSp19ujQ+ktxCD6Dze1xGnN3rj3fGXlTk3QIIyKXR7Q=;
b=RKmQLDt+q2mx7+HZ2KoFnjklUW
uiYSwBVvbxB9kllH9g46k8r3ryyb7gIDxzK5XqU9xan0Fpog1a8yc+YHqBw/2yeXD+jgKxUAQAwGA
6zSVJQh7syc6nN0q0FoK6d5I7A7Lk4OYe32BRvosylNjP0v0KzH9uwroW4V4nFkQPyHhbXL4oOvAv
6ai0v/4W/7Wiirl68/E5FJ6d/X+Ezekwtjka2ZtsBCsGCYDaotELoBqUzjYJYIJZkTcRi4vSu6WiG
CeJN++U+0RH5HMC3y+hoCm4Racd2ONn1BNVQkZNeopViJ7sC0o7PBfpi3JNPSH+8fyk11Hy2Y3nKv
QAgDymaA==;
Received: from [2601:1c2:d80:3110::9307] (helo=bombadil.infradead.org)
by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat
Linux))
id 1pK88d-00223C-T5; Tue, 24 Jan 2023 01:30:15 +0000
From: Randy Dunlap <rdunlap@infradead.org>
To: linux-kernel@vger.kernel.org
Cc: Randy Dunlap <rdunlap@infradead.org>,
kernel test robot <lkp@intel.com>,
Hans de Goede <hdegoede@redhat.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
linux-media@vger.kernel.org
Subject: [PATCH] media: atomisp: fix build error, use vb2 interfaces
Date: Mon, 23 Jan 2023 17:30:14 -0800
Message-Id: <20230124013014.23578-1-rdunlap@infradead.org>
X-Mailer: git-send-email 2.39.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,
SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-media.vger.kernel.org>
X-Mailing-List: linux-media@vger.kernel.org
X-LSpam-Score: -2.5 (--)
X-LSpam-Report: No,
score=-2.5 required=5.0 tests=BAYES_00=-1.9,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1
autolearn=ham autolearn_force=no
|
| Series |
media: atomisp: fix build error, use vb2 interfaces
|
|
Commit Message
Randy Dunlap
Jan. 24, 2023, 1:30 a.m. UTC
The atomisp driver uses functions that are provided by VIDEOBUF2_VMALLOC
instead of VIDEOBUF_VMALLOC, so change the 'select' so that the correct
interfaces are built.
ld: drivers/staging/media/atomisp/pci/atomisp_fops.o: in function `atomisp_init_pipe':
drivers/staging/media/atomisp/pci/atomisp_fops.c:649: undefined reference to `vb2_vmalloc_memops'
Reported-by: kernel test robot <lkp@intel.com>
Fixes: 9d4fa1a16b28 ("media: atomisp: cleanup directory hierarchy")
Fixes: ad85094b293e ("Revert "media: staging: atomisp: Remove driver"")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-media@vger.kernel.org
---
drivers/staging/media/atomisp/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Hi Randy, On 1/24/23 02:30, Randy Dunlap wrote: > The atomisp driver uses functions that are provided by VIDEOBUF2_VMALLOC > instead of VIDEOBUF_VMALLOC, so change the 'select' so that the correct > interfaces are built. > > ld: drivers/staging/media/atomisp/pci/atomisp_fops.o: in function `atomisp_init_pipe': > drivers/staging/media/atomisp/pci/atomisp_fops.c:649: undefined reference to `vb2_vmalloc_memops' > > Reported-by: kernel test robot <lkp@intel.com> > Fixes: 9d4fa1a16b28 ("media: atomisp: cleanup directory hierarchy") > Fixes: ad85094b293e ("Revert "media: staging: atomisp: Remove driver"") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Hans de Goede <hdegoede@redhat.com> > Cc: Mauro Carvalho Chehab <mchehab@kernel.org> > Cc: Sakari Ailus <sakari.ailus@linux.intel.com> > Cc: linux-media@vger.kernel.org Thank you for the patch, the same patch was already posted by Arnd a while ago: https://lore.kernel.org/linux-media/20230104082212.3770415-1-arnd@kernel.org/ but this has unfortunately not found its way to Linus' tree yet. Regards, Hans > --- > drivers/staging/media/atomisp/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff -- a/drivers/staging/media/atomisp/Kconfig b/drivers/staging/media/atomisp/Kconfig > --- a/drivers/staging/media/atomisp/Kconfig > +++ b/drivers/staging/media/atomisp/Kconfig > @@ -14,7 +14,7 @@ config VIDEO_ATOMISP > depends on VIDEO_DEV && INTEL_ATOMISP > depends on PMIC_OPREGION > select IOSF_MBI > - select VIDEOBUF_VMALLOC > + select VIDEOBUF2_VMALLOC > select VIDEO_V4L2_SUBDEV_API > help > Say Y here if your platform supports Intel Atom SoC >
diff -- a/drivers/staging/media/atomisp/Kconfig b/drivers/staging/media/atomisp/Kconfig --- a/drivers/staging/media/atomisp/Kconfig +++ b/drivers/staging/media/atomisp/Kconfig @@ -14,7 +14,7 @@ config VIDEO_ATOMISP depends on VIDEO_DEV && INTEL_ATOMISP depends on PMIC_OPREGION select IOSF_MBI - select VIDEOBUF_VMALLOC + select VIDEOBUF2_VMALLOC select VIDEO_V4L2_SUBDEV_API help Say Y here if your platform supports Intel Atom SoC